Update app.py

app.py

@@ -7,6 +7,7 @@ import json
 import firebase_admin
 from firebase_admin import credentials, db
 from datetime import datetime
+import numpy as np # Added for color logic
 
 # --- Configuration ---
 # The Firebase DB reference name must match the one used in your agent (App3.txt)
@@ -121,36 +122,47 @@ def create_equity_curve(df):
     return fig
 
 def create_pnl_analytics_charts(df):
-    """Creates bar charts for PnL breakdown by strategy and regime."""
+    """Creates bar charts for PnL breakdown by strategy and regime with distinct profit/loss colors."""
     if df.empty:
         no_data_fig = px.bar(title="PnL by Strategy (No Data)").update_layout(template="plotly_dark")
         return no_data_fig, no_data_fig
 
-    # PnL by Strategy
+    # Define the discrete colors for profit (green) and loss (red)
+    color_map = {'Profit': 'darkgreen', 'Loss': 'darkred'}
+
+    # --- PnL by Strategy Chart ---
     pnl_by_strategy = df.groupby('strategy_chosen')['pnl'].sum().reset_index()
+    # Create a new column to categorize as 'Profit' or 'Loss'
+    pnl_by_strategy['Outcome'] = np.where(pnl_by_strategy['pnl'] >= 0, 'Profit', 'Loss')
+    
     fig_strategy = px.bar(
         pnl_by_strategy,
         x='strategy_chosen',
         y='pnl',
-        color='pnl',
-        color_continuous_scale=px.colors.diverging.RdYlGn,
+        color='Outcome',            # Color bars based on the 'Outcome' column
+        color_discrete_map=color_map, # Apply our specific green/red colors
         title="PnL by Strategy",
         labels={'strategy_chosen': 'Strategy', 'pnl': 'Total PnL'}
     )
-    fig_strategy.update_layout(template="plotly_dark", title_x=0.5, font=dict(color="white"))
+    # Clean up layout: dark theme, centered title, no redundant legend
+    fig_strategy.update_layout(template="plotly_dark", title_x=0.5, font=dict(color="white"), showlegend=False)
 
-    # PnL by Market Regime
+    # --- PnL by Market Regime Chart ---
     pnl_by_regime = df.groupby('market_regime')['pnl'].sum().reset_index()
+    # Create the same 'Outcome' column for this chart
+    pnl_by_regime['Outcome'] = np.where(pnl_by_regime['pnl'] >= 0, 'Profit', 'Loss')
+
     fig_regime = px.bar(
         pnl_by_regime,
         x='market_regime',
         y='pnl',
-        color='pnl',
-        color_continuous_scale=px.colors.diverging.RdYlGn,
+        color='Outcome',            # Color bars based on the 'Outcome' column
+        color_discrete_map=color_map, # Apply our specific green/red colors
         title="PnL by Market Regime",
         labels={'market_regime': 'Market Regime', 'pnl': 'Total PnL'}
     )
-    fig_regime.update_layout(template="plotly_dark", title_x=0.5, font=dict(color="white"))
+    # Clean up layout
+    fig_regime.update_layout(template="plotly_dark", title_x=0.5, font=dict(color="white"), showlegend=False)
 
     return fig_strategy, fig_regime
 
@@ -192,7 +204,7 @@ def update_dashboard():
 
     return (kpis["total_pnl"], kpis["win_rate"], kpis["total_closed_trades"], kpis["average_pnl"],
             equity_plot,
-            open_trades_display.iloc[::-1], # Show newest first
+            open_ trades_display.iloc[::-1], # Show newest first
             closed_trades_display.iloc[::-1], # Show newest first
             strategy_plot,
             regime_plot,
@@ -250,10 +262,6 @@ with gr.Blocks(theme=gr.themes.Glass(), title="Agent Analyst Hub") as demo:
     demo.load(fn=update_dashboard, inputs=[], outputs=outputs_list)
 
 if __name__ == "__main__":
-    # For local testing, you can set environment variables like this:
-    # os.environ['FIRESTORE_SA_KEY'] = '{"type": "service_account", ...}'
-    # os.environ['FIREBASE_DB_URL'] = 'https://your-project-id.firebaseio.com/'
-    
     # Check if secrets are present before launching
     if not all([os.environ.get(k) for k in ['FIRESTORE_SA_KEY', 'FIREBASE_DB_URL']]):
         print("\nWARNING: Firebase secrets are not set as environment variables.")