vertex ai minor bugs 1

src/interview_logic.py

@@ -10,50 +10,32 @@ EXCEL_QUESTIONS = [
     "What is Conditional Formatting in Excel? Can you provide an example?",
 ]
 
-# --- CORRECTED FUNCTION ---
 def start_interview(state: dict) -> dict:
     """
-    This function now ONLY adds a welcome message. It APPENDS to the history,
-    preserving the user's first message. The graph will then transition to 'ask_question'
-    to ask the first question.
+    Appends a welcome message to the history, preserving the user's first message.
     """
     intro_message = "Welcome to the automated Excel skills assessment! I will ask you a series of questions to gauge your knowledge. Let's start with the first one."
-    
-    # Get the existing history from the state
     history = state.get("interview_history", [])
-    
-    # Append the welcome message
     history.append(("ai", intro_message))
-
-    # Return the updated state. We do NOT ask a question here.
     return {
         **state,
         "interview_status": 1,
-        "interview_history": history, # Use the modified history
+        "interview_history": history,
         "questions": EXCEL_QUESTIONS,
-        "question_index": 0, # Ensure index starts at 0 for the first question
+        "question_index": 0,
         "evaluations": [],
-        "warnings": [],
-        "final_feedback": "",
     }
 
-
 def ask_question(state: dict) -> dict:
-    """
-    This function is now responsible for asking ALL questions, including the first one.
-    It remains unchanged but its role is now clearer.
-    """
+    """Asks the current question based on the question_index."""
     question_index = state["question_index"]
     current_question = state["questions"][question_index]
-    
     history = state.get("interview_history", [])
     history.append(("ai", current_question))
-    
-    return { **state, "interview_history": history }
-
+    return {**state, "interview_history": history}
 
 def process_user_response(state: dict) -> dict:
-    """This function remains unchanged."""
+    """Evaluates the user's response and appends the evaluation to history."""
     history = state.get("interview_history", [])
     user_response = history[-1][1]
 
@@ -73,13 +55,12 @@ def process_user_response(state: dict) -> dict:
     
     evaluation = get_llm_response(evaluation_prompt)
     
-    # Prepend the evaluation with a clear marker for the user
+    # Add a clear marker for the user
     history.append(("ai", f"**Evaluation:**\n{evaluation}"))
     
     evaluations = state.get("evaluations", [])
     evaluations.append(evaluation)
 
-    # Increment the question index for the next turn
     return {
         **state, 
         "interview_history": history,
@@ -88,7 +69,7 @@ def process_user_response(state: dict) -> dict:
     }
 
 def generate_final_report(state: dict) -> dict:
-    """This function remains unchanged."""
+    """Generates and appends the final performance summary."""
     interview_transcript = "\n".join([f"{speaker.capitalize()}: {text}" for speaker, text in state['interview_history']])
     evaluations_summary = "\n\n".join(f"Evaluation for Q{i+1}:\n{e}" for i, e in enumerate(state['evaluations']))
 
@@ -99,31 +80,32 @@ def generate_final_report(state: dict) -> dict:
     )
     
     final_feedback = get_llm_response(report_prompt)
-
     history = state.get("interview_history", [])
+    # Add a clear marker for the user
     history.append(("ai", f"**Final Performance Summary:**\n{final_feedback}"))
 
     return {**state, "final_feedback": final_feedback, "interview_history": history, "interview_status": 2}
 
-
-# --- CORRECTED ROUTING ---
-# The routing logic itself is fine, but its behavior is now correct because
-# the nodes it routes to have been fixed.
+# --- CORRECTED ROUTING LOGIC ---
 
 def route_after_evaluation(state: dict):
+    """Routes to the next step after a user's response has been processed."""
     if state.get("interview_status") == 2:
         return "terminate"
-    # The evaluation node now just adds feedback, so we check the index to see if we should ask another question or end.
     elif state["question_index"] >= len(state["questions"]):
         return "generate_final_report"
     else:
         return "ask_question"
 
 def route_start_of_interview(state: dict):
-    # This logic is now correct. If history is empty, the status is 0.
-    # The app.py will add the first user message, making the history non-empty,
-    # so the graph will correctly call start_interview.
-    if not state.get("interview_history"):
+    """
+    CORRECTED: This is the critical fix.
+    Checks if it's the very first user message to start the interview.
+    Otherwise, it processes the message as an answer.
+    """
+    # If the history has exactly one turn, it must be the user's initial message.
+    if len(state["interview_history"]) == 1:
         return "start_interview"
+    # Otherwise, the user is responding to a question.
     else:
-        return "process_user_response"
+        return "process_user_response"