File size: 2,287 Bytes
42a0d15 37b5223 42a0d15 37b5223 42a0d15 37b5223 42a0d15 2a72aeb 42a0d15 2a72aeb 42a0d15 37b5223 42a0d15 37b5223 42a0d15 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 | """
Ukweli — Feedback Endpoint
POST /feedback — Collect user ratings and corrections on RAG responses.
Requires registered or higher tier (per Endpoint Security Matrix).
"""
from __future__ import annotations
import logging
from fastapi import APIRouter, Depends, HTTPException, status
from sqlalchemy import select
from sqlalchemy.ext.asyncio import AsyncSession
from app.api.auth import AuthContext, require_auth
from app.db.session import get_db_session
from app.models.database import Feedback, QueryLog
from app.models.enums import AuthTier
from app.models.schemas import FeedbackRequest, FeedbackResponse
logger = logging.getLogger("ukweli.api.feedback")
router = APIRouter(tags=["Feedback"])
@router.post("/feedback", response_model=FeedbackResponse)
async def submit_feedback(
request: FeedbackRequest,
db: AsyncSession = Depends(get_db_session),
auth: AuthContext = Depends(require_auth),
) -> FeedbackResponse:
"""
Submit feedback on a query response.
Validates that the query_id exists before recording.
"""
# Verify tier requirements (Registered or higher)
if auth.tier == AuthTier.PUBLIC.value:
raise HTTPException(
status_code=status.HTTP_403_FORBIDDEN,
detail="Feedback submission requires a registered account or API key.",
)
# Verify the query exists
result = await db.execute(
select(QueryLog.id).where(QueryLog.id == request.query_id)
)
query_exists = result.scalar_one_or_none()
if query_exists is None:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail=f"Query ID {request.query_id} not found.",
)
# Create feedback record
feedback = Feedback(
query_id=request.query_id,
rating=request.rating.value,
correction=request.correction,
suggested_citation=request.suggested_citation,
review_status="pending",
)
db.add(feedback)
await db.flush()
logger.info(
"Feedback recorded: query_id=%s, tier=%s, rating=%d, has_correction=%s",
request.query_id,
auth.tier,
request.rating.value,
request.correction is not None,
)
return FeedbackResponse(status="recorded", review_status="pending")
|