Update app.py

app.py

@@ -5,6 +5,7 @@ from datetime import datetime
 from transformers import pipeline
 from simple_salesforce import Salesforce, SalesforceLogin
 from dotenv import load_dotenv
+import xml.etree.ElementTree as ET  # NEW: for parsing metadata
 
 # ---------- Load Environment Variables ----------
 load_dotenv()
@@ -34,11 +35,11 @@ severities = {
     "Best Practice": "Low"
 }
 
-# ---------- Mock Knowledge Base ----------
+# ---------- Knowledge Base ----------
 salesforce_knowledge_base = {
     "governor limits soql": "In Salesforce, the governor limit for SOQL queries is 100 per synchronous transaction and 200 per asynchronous transaction.",
     "governor limits dml": "The governor limit for DML statements is 150 per transaction.",
-    "bulkify apex trigger": "...",  # Truncated for brevity
+    "bulkify apex trigger": "...",
     "soql injection": "...",
     "lwc best practices": "...",
     "batch apex": "..."
@@ -69,7 +70,7 @@ except Exception as e:
     sf = None
     print(f"❌ Failed to connect to Salesforce: {e}")
 
-# ---------- Code Analyzer (with Salesforce create) ----------
+# ---------- Code Analyzer ----------
 def analyze_code(code):
     if not code.strip():
         return "No code provided.", "", ""
@@ -103,21 +104,56 @@ def analyze_code(code):
 
     return issue_type, suggestion, severity
 
-# ---------- Metadata Validator ----------
-def validate_metadata(metadata):
+# ---------- Metadata Validator (Updated with dynamic XML parsing) ----------
+def validate_metadata(metadata, admin_id=None):
     if not metadata.strip():
         return "No metadata provided.", "", ""
+
     mtype = "Field"
-    issue = "Unused field detected"
-    recommendation = "Remove it to improve performance or document its purpose."
+    issue = "Unknown"
+    recommendation = "No recommendation found."
+
+    try:
+        root = ET.fromstring(metadata)
+        # Detect missing <description> tag
+        description_found = any(elem.tag.endswith('description') for elem in root)
+
+        if not description_found:
+            issue = "Missing description"
+            recommendation = "Add a meaningful <description> to improve maintainability and clarity."
+        else:
+            issue = "Unused field detected"
+            recommendation = "Remove it to improve performance or document its purpose."
+
+    except Exception as e:
+        issue = "Invalid XML"
+        recommendation = f"Could not parse metadata XML. Error: {str(e)}"
+
     log_data = {
         "Name": f"MetadataLog_{mtype}",
-        "MetadataType": mtype,
-        "IssueDescription": issue,
-        "Recommendation": recommendation,
-        "Status": "Open"
+        "MetadataType__c": mtype,
+        "IssueDescription__c": issue,
+        "Recommendation__c": recommendation,
+        "Status__c": "Open"
     }
+
+    if admin_id:
+        log_data["Admin__c"] = admin_id
+
     log_to_console(log_data, "Metadata Validation")
+
+    if sf:
+        try:
+            result = sf.MetadataAuditLog__c.create(log_data)
+            if result.get("success"):
+                log_to_console({"Salesforce MetadataAuditLog Record ID": result["id"]}, "Salesforce Create")
+            else:
+                log_to_console(result, "Salesforce Metadata Error")
+        except Exception as e:
+            log_to_console({"Salesforce Exception": str(e)}, "Salesforce Error")
+    else:
+        log_to_console("Salesforce not connected.", "Salesforce Error")
+
     return mtype, issue, recommendation
 
 # ---------- Salesforce Chatbot ----------