Fix bug

webui/app.py

@@ -206,6 +206,7 @@ async def api_run(
     noise_type: str = Form("none"),
     noise_strength: int = Form(0),
     upload: UploadFile = File(...),
+    hdc_bits: int = Form(32),
 ):
     # validate + pick decoder
     if score_function not in SCORE_FUNCS:
@@ -252,6 +253,10 @@ async def api_run(
             hdv_dim=int(hdv_dim),
             taskclip_ckpt=taskclip_ckpt,
             viz_mode=viz_mode,
+            hw_noise_dist=hw_noise_dist,
+            hw_noise_width=int(hw_noise_width),
+            hw_noise_strength=int(hw_noise_strength),
+            hdc_bits=hdc_bits
         )
     except Exception as e:
         tb = traceback.format_exc()

webui/static/main.js

@@ -46,16 +46,17 @@
   const noiseValLinear = $("noiseValLinear");
   const noiseValAdv = $("noiseValAdv");
 
-  // HW noise elements (UI only; backend currently doesn't accept them unless you add to api_run)
+  // HW noise elements (UI labels only unless backend supports)
   const hwNoiseWidth = $("hwNoiseWidth");
   const hwNoiseStrength = $("hwNoiseStrength");
   const hwNoiseWidthVal = $("hwNoiseWidthVal");
   const hwNoiseStrengthVal = $("hwNoiseStrengthVal");
 
   function setStatus(kind, text, logLine) {
+    // kind: idle | run | ok | bad
     if (statusDot) statusDot.className = `dot ${kind}`;
     if (statusText) statusText.textContent = text;
-    if (statusLog && logLine) statusLog.textContent = logLine;
+    if (statusLog && logLine != null) statusLog.textContent = logLine;
   }
 
   function setRunning(isRunning) {
@@ -87,7 +88,7 @@
     fileInput.files = dt.files;
   }
 
-  // Tabs
+  // ---------------- Tabs ----------------
   function initTabs() {
     const tabBtns = qsa(".tabBtn");
     const tabPanels = qsa(".tabPanel");
@@ -105,7 +106,29 @@
     });
   }
 
-  // Noise panel switching
+  // ------------- HDC bits toggle -------------
+  function initHdcBitsToggle() {
+    // score function select has NAME but no ID in your HTML
+    const scoreSel = document.querySelector('select[name="score_function"]');
+    const bitsField = $("hdcBitsField");
+    const bitsSel = $("hdcBits");
+
+    if (!scoreSel || !bitsField || !bitsSel) {
+      console.warn("HDC bits toggle: missing DOM elements");
+      return;
+    }
+
+    const update = () => {
+      const isHDC = scoreSel.value === "HDC";
+      bitsField.style.display = isHDC ? "" : "none";
+      bitsSel.disabled = !isHDC;
+    };
+
+    scoreSel.addEventListener("change", update);
+    update();
+  }
+
+  // ------------- Noise panel switching -------------
   function noiseFamily(val) {
     const t = String(val || "none").toLowerCase();
     if (t === "none" || t === "default" || t === "off") return "none";
@@ -145,34 +168,50 @@
 
   function initNoise() {
     if (!noiseType) return;
+
     noiseType.addEventListener("change", showNoisePanel);
 
-    if (noiseGaussian) noiseGaussian.addEventListener("input", () => {
-      if (noiseValGaussian) noiseValGaussian.textContent = noiseGaussian.value;
-      updateNoiseHidden();
-    });
-    if (noiseLinear) noiseLinear.addEventListener("input", () => {
-      if (noiseValLinear) noiseValLinear.textContent = noiseLinear.value;
-      updateNoiseHidden();
-    });
-    if (noiseAdv) noiseAdv.addEventListener("input", () => {
-      if (noiseValAdv) noiseValAdv.textContent = noiseAdv.value;
-      updateNoiseHidden();
-    });
+    if (noiseGaussian) {
+      noiseGaussian.addEventListener("input", () => {
+        if (noiseValGaussian) noiseValGaussian.textContent = noiseGaussian.value;
+        if (noiseFamily(noiseType.value) === "gaussian") updateNoiseHidden();
+      });
+    }
+
+    if (noiseLinear) {
+      noiseLinear.addEventListener("input", () => {
+        if (noiseValLinear) noiseValLinear.textContent = noiseLinear.value;
+        if (noiseFamily(noiseType.value) === "linear") updateNoiseHidden();
+      });
+    }
+
+    if (noiseAdv) {
+      noiseAdv.addEventListener("input", () => {
+        if (noiseValAdv) noiseValAdv.textContent = noiseAdv.value;
+        if (noiseFamily(noiseType.value) === "adv") updateNoiseHidden();
+      });
+    }
 
     showNoisePanel();
   }
 
+  // ------------- HW noise label updates -------------
   function initHwNoiseLabels() {
     if (hwNoiseWidth && hwNoiseWidthVal) {
-      hwNoiseWidth.addEventListener("input", () => (hwNoiseWidthVal.textContent = hwNoiseWidth.value));
+      hwNoiseWidthVal.textContent = hwNoiseWidth.value;
+      hwNoiseWidth.addEventListener("input", () => {
+        hwNoiseWidthVal.textContent = hwNoiseWidth.value;
+      });
     }
     if (hwNoiseStrength && hwNoiseStrengthVal) {
-      hwNoiseStrength.addEventListener("input", () => (hwNoiseStrengthVal.textContent = hwNoiseStrength.value));
+      hwNoiseStrengthVal.textContent = hwNoiseStrength.value;
+      hwNoiseStrength.addEventListener("input", () => {
+        hwNoiseStrengthVal.textContent = hwNoiseStrength.value;
+      });
     }
   }
 
-  // Upload handlers
+  // ------------- Upload / Dropzone -------------
   function initUpload() {
     if (!fileInput || !dropzone) return;
 
@@ -193,7 +232,10 @@
       e.preventDefault();
       dropzone.classList.add("drag");
     });
-    dropzone.addEventListener("dragleave", () => dropzone.classList.remove("drag"));
+
+    dropzone.addEventListener("dragleave", () => {
+      dropzone.classList.remove("drag");
+    });
 
     dropzone.addEventListener("drop", (e) => {
       e.preventDefault();
@@ -205,25 +247,34 @@
     });
   }
 
-  // Reset
+  // ------------- Reset -------------
   function initReset() {
     if (!resetBtn || !form) return;
     resetBtn.addEventListener("click", () => {
       form.reset();
       if (fileInput) fileInput.value = "";
       setPreview(null);
+
       if (jobPill) jobPill.textContent = "job: —";
       if (imgInput) imgInput.removeAttribute("src");
       if (imgYolo) imgYolo.removeAttribute("src");
       if (imgSelected) imgSelected.removeAttribute("src");
       if (meta) meta.textContent = "";
+
+      // reset labels
+      if (noiseValGaussian && noiseGaussian) noiseValGaussian.textContent = noiseGaussian.value;
+      if (noiseValLinear && noiseLinear) noiseValLinear.textContent = noiseLinear.value;
+      if (noiseValAdv && noiseAdv) noiseValAdv.textContent = noiseAdv.value;
+
+      initHdcBitsToggle();
+      showNoisePanel();
+
       setStatus("idle", "Idle", "Waiting for input…");
       setRunning(false);
-      showNoisePanel();
     });
   }
 
-  // Copy metadata
+  // ------------- Copy meta -------------
   function initCopyMeta() {
     if (!copyMetaBtn || !meta) return;
     copyMetaBtn.addEventListener("click", async () => {
@@ -234,7 +285,7 @@
     });
   }
 
-  // Submit
+  // ------------- Submit -------------
   function initSubmit() {
     if (!form) return;
 
@@ -247,14 +298,12 @@
         return;
       }
 
-      updateNoiseHidden(); // ensure hidden noise_strength matches slider
+      updateNoiseHidden();
       setRunning(true);
       setStatus("run", "Running", "Submitting request…");
 
       try {
         const fd = new FormData(form);
-
-        // NOTE: backend currently ignores HW noise + hdc_bits unless you add them to api_run.
         const resp = await fetch("/api/run", { method: "POST", body: fd });
         const data = await resp.json();
 
@@ -295,19 +344,21 @@
 
   // Boot
   document.addEventListener("DOMContentLoaded", () => {
-    // Basic sanity: show you in logs if ids are missing
     if (!form || !fileInput || !dropzone) {
-      console.error("DOM ids mismatch: runForm/fileInput/dropzone not found.");
+      console.error("Missing DOM elements: check ids in HTML.");
       if (statusLog) statusLog.textContent = "JS init failed: missing DOM elements (check ids).";
       return;
     }
+
     initTabs();
+    initHdcBitsToggle();
     initNoise();
     initHwNoiseLabels();
     initUpload();
     initReset();
     initCopyMeta();
     initSubmit();
+
     setStatus("idle", "Idle", "Waiting for input…");
   });
 })();