Spaces:
Running
Running
File size: 7,210 Bytes
b152b60 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 | """Tests for session event logging (tool calls, UI events persistence)."""
import json
import asyncio
from unittest.mock import patch, MagicMock, AsyncMock
import pytest
import reachy_mini_conversation_app.stream_api as stream_api
@pytest.fixture
def mock_conversation_logger():
"""Provide a mock ConversationLogger and wire it into stream_api."""
mock_logger = MagicMock()
mock_logger.log_turn = MagicMock(return_value=1)
mock_logger.get_session = MagicMock(return_value=[])
original_logger = stream_api._conversation_logger
original_session_id = stream_api._current_session_id
stream_api._conversation_logger = mock_logger
stream_api._current_session_id = "test-session-abc"
yield mock_logger
stream_api._conversation_logger = original_logger
stream_api._current_session_id = original_session_id
@pytest.fixture
def mock_broadcast():
"""Mock the broadcast to avoid needing real WebSocket connections."""
with patch.object(stream_api.manager, "broadcast", new_callable=AsyncMock) as m:
yield m
# ─────────────────────────────────────────────────────────────
# Tool event persistence
# ─────────────────────────────────────────────────────────────
@pytest.mark.asyncio
async def test_emit_tool_start_persists_to_conversation_log(
mock_conversation_logger, mock_broadcast
):
"""emit_tool_start should log a 'tool' turn to the conversation log."""
await stream_api.emit_tool_start(
name="log_entry",
args={"type": "headache", "intensity": 7},
event_id="evt-001",
)
mock_conversation_logger.log_turn.assert_called_once()
call_kwargs = mock_conversation_logger.log_turn.call_args
assert call_kwargs[1]["role"] == "tool"
assert "log_entry" in call_kwargs[1]["content"]
assert "headache" in call_kwargs[1]["content"]
assert call_kwargs[1]["session_id"] == "test-session-abc"
@pytest.mark.asyncio
async def test_emit_tool_result_persists_to_conversation_log(
mock_conversation_logger, mock_broadcast
):
"""emit_tool_result should log a 'tool_result' turn."""
await stream_api.emit_tool_result(
name="log_entry",
result={"status": "ok", "entry_id": 42},
event_id="evt-001",
status="completed",
)
mock_conversation_logger.log_turn.assert_called_once()
call_kwargs = mock_conversation_logger.log_turn.call_args
assert call_kwargs[1]["role"] == "tool_result"
assert "log_entry" in call_kwargs[1]["content"]
assert call_kwargs[1]["metadata"]["status"] == "completed"
@pytest.mark.asyncio
async def test_emit_tool_result_truncates_large_results(
mock_conversation_logger, mock_broadcast
):
"""Large tool results should be truncated to avoid DB bloat."""
big_result = {"data": "x" * 2000}
await stream_api.emit_tool_result(
name="big_tool",
result=big_result,
event_id="evt-002",
)
call_kwargs = mock_conversation_logger.log_turn.call_args
content = call_kwargs[1]["content"]
assert len(content) < 1200 # truncated from 2000+
assert "truncated" in content
# ─────────────────────────────────────────────────────────────
# UI event persistence
# ─────────────────────────────────────────────────────────────
@pytest.mark.asyncio
async def test_emit_ui_component_persists_to_conversation_log(
mock_conversation_logger, mock_broadcast
):
"""emit_ui_component should log a 'ui' turn."""
await stream_api.emit_ui_component(
component_name="HeadacheLog",
props={"intensity": 7, "location": "frontal"},
message_id="msg-001",
)
mock_conversation_logger.log_turn.assert_called_once()
call_kwargs = mock_conversation_logger.log_turn.call_args
assert call_kwargs[1]["role"] == "ui"
assert "HeadacheLog" in call_kwargs[1]["content"]
assert "frontal" in call_kwargs[1]["content"]
@pytest.mark.asyncio
async def test_emit_ui_component_truncates_large_props(
mock_conversation_logger, mock_broadcast
):
"""Large UI props should be truncated."""
big_props = {"data": "y" * 1000}
await stream_api.emit_ui_component(
component_name="BigComponent",
props=big_props,
)
call_kwargs = mock_conversation_logger.log_turn.call_args
content = call_kwargs[1]["content"]
assert len(content) < 700 # truncated from 1000+
# ─────────────────────────────────────────────────────────────
# No-op when logger is not initialized
# ─────────────────────────────────────────────────────────────
@pytest.mark.asyncio
async def test_emit_tool_start_no_crash_without_logger(mock_broadcast):
"""Should not crash when conversation logger is not initialized."""
original = stream_api._conversation_logger
stream_api._conversation_logger = None
try:
await stream_api.emit_tool_start(
name="test_tool",
args={"a": 1},
event_id="evt-999",
)
# Should complete without error
finally:
stream_api._conversation_logger = original
# ─────────────────────────────────────────────────────────────
# Session-log endpoint
# ─────────────────────────────────────────────────────────────
@pytest.mark.asyncio
async def test_session_log_endpoint_returns_turns(mock_conversation_logger):
"""GET /session-log should return turns from ConversationLogger."""
mock_conversation_logger.get_session.return_value = [
{"turn_index": 0, "role": "user", "content": "Hello"},
{"turn_index": 1, "role": "tool", "content": "log_entry({})"},
{"turn_index": 2, "role": "ui", "content": "HeadacheLog: {}"},
]
result = await stream_api.session_log(session_id="test-session-abc")
assert result["session_id"] == "test-session-abc"
assert result["turn_count"] == 3
assert result["turns"][1]["role"] == "tool"
@pytest.mark.asyncio
async def test_session_log_endpoint_no_logger():
"""Should return error when logger not initialized."""
original = stream_api._conversation_logger
stream_api._conversation_logger = None
try:
result = await stream_api.session_log()
assert "error" in result
finally:
stream_api._conversation_logger = original
|