Refactor/unittests (#33)

* reorganize /tests directory and convert to unittest.TestCase

* cleaned up old test files and updated GHA command.

* moved test_auto_colors.py into the tests/unit directory.

.github/workflows/unit_tests.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Run unit tests
         working-directory: multi_llm_chatbot_backend
         run: |
-          pytest app/tests/test_persona_config.py app/tests/test_auto_colors.py app/tests/test_lucide_icons.py --junitxml=test-results/results.xml
+          pytest app/tests/unit/ --junitxml=test-results/results.xml
 
       - name: Upload test results
         if: always()

multi_llm_chatbot_backend/app/tests/conftest.py

@@ -1,10 +0,0 @@
-import pytest
-import app.config as config_module
-
-@pytest.fixture(autouse=True)
-def reset_config_singleton():
-    """Clear the cached settings so each test gets a fresh load."""
-    config_module._settings = None
-    yield
-    config_module._settings = None
-

multi_llm_chatbot_backend/app/tests/integration/__init__.py

@@ -0,0 +1 @@
+

multi_llm_chatbot_backend/app/tests/test_lucide_icons.py

@@ -1,74 +0,0 @@
-import pytest
-from pydantic import ValidationError
-from app.utils.lucide_icons import get_valid_icon_names
-from app.config import FeatureConfig, ExampleCategory, PersonaItemConfig
-
-
-@pytest.fixture(autouse=True)
-def _clear_icon_cache():
-    get_valid_icon_names.cache_clear()
-    yield
-    get_valid_icon_names.cache_clear()
-
-
-# ---------------------------------------------------------------------------
-# Icon registry tests
-# ---------------------------------------------------------------------------
-
-
-def test_returns_known_icons():
-    icons = get_valid_icon_names()
-    assert len(icons) > 1500
-    assert "HelpCircle" in icons
-    assert "BookOpen" in icons
-
-
-def test_rejects_invalid_icon():
-    icons = get_valid_icon_names()
-    assert "NotARealIcon" not in icons
-
-
-# ---------------------------------------------------------------------------
-# Icon validation tests
-# ---------------------------------------------------------------------------
-
-
-def test_feature_config_accepts_valid_icon():
-    feature = FeatureConfig(title="Test", description="desc", icon="BookOpen")
-    assert feature.icon == "BookOpen"
-
-
-def test_example_category_accepts_valid_icon():
-    example = ExampleCategory(title="Test", icon="Brain")
-    assert example.icon == "Brain"
-
-
-def test_persona_item_accepts_valid_icon():
-    persona = PersonaItemConfig(id="test", name="Test", icon="Heart")
-    assert persona.icon == "Heart"
-
-
-def test_default_icons_are_valid():
-    feature = FeatureConfig(title="Test", description="desc")
-    assert feature.icon == "HelpCircle"
-
-    example = ExampleCategory(title="Test")
-    assert example.icon == "BookOpen"
-
-    persona = PersonaItemConfig(id="test", name="Test")
-    assert persona.icon == "HelpCircle"
-
-
-def test_feature_config_rejects_invalid_icon():
-    with pytest.raises(ValidationError, match="Unknown icon"):
-        FeatureConfig(title="Test", description="desc", icon="NotARealIcon")
-
-
-def test_example_category_rejects_invalid_icon():
-    with pytest.raises(ValidationError, match="Unknown icon"):
-        ExampleCategory(title="Test", icon="TotallyFake")
-
-
-def test_persona_item_rejects_invalid_icon():
-    with pytest.raises(ValidationError, match="Unknown icon"):
-        PersonaItemConfig(id="test", name="Test", icon="Nope")

multi_llm_chatbot_backend/app/tests/test_persona_config.py

@@ -1,143 +0,0 @@
-import pytest
-import os, yaml
-import app.config
-from app.config import load_settings, load_personas_from_dir, PersonasConfig
-
-
-@pytest.fixture(autouse=True)
-def _reset_settings_singleton():
-    app.config._settings = None
-    yield
-    app.config._settings = None
-
-
-def _write_config(tmp_path, data: dict) -> str:
-    path = os.path.join(str(tmp_path), "config.yaml")
-    with open(path, "w") as f:
-        yaml.dump(data, f)
-    return path
-
-
-def _write_persona(directory, filename, data: dict):
-    path = os.path.join(str(directory), filename)
-    with open(path, "w") as f:
-        yaml.dump(data, f)
-
-
-# ---------------------------------------------------------------------------
-# load_settings tests
-# ---------------------------------------------------------------------------
-
-def test_loads_personas_from_main_config(tmp_path):
-    cfg_path = _write_config(tmp_path, {
-        "personas": {
-            "base_prompt": "Be helpful.",
-            "items": [
-                {"id": "test1", "name": "Test One", "persona_prompt": "You are test1."},
-            ]
-        }
-    })
-    settings = load_settings(cfg_path)
-    assert len(settings.personas.items) == 1
-    assert settings.personas.items[0].id == "test1"
-
-
-def test_load_settings_uses_personas_dir(tmp_path):
-    """Test that load_settings loads personas from a directory when personas_dir is set."""
-    # Create a personas subdirectory inside the temp dir
-    personas_dir = os.path.join(str(tmp_path), "personas")
-    os.makedirs(personas_dir)
-
-    # Write two persona files into it
-    _write_persona(personas_dir, "one.yaml", {"id": "one", "name": "One"})
-    _write_persona(personas_dir, "two.yaml", {"id": "two", "name": "Two"})
-
-    # Write a main config that points to the directory
-    cfg_path = _write_config(tmp_path, {
-        "personas": {
-            "base_prompt": "Be helpful.",
-            "personas_dir": "personas",
-        }
-    })
-
-    settings = load_settings(cfg_path)
-    assert len(settings.personas.items) == 2
-    ids = {p.id for p in settings.personas.items}
-    assert ids == {"one", "two"}
-
-
-def test_bad_persona_does_not_crash_everything(tmp_path):
-    """Validates that a bad persona in the inline items list causes a
-    validation error — the directory loader solves this for file-based configs."""
-    cfg_path = _write_config(tmp_path, {
-        "personas": {
-            "items": [
-                {"id": "good", "name": "Good"},
-                {"not_an_id": "bad"},  # missing required 'id' and 'name'
-            ]
-        }
-    })
-    with pytest.raises(Exception):
-        load_settings(cfg_path)
-
-
-# ---------------------------------------------------------------------------
-# load_personas_from_dir tests
-# ---------------------------------------------------------------------------
-
-def test_loads_personas_from_directory(tmp_path):
-    _write_persona(tmp_path, "one.yaml", {"id": "one", "name": "One"})
-    _write_persona(tmp_path, "two.yaml", {"id": "two", "name": "Two"})
-    result = load_personas_from_dir(str(tmp_path))
-    assert len(result) == 2
-    ids = {p.id for p in result}
-    assert ids == {"one", "two"}
-
-
-def test_personas_config_validator_loads_from_dir(tmp_path):
-    """Test that PersonasConfig's model_validator loads personas automatically."""
-    _write_persona(tmp_path, "one.yaml", {"id": "one", "name": "One"})
-    _write_persona(tmp_path, "two.yaml", {"id": "two", "name": "Two"})
-
-    config = PersonasConfig(personas_dir=str(tmp_path))
-    assert len(config.items) == 2
-    ids = {p.id for p in config.items}
-    assert ids == {"one", "two"}
-
-
-def test_skips_invalid_persona_files(tmp_path):
-    _write_persona(tmp_path, "good.yaml", {"id": "good", "name": "Good"})
-    _write_persona(tmp_path, "bad.yaml", {"not_id": "bad"})
-    result = load_personas_from_dir(str(tmp_path))
-    assert len(result) == 1
-    assert result[0].id == "good"
-
-
-def test_disabled_persona_excluded(tmp_path):
-    _write_persona(tmp_path, "on.yaml", {"id": "on", "name": "On"})
-    _write_persona(tmp_path, "off.yaml", {"id": "off", "name": "Off", "enabled": False})
-    result = load_personas_from_dir(str(tmp_path))
-    assert len(result) == 1
-    assert result[0].id == "on"
-
-
-def test_duplicate_id_rejected(tmp_path):
-    _write_persona(tmp_path, "a.yaml", {"id": "same", "name": "First"})
-    _write_persona(tmp_path, "b.yaml", {"id": "same", "name": "Second"})
-    result = load_personas_from_dir(str(tmp_path))
-    assert len(result) == 1
-    assert result[0].name == "First"
-
-
-def test_duplicate_name_rejected(tmp_path):
-    _write_persona(tmp_path, "a.yaml", {"id": "id_a", "name": "Same Name"})
-    _write_persona(tmp_path, "b.yaml", {"id": "id_b", "name": "Same Name"})
-    result = load_personas_from_dir(str(tmp_path))
-    assert len(result) == 1
-    assert result[0].id == "id_a"
-
-
-def test_missing_directory_returns_empty(tmp_path):
-    result = load_personas_from_dir(os.path.join(str(tmp_path), "nonexistent"))
-    assert result == []
-

multi_llm_chatbot_backend/app/tests/unit/__init__.py

@@ -0,0 +1 @@
+

multi_llm_chatbot_backend/app/tests/unit/test_lucide_icons.py

@@ -0,0 +1,66 @@
+import unittest
+from pydantic import ValidationError
+from app.utils.lucide_icons import get_valid_icon_names
+from app.config import FeatureConfig, ExampleCategory, PersonaItemConfig
+
+
+class TestIconRegistry(unittest.TestCase):
+
+    def setUp(self):
+        get_valid_icon_names.cache_clear()
+
+    def tearDown(self):
+        get_valid_icon_names.cache_clear()
+
+    def test_returns_known_icons(self):
+        icons = get_valid_icon_names()
+        self.assertGreater(len(icons), 1500)
+        self.assertIn("HelpCircle", icons)
+        self.assertIn("BookOpen", icons)
+
+    def test_rejects_invalid_icon(self):
+        icons = get_valid_icon_names()
+        self.assertNotIn("NotARealIcon", icons)
+
+
+class TestIconValidation(unittest.TestCase):
+
+    def setUp(self):
+        get_valid_icon_names.cache_clear()
+
+    def tearDown(self):
+        get_valid_icon_names.cache_clear()
+
+    def test_feature_config_accepts_valid_icon(self):
+        feature = FeatureConfig(title="Test", description="desc", icon="BookOpen")
+        self.assertEqual(feature.icon, "BookOpen")
+
+    def test_example_category_accepts_valid_icon(self):
+        example = ExampleCategory(title="Test", icon="Brain")
+        self.assertEqual(example.icon, "Brain")
+
+    def test_persona_item_accepts_valid_icon(self):
+        persona = PersonaItemConfig(id="test", name="Test", icon="Heart")
+        self.assertEqual(persona.icon, "Heart")
+
+    def test_default_icons_are_valid(self):
+        feature = FeatureConfig(title="Test", description="desc")
+        self.assertEqual(feature.icon, "HelpCircle")
+
+        example = ExampleCategory(title="Test")
+        self.assertEqual(example.icon, "BookOpen")
+
+        persona = PersonaItemConfig(id="test", name="Test")
+        self.assertEqual(persona.icon, "HelpCircle")
+
+    def test_feature_config_rejects_invalid_icon(self):
+        with self.assertRaisesRegex(ValidationError, "Unknown icon"):
+            FeatureConfig(title="Test", description="desc", icon="NotARealIcon")
+
+    def test_example_category_rejects_invalid_icon(self):
+        with self.assertRaisesRegex(ValidationError, "Unknown icon"):
+            ExampleCategory(title="Test", icon="TotallyFake")
+
+    def test_persona_item_rejects_invalid_icon(self):
+        with self.assertRaisesRegex(ValidationError, "Unknown icon"):
+            PersonaItemConfig(id="test", name="Test", icon="Nope")

multi_llm_chatbot_backend/app/tests/unit/test_persona_config.py

@@ -0,0 +1,140 @@
+import unittest
+import os
+import tempfile
+import yaml
+import app.config
+from app.config import load_settings, load_personas_from_dir, PersonasConfig
+
+
+def _write_config(tmp_path, data: dict) -> str:
+    path = os.path.join(tmp_path, "config.yaml")
+    with open(path, "w") as f:
+        yaml.dump(data, f)
+    return path
+
+
+def _write_persona(directory, filename, data: dict):
+    path = os.path.join(directory, filename)
+    with open(path, "w") as f:
+        yaml.dump(data, f)
+
+
+class TestLoadSettings(unittest.TestCase):
+
+    def setUp(self):
+        app.config._settings = None
+        self._tmp = tempfile.TemporaryDirectory()
+        self.tmp_path = self._tmp.name
+
+    def tearDown(self):
+        app.config._settings = None
+        self._tmp.cleanup()
+
+    def test_loads_personas_from_main_config(self):
+        cfg_path = _write_config(self.tmp_path, {
+            "personas": {
+                "base_prompt": "Be helpful.",
+                "items": [
+                    {"id": "test1", "name": "Test One", "persona_prompt": "You are test1."},
+                ]
+            }
+        })
+        settings = load_settings(cfg_path)
+        self.assertEqual(len(settings.personas.items), 1)
+        self.assertEqual(settings.personas.items[0].id, "test1")
+
+    def test_uses_personas_dir(self):
+        """Test that load_settings loads personas from a directory when personas_dir is set."""
+        personas_dir = os.path.join(self.tmp_path, "personas")
+        os.makedirs(personas_dir)
+
+        _write_persona(personas_dir, "one.yaml", {"id": "one", "name": "One"})
+        _write_persona(personas_dir, "two.yaml", {"id": "two", "name": "Two"})
+
+        cfg_path = _write_config(self.tmp_path, {
+            "personas": {
+                "base_prompt": "Be helpful.",
+                "personas_dir": "personas",
+            }
+        })
+
+        settings = load_settings(cfg_path)
+        self.assertEqual(len(settings.personas.items), 2)
+        ids = {p.id for p in settings.personas.items}
+        self.assertEqual(ids, {"one", "two"})
+
+    def test_bad_persona_does_not_crash_everything(self):
+        """Validates that a bad persona in the inline items list causes a
+        validation error -- the directory loader solves this for file-based configs."""
+        cfg_path = _write_config(self.tmp_path, {
+            "personas": {
+                "items": [
+                    {"id": "good", "name": "Good"},
+                    {"not_an_id": "bad"},
+                ]
+            }
+        })
+        with self.assertRaises(Exception):
+            load_settings(cfg_path)
+
+
+class TestLoadPersonasFromDir(unittest.TestCase):
+
+    def setUp(self):
+        app.config._settings = None
+        self._tmp = tempfile.TemporaryDirectory()
+        self.tmp_path = self._tmp.name
+
+    def tearDown(self):
+        app.config._settings = None
+        self._tmp.cleanup()
+
+    def test_loads_personas_from_directory(self):
+        _write_persona(self.tmp_path, "one.yaml", {"id": "one", "name": "One"})
+        _write_persona(self.tmp_path, "two.yaml", {"id": "two", "name": "Two"})
+        result = load_personas_from_dir(self.tmp_path)
+        self.assertEqual(len(result), 2)
+        ids = {p.id for p in result}
+        self.assertEqual(ids, {"one", "two"})
+
+    def test_personas_config_validator_loads_from_dir(self):
+        """Test that PersonasConfig's model_validator loads personas automatically."""
+        _write_persona(self.tmp_path, "one.yaml", {"id": "one", "name": "One"})
+        _write_persona(self.tmp_path, "two.yaml", {"id": "two", "name": "Two"})
+
+        config = PersonasConfig(personas_dir=self.tmp_path)
+        self.assertEqual(len(config.items), 2)
+        ids = {p.id for p in config.items}
+        self.assertEqual(ids, {"one", "two"})
+
+    def test_skips_invalid_persona_files(self):
+        _write_persona(self.tmp_path, "good.yaml", {"id": "good", "name": "Good"})
+        _write_persona(self.tmp_path, "bad.yaml", {"not_id": "bad"})
+        result = load_personas_from_dir(self.tmp_path)
+        self.assertEqual(len(result), 1)
+        self.assertEqual(result[0].id, "good")
+
+    def test_disabled_persona_excluded(self):
+        _write_persona(self.tmp_path, "on.yaml", {"id": "on", "name": "On"})
+        _write_persona(self.tmp_path, "off.yaml", {"id": "off", "name": "Off", "enabled": False})
+        result = load_personas_from_dir(self.tmp_path)
+        self.assertEqual(len(result), 1)
+        self.assertEqual(result[0].id, "on")
+
+    def test_duplicate_id_rejected(self):
+        _write_persona(self.tmp_path, "a.yaml", {"id": "same", "name": "First"})
+        _write_persona(self.tmp_path, "b.yaml", {"id": "same", "name": "Second"})
+        result = load_personas_from_dir(self.tmp_path)
+        self.assertEqual(len(result), 1)
+        self.assertEqual(result[0].name, "First")
+
+    def test_duplicate_name_rejected(self):
+        _write_persona(self.tmp_path, "a.yaml", {"id": "id_a", "name": "Same Name"})
+        _write_persona(self.tmp_path, "b.yaml", {"id": "id_b", "name": "Same Name"})
+        result = load_personas_from_dir(self.tmp_path)
+        self.assertEqual(len(result), 1)
+        self.assertEqual(result[0].id, "id_a")
+
+    def test_missing_directory_returns_empty(self):
+        result = load_personas_from_dir(os.path.join(self.tmp_path, "nonexistent"))
+        self.assertEqual(result, [])