Harden demo feedback pathing and runtime diagnostics

.gitignore

@@ -0,0 +1,17 @@
+__pycache__/
+*.py[cod]
+
+.env
+
+# Runtime output folders
+runtime_data/
+demo_guests_data/
+tmp_feedback_test_demo/
+
+# Repo data runtime artifacts
+data/demo_guests/
+data/charts/
+data/sessions/
+data/yfinance_tz_cache/
+data/*_report.json
+data/feedback_logs.json

Dockerfile

@@ -4,7 +4,8 @@ FROM python:3.10-slim
 RUN useradd -m -u 1000 user
 USER user
 ENV HOME=/home/user \
-    PATH=/home/user/.local/bin:$PATH
+    PATH=/home/user/.local/bin:$PATH \
+    DEMO_MODE=true
 
 WORKDIR $HOME/app
 

app.py

@@ -30,6 +30,16 @@ app = Flask(__name__)
 CORS(app) # Enable CORS for all routes
 DATA_DIR.mkdir(parents=True, exist_ok=True)
 YF_CACHE_DIR.mkdir(parents=True, exist_ok=True)
+
+
+def _feedback_log_path() -> Path:
+    """Return the canonical feedback log path for the current runtime mode."""
+    if DEMO_MODE:
+        demo_dir = PROJECT_ROOT / "data" / "demo_guests"
+        demo_dir.mkdir(parents=True, exist_ok=True)
+        return demo_dir / "feedback_logs.json"
+    DATA_DIR.mkdir(parents=True, exist_ok=True)
+    return DATA_DIR / "feedback_logs.json"
 try:
     cache_mod = getattr(yf, "cache", None)
     cache_setter = getattr(cache_mod, "set_cache_location", None)
@@ -274,9 +284,7 @@ def submit_feedback():
 
     feedback_item = dict(payload)
     feedback_item["timestamp"] = datetime.now(timezone.utc).isoformat()
-    log_path = DATA_DIR / "feedback_logs.json"
-    if DEMO_MODE:
-        Path("data/demo_guests").mkdir(parents=True, exist_ok=True)
+    log_path = _feedback_log_path()
     log_path.parent.mkdir(parents=True, exist_ok=True)
     try:
         with open(log_path, "r", encoding="utf-8") as f:
@@ -303,6 +311,37 @@ def submit_feedback():
         "status": "success",
         "message": "Feedback logged",
         "saved_to": saved_to,
+        "demo_mode": DEMO_MODE,
+    })
+
+
+@app.route('/api/feedback/status', methods=['GET'])
+def feedback_status():
+    """Expose current feedback storage wiring for runtime debugging."""
+    log_path = _feedback_log_path()
+    exists = log_path.exists()
+    count = 0
+    last_timestamp = None
+    if exists:
+        try:
+            with open(log_path, "r", encoding="utf-8") as f:
+                loaded = json.load(f)
+            if isinstance(loaded, list):
+                count = len(loaded)
+                if loaded and isinstance(loaded[-1], dict):
+                    last_timestamp = loaded[-1].get("timestamp")
+        except (OSError, json.JSONDecodeError):
+            pass
+
+    return jsonify({
+        "demo_mode": DEMO_MODE,
+        "cwd": os.getcwd(),
+        "project_root": str(PROJECT_ROOT),
+        "data_dir": str(DATA_DIR),
+        "feedback_log_path": str(log_path),
+        "feedback_log_exists": exists,
+        "feedback_log_entries": count,
+        "last_timestamp": last_timestamp,
     })
 
 @app.route('/api/session-summary/latest')

static/app.js

@@ -412,11 +412,12 @@ document.addEventListener('DOMContentLoaded', () => {
                     },
                     body: JSON.stringify(payload),
                 });
+                const body = await response.json().catch(() => ({}));
                 if (!response.ok) {
-                    const body = await response.json().catch(() => ({}));
                     throw new Error(body.error || 'Failed to send feedback.');
                 }
-                alert('Feedback sent!');
+                const destination = String(body.saved_to || '').trim();
+                alert(destination ? `Feedback sent! Saved to ${destination}` : 'Feedback sent!');
                 if (feedbackMessageEl) {
                     feedbackMessageEl.value = '';
                 }

storage_paths.py

@@ -12,8 +12,9 @@ def resolve_data_dir(project_root: Path, demo_mode: bool) -> Path:
 
     Priority:
     1) IRIS_DATA_DIR (absolute or project-relative)
-    2) IRIS_USE_REPO_DATA=true -> data/ (or data/demo_guests in demo mode)
-    3) default isolated runtime dir -> runtime_data/ (or demo_guests_data/)
+    2) Demo mode -> data/demo_guests (single canonical feedback/report path)
+    3) IRIS_USE_REPO_DATA=true -> data/
+    4) default isolated runtime dir -> runtime_data/
     """
     explicit_dir = str(os.environ.get("IRIS_DATA_DIR", "")).strip()
     if explicit_dir:
@@ -23,18 +24,17 @@ def resolve_data_dir(project_root: Path, demo_mode: bool) -> Path:
         candidate.mkdir(parents=True, exist_ok=True)
         return candidate
 
-    use_repo_data = _as_bool(os.environ.get("IRIS_USE_REPO_DATA", "false"))
-    if use_repo_data:
-        preferred_rel = Path("data/demo_guests") if demo_mode else Path("data")
+    if demo_mode:
+        preferred_rel = Path("data/demo_guests")
     else:
-        preferred_rel = Path("demo_guests_data") if demo_mode else Path("runtime_data")
+        use_repo_data = _as_bool(os.environ.get("IRIS_USE_REPO_DATA", "false"))
+        preferred_rel = Path("data") if use_repo_data else Path("runtime_data")
 
     preferred = project_root / preferred_rel
     try:
         preferred.mkdir(parents=True, exist_ok=True)
         return preferred
     except OSError:
-        fallback_rel = Path("demo_guests_data") if demo_mode else Path("runtime_data")
-        fallback = project_root / fallback_rel
+        fallback = project_root / Path("runtime_data")
         fallback.mkdir(parents=True, exist_ok=True)
         return fallback

templates/index.html

@@ -166,7 +166,7 @@
     <!-- TradingView Lightweight Charts -->
     <script
         src="https://unpkg.com/lightweight-charts@4.1.1/dist/lightweight-charts.standalone.production.js?v=4"></script>
-    <script src="/static/app.js?v=12"></script>
+    <script src="/static/app.js?v=13"></script>
 </body>
 
 </html>