fix: isolate ALTER TABLE in own transaction to prevent PG InFailedSqlTransaction + auto-save CV editor

backend/database.py

@@ -272,21 +272,24 @@ def _exec_lastid(conn, sql: str, params=()):
 
 # ── Init ─────────────────────────────────────────────────────────────────────
 
+def _safe_alter(conn, sql: str):
+    try:
+        with conn.cursor() as cur:
+            cur.execute(sql)
+        conn.commit()
+    except Exception:
+        conn.rollback()
+
+
 def init_db():
     if _is_pg():
         with get_db() as conn:
             with conn.cursor() as cur:
                 cur.execute(_PG_DDL)
-            try:
-                with conn.cursor() as cur:
-                    cur.execute("ALTER TABLE global_jobs ALTER COLUMN date_found TYPE TIMESTAMP USING date_found::timestamp")
-            except Exception:
-                pass
-            try:
-                with conn.cursor() as cur:
-                    cur.execute("ALTER TABLE user_cv ADD COLUMN raw_text TEXT DEFAULT ''")
-            except Exception:
-                pass
+            conn.commit()
+            _safe_alter(conn, "ALTER TABLE global_jobs ALTER COLUMN date_found TYPE TIMESTAMP USING date_found::timestamp")
+            _safe_alter(conn, "ALTER TABLE user_cv ADD COLUMN IF NOT EXISTS raw_text TEXT DEFAULT ''")
+            _safe_alter(conn, "ALTER TABLE users ADD COLUMN IF NOT EXISTS is_admin INTEGER DEFAULT 0")
             _seed_categories(conn)
             _seed_admin_user(conn)
     else:

backend/main.py

@@ -233,16 +233,19 @@ def make_cv(req: MakeCVRequest, current_user: dict = Depends(get_current_user)):
     except Exception as e:
         raise HTTPException(500, f"Failed to save CV: {str(e)}")
 
-    # Generate preview text + documents
-    preview = generate_cv_preview_text(cv_data)
-
-    name = (cv_data.get("personal_info") or {}).get("name", "")
-    slug = _file_slug(name, req.target_jobs[0] if req.target_jobs else "CV", "", number="00")
-    cv_path = str(GENERATED_DIR / f"{slug}_cv.docx")
-    cv_pdf_path = str(GENERATED_DIR / f"{slug}_cv.pdf")
-    profile = get_cv_profile(str(user_id))
-    generate_cv_docx(cv_data, cv_path, target_type=req.target_type, profile=profile)
-    generate_cv_pdf(cv_data, cv_pdf_path, target_type=req.target_type, profile=profile)
+    try:
+        # Generate preview text + documents
+        preview = generate_cv_preview_text(cv_data)
+
+        name = (cv_data.get("personal_info") or {}).get("name", "")
+        slug = _file_slug(name, req.target_jobs[0] if req.target_jobs else "CV", "", number="00")
+        cv_path = str(GENERATED_DIR / f"{slug}_cv.docx")
+        cv_pdf_path = str(GENERATED_DIR / f"{slug}_cv.pdf")
+        profile = get_cv_profile(str(user_id))
+        generate_cv_docx(cv_data, cv_path, target_type=req.target_type, profile=profile)
+        generate_cv_pdf(cv_data, cv_pdf_path, target_type=req.target_type, profile=profile)
+    except Exception as e:
+        raise HTTPException(500, f"Document generation failed: {type(e).__name__}: {e}")
 
     return {
         "status": "ok",

frontend/cv-editor.html

@@ -89,6 +89,7 @@
           <p class="subtitle">Manage your professional profile</p>
         </div>
         <div class="actions">
+          <span id="autoSaveStatus" style="font-size:12px;color:var(--text-subtle);margin-right:8px"></span>
           <button class="btn btn-primary" onclick="saveCv()" id="saveBtn">Save CV</button>
           <button class="btn btn-secondary" onclick="toggleJsonEditor()">&#9998; JSON Mode</button>
         </div>
@@ -155,19 +156,19 @@
         <div class="cv-form-section">
           <h3>&#128188; Experience</h3>
           <div id="experienceList"></div>
-          <button class="add-entry-btn" onclick="addExperience()">+ Add Experience</button>
+          <button class="add-entry-btn" onclick="addExperience();scheduleAutoSave()">+ Add Experience</button>
         </div>
 
         <div class="cv-form-section">
           <h3>&#127891; Education</h3>
           <div id="educationList"></div>
-          <button class="add-entry-btn" onclick="addEducation()">+ Add Education</button>
+          <button class="add-entry-btn" onclick="addEducation();scheduleAutoSave()">+ Add Education</button>
         </div>
 
         <div class="cv-form-section">
           <h3>&#128187; Projects</h3>
           <div id="projectsList"></div>
-          <button class="add-entry-btn" onclick="addProject()">+ Add Project</button>
+          <button class="add-entry-btn" onclick="addProject();scheduleAutoSave()">+ Add Project</button>
         </div>
 
         <div class="cv-form-section">
@@ -203,6 +204,8 @@ let savedCv = null;
 let expCounter = 0;
 let eduCounter = 0;
 let projCounter = 0;
+let autoSaveTimer = null;
+let isLoadingCv = false;
 
 async function loadCv() {
   try {
@@ -304,6 +307,7 @@ function collectFormData() {
 }
 
 async function saveCv() {
+  clearTimeout(autoSaveTimer);
   const btn = document.getElementById("saveBtn");
   btn.disabled = true;
   btn.innerHTML = '<span class="spinner"></span> Saving...';
@@ -323,6 +327,8 @@ async function saveCv() {
     } else {
       validateCv(data);
     }
+    const status = document.getElementById("autoSaveStatus");
+    if (status) { status.textContent = "\u2713 Saved"; setTimeout(() => { status.textContent = ""; }, 3000); }
     showToast("CV saved successfully");
   } catch (err) {
     if (err instanceof SyntaxError) showToast("Invalid JSON", "error");
@@ -395,7 +401,7 @@ function addExperience(data) {
   const d = data || { title: "", company: "", location: "", start_date: "", end_date: "", current: false, description: "", achievements: [] };
   const html = `
     <div class="entry-card" data-idx="${num}">
-      <button class="remove-entry" onclick="this.closest('.entry-card').remove()">&times;</button>
+      <button class="remove-entry" onclick="this.closest('.entry-card').remove();scheduleAutoSave()">&times;</button>
       <div class="cv-form-row">
         <div class="form-group">
           <label>Job Title</label>
@@ -443,7 +449,7 @@ function addEducation(data) {
   const d = data || { degree: "", institution: "", location: "", start_date: "", end_date: "", gpa: "" };
   const html = `
     <div class="entry-card" data-idx="${num}">
-      <button class="remove-entry" onclick="this.closest('.entry-card').remove()">&times;</button>
+      <button class="remove-entry" onclick="this.closest('.entry-card').remove();scheduleAutoSave()">&times;</button>
       <div class="cv-form-row">
         <div class="form-group">
           <label>Degree</label>
@@ -483,7 +489,7 @@ function addProject(data) {
   const d = data || { name: "", description: "", technologies: [], url: "" };
   const html = `
     <div class="entry-card" data-idx="${num}">
-      <button class="remove-entry" onclick="this.closest('.entry-card').remove()">&times;</button>
+      <button class="remove-entry" onclick="this.closest('.entry-card').remove();scheduleAutoSave()">&times;</button>
       <div class="cv-form-row">
         <div class="form-group">
           <label>Project Name</label>
@@ -637,9 +643,41 @@ async function convertPlainText() {
   }
 }
 
+function scheduleAutoSave() {
+  if (isLoadingCv) return;
+  clearTimeout(autoSaveTimer);
+  const status = document.getElementById("autoSaveStatus");
+  if (status) status.textContent = "Unsaved changes\u2026";
+  autoSaveTimer = setTimeout(async () => {
+    try {
+      let data;
+      const jsonView = document.getElementById("jsonView");
+      if (jsonView.style.display !== "none") {
+        data = JSON.parse(document.getElementById("cvJson").value);
+      } else {
+        data = collectFormData();
+      }
+      await apiFetch("PUT", "/api/cv", data);
+      savedCv = data;
+      if (status) status.textContent = "\u2713 Saved";
+      setTimeout(() => { if (status) status.textContent = ""; }, 3000);
+    } catch (err) {
+      const status = document.getElementById("autoSaveStatus");
+      if (status) status.textContent = "Save failed";
+      console.error("Auto-save failed:", err);
+    }
+  }, 2000);
+}
+
 if (!getToken()) window.location.href = "login.html";
 updateHeader();
-loadCv();
+
+isLoadingCv = true;
+loadCv().then(() => { isLoadingCv = false; });
+
+document.getElementById("formView").addEventListener("input", scheduleAutoSave);
+document.getElementById("formView").addEventListener("change", scheduleAutoSave);
+document.getElementById("cvJson").addEventListener("input", scheduleAutoSave);
 </script>
 </body>
 </html>

frontend/make-cv.html

@@ -330,15 +330,15 @@ I'm interested in full-stack development roles. I also have a Google Cloud certi
             </div>
             <div id="generatedPreview" class="cv-preview"></div>
             <div id="generatedActions" style="display:none;margin-top:var(--space-3)">
-              <div style="display:flex;gap:8px;flex-wrap:wrap">
-                <button class="btn btn-primary" onclick="saveCv()">&#10003; Save &amp; Use for Tailoring</button>
-                <button class="btn btn-secondary" id="downloadDocxBtn" style="display:none" onclick="downloadFile('docx')">&#128196; Download CV (DOCX)</button>
+               <div style="display:flex;gap:8px;flex-wrap:wrap;align-items:center">
+                 <span style="font-size:12px;color:var(--color-success-500);font-weight:500">&#10003; CV auto-saved</span>
+                 <button class="btn btn-secondary" id="downloadDocxBtn" style="display:none" onclick="downloadFile('docx')">&#128196; Download CV (DOCX)</button>
                 <button class="btn btn-secondary" id="downloadPdfBtn" style="display:none" onclick="downloadFile('pdf')">&#128196; Download CV (PDF)</button>
                 <button class="btn btn-secondary" onclick="location.href='cv-editor.html'">&#9998; Edit in CV Editor</button>
-              </div>
-              <p style="font-size:12px;color:var(--text-muted);margin-top:12px">
-                Your CV is automatically saved so you can use it with the <a href="manual-job.html">Manual Entry</a> tool to tailor it to specific jobs.
-              </p>
+               </div>
+               <p style="font-size:12px;color:var(--text-muted);margin-top:12px">
+                 Your CV is saved automatically. Use it with the <a href="manual-job.html">Manual Entry</a> tool to tailor it to specific jobs.
+               </p>
             </div>
             <div id="generatedError" style="display:none"></div>
           </div>
@@ -552,16 +552,6 @@ async function generateCV() {
   btn.innerHTML = '<span>&#9889;</span> Generate My CV';
 }
 
-async function saveCv() {
-  if (!generatedCv) return;
-  try {
-    await apiFetch("PUT", "/api/cv", generatedCv);
-    showToast("CV saved! Ready for tailoring.");
-  } catch (err) {
-    showToast(err.message, "error");
-  }
-}
-
 async function downloadFile(format) {
   if (!generatedPaths) return;
   const key = format === "pdf" ? "cv_pdf" : "cv";