[FIX] Replace info text with resource status expander and fix toggle instantiation bug for blocked methods

tabs/tab2_constraints.py

@@ -66,12 +66,8 @@ def get_uncovered_hidden_resources(m, cost_sliders_norm):
             optional — in secondary_resources, shown as informational only.
             Returns ([], []) when nothing is uncovered.
     """
-    from config.config import resource_groups
-
     custom_resources = st.session_state.get("custom_resources", [])
     covered = {b["name"] for b in custom_resources if m in b.get("methods", {})}
-    resource_caps = st.session_state.get("resource_caps", {})
-    resource_to_group = {r: g for g, resources in resource_groups.items() for r in resources}
 
     required, optional = [], []
     for r, coeff_dict in cost_sliders_norm.get(m, {}).items():
@@ -81,12 +77,6 @@ def get_uncovered_hidden_resources(m, cost_sliders_norm):
             continue
         if r in covered:
             continue
-        group = resource_to_group.get(r)
-        group_resources = resource_groups.get(group, []) if group else []
-        standard_in_group = [s for s in group_resources if s not in hidden_resource_names]
-        any_standard_provided = any(resource_caps.get(s, 0.0) > 0 for s in standard_in_group)
-        if any_standard_provided:
-            continue
         if (m, r) in secondary_resources:
             optional.append(r)
         else:
@@ -94,6 +84,58 @@ def get_uncovered_hidden_resources(m, cost_sliders_norm):
     return required, optional
 
 
+def _render_resource_status(m, cost_sliders_norm):
+    """Render an expander showing all resources of method m with their availability status.
+
+    Standard resources: ✅ if cap > 0, ❌ if = 0.
+    Hidden resources:   ✅ if covered by a custom batch, ❌ if not.
+    Secondary resources are shown in a separate section.
+    """
+    resource_caps   = st.session_state.get("resource_caps", {})
+    custom_resources = st.session_state.get("custom_resources", [])
+    covered = {b["name"] for b in custom_resources if m in b.get("methods", {})}
+
+    all_res = cost_sliders_norm.get(m, {})
+    required_rows = []
+    optional_rows = []
+
+    for r, coeff_dict in all_res.items():
+        if coeff_dict.get("median", 0.0) <= 0:
+            continue
+        if r in hidden_resource_names:
+            available = r in covered
+            source = "Add as new resource in Resource inputs"
+        else:
+            available = resource_caps.get(r, 0.0) > 0
+            source = "Set quantity in Resource inputs"
+
+        icon = "✅" if available else "❌"
+        row = (icon, r, "" if available else source)
+
+        if (m, r) in secondary_resources:
+            optional_rows.append(row)
+        else:
+            required_rows.append(row)
+
+    with st.expander("Why is this method disabled?", expanded=False):
+        if required_rows:
+            st.markdown("**Required resources**")
+            for _, r, hint in required_rows:
+                color = "#55C95B" if not hint else "#FF5F4D"
+                label = f'<span style="color:{color};font-weight:600"><strong>{r}</strong></span>'
+                if hint:
+                    label += f' <span style="color:#888;font-style:italic;font-weight:400">: {hint}</span>'
+                st.markdown(label, unsafe_allow_html=True)
+        if optional_rows:
+            st.markdown("**Optional resources**")
+            for _, r, hint in optional_rows:
+                color = "#55C95B" if not hint else "#FF5F4D"
+                label = f'<span style="color:{color};font-weight:600"><strong>{r}</strong></span>'
+                if hint:
+                    label += f' <span style="color:#888;font-style:italic;font-weight:400">: {hint}</span>'
+                st.markdown(label, unsafe_allow_html=True)
+
+
 def render_method(m, cols, i, method_to_primary_resources, cost_sliders_norm):
     """Render the constraint widget group (toggle + cap slider/input) for one method.
 
@@ -118,20 +160,18 @@ def render_method(m, cols, i, method_to_primary_resources, cost_sliders_norm):
         toggle_key = f"toggle_{m}"
         cap_type_key = f"cap_type_{m}"
 
-        # Check for missing hidden resources BEFORE the toggle widget is
-        # instantiated — Streamlit forbids modifying a widget's session-state
-        # key after the widget has been created.
-        uncovered_required, uncovered_optional = get_uncovered_hidden_resources(m, cost_sliders_norm)
+        # Check for missing hidden resources. This runs before the regular
+        # st.toggle so we never touch toggle_{m} at all for blocked methods —
+        # the pre-render sync already set that key and Streamlit would raise
+        # "cannot be modified after widget is instantiated" if we touched it again.
+        # Instead we force the constraint to inactive in the data layer and show
+        # a static label + info box without any widget that uses toggle_{m}.
+        uncovered_required, _ = get_uncovered_hidden_resources(m, cost_sliders_norm)
         if uncovered_required:
             st.session_state.constraints[m]["active"] = False
-            st.session_state[toggle_key] = False
-            st.toggle(m, key=toggle_key, help=tooltip, disabled=True)
-            req_list = "\n".join(f"- **{r}** *(required)*" for r in uncovered_required)
-            opt_list = "\n".join(f"- **{r}** *(optional)*" for r in uncovered_optional) if uncovered_optional else ""
-            body = f"To use this method, add a new resource in the **Resource inputs** tab:\n\n{req_list}"
-            if opt_list:
-                body += f"\n{opt_list}"
-            st.info(body, icon=":material/info:")
+            st.session_state.pop(toggle_key, None)
+            st.toggle(m, value=False, key=toggle_key, disabled=True, help=tooltip)
+            _render_resource_status(m, cost_sliders_norm)
             return
 
         was_active = constraint["active"]
@@ -330,6 +370,17 @@ def render_tab(cost_sliders):
     just_activated = st.session_state.pop("just_activated_methods", set())
 
     for m, c in st.session_state.constraints.items():
+        # Methods with uncovered hidden resources are always forced inactive —
+        # skip the normal active-branch so the toggle key is never set to True.
+        uncov_req, _ = get_uncovered_hidden_resources(m, cost_sliders_norm)
+        if uncov_req:
+            st.session_state.constraints[m]["active"] = False
+            st.session_state.pop(f"toggle_{m}", None)
+            st.session_state.pop(f"cap_type_{m}", None)
+            st.session_state.pop(f"slider_{m}", None)
+            st.session_state.pop(f"manual_{m}", None)
+            continue
+
         force = just_loaded or (m in just_activated)
         if c["active"]:
             cap_type = c.get("cap_type", "percent")
@@ -394,13 +445,16 @@ def render_tab(cost_sliders):
         for display_m, _ in all_display
     )
     # Activatable: variants are always activatable; standard methods only if they
-    # have at least one visible (non-hidden) primary resource.
+    # have at least one visible (non-hidden) primary resource AND no uncovered
+    # hidden resource that would block them.
     activatable = []
     for display_m, orig_m in all_display:
         if display_m != orig_m:  # it's a variant → batch provides the resource
             activatable.append(display_m)
         elif get_hidden_resources_for_method(orig_m, method_to_primary_resources, cost_sliders_norm)[0] is None:
-            activatable.append(orig_m)
+            uncov_req, _ = get_uncovered_hidden_resources(orig_m, cost_sliders_norm)
+            if not uncov_req:
+                activatable.append(orig_m)
 
     if any_active:
         if st.button("Deactivate all", icon=":material/remove_done:", key="btn-deactivate-all"):