[FIX] tab3: add early return for zero-cap resources, simplify availability messages, remove unused has_custom_batch param

tabs/tab3_coefficients.py

@@ -5,7 +5,7 @@ from config.config import (method_groups, method_order, resource_groups,
                            resource_order, secondary_resources, resource_unit_map, CO2_UNIT,
                            hidden_resource_names)
 from utils.ui_helpers import format_efficiency_summary, show_bar
-from utils.data_utils import (strip_unit_suffix, get_resource_to_group, normalize_costs,
+from utils.data_utils import (get_resource_to_group, normalize_costs,
                               get_slider_params, is_method_enabled, is_custom_secondary)
 
 
@@ -90,7 +90,7 @@ def build_custom_slider_index(cost_sliders_norm, custom_resources):
     return custom_sliders_by_method, custom_resource_names, custom_resource_to_sub_group, custom_resource_to_group
 
 
-def render_standard_resource_row(method, r, conf, display_label, enabled_methods, has_custom_batch=False):
+def render_standard_resource_row(method, r, conf, display_label, enabled_methods):
     """Render the slider row for a single standard resource coefficient.
 
     Handles the secondary-resource toggle, fixed-value display, and the
@@ -103,7 +103,6 @@ def render_standard_resource_row(method, r, conf, display_label, enabled_methods
         conf (dict): {min, median, max} for this (method, resource) pair.
         display_label (str): human-readable resource label with unit.
         enabled_methods (dict): {resource: {method: bool}} from session state.
-        has_custom_batch (bool): True if a custom batch derived from r exists.
 
     Returns:
         None
@@ -136,17 +135,10 @@ def render_standard_resource_row(method, r, conf, display_label, enabled_methods
         )
         st.session_state.costs[method][r] = conf["median"]
         if st.session_state.get("resource_caps", {}).get(r, 0) <= 0:
-            if has_custom_batch:
-                st.warning(
-                    f"No available quantity set for **{r}** in Resource Inputs tab.",
-                    icon=":material/warning:",
-                )
-            else:
-                st.warning(
-                    f"No available quantity set for **{r}** in Resource Inputs tab: "
-                    f"**{method}** won't be used in the optimization.",
-                    icon=":material/warning:",
-                )
+            st.info(
+                f"No available quantity set for **{r}** in Resource Inputs tab.",
+                icon=":material/info:",
+            )
         return
 
     if slider_key not in st.session_state:
@@ -154,17 +146,14 @@ def render_standard_resource_row(method, r, conf, display_label, enabled_methods
     if manual_key not in st.session_state:
         st.session_state[manual_key] = st.session_state[slider_key]
     if st.session_state.get("resource_caps", {}).get(r, 0) <= 0:
-        if has_custom_batch:
-            st.warning(
-                f"No available quantity set for **{r}** in Resource Inputs tab.",
-                icon=":material/warning:",
-            )
-        else:
-            st.warning(
-                f"No available quantity set for **{r}** in Resource Inputs tab: "
-                f"**{method}** won't be used in the optimization.",
-                icon=":material/warning:",
-            )
+        st.info(
+            f"No available quantity set for **{r}** in Resource Inputs tab.",
+            icon=":material/info:",
+        )
+        # Don't render the slider — with zero supply, its coefficient has no
+        # effect on the result (mirrors the "fixed value" branch above, which
+        # already stops here instead of leaving a live-but-meaningless widget).
+        return
 
     col1, col2 = st.columns([3, 1])
     with col1:
@@ -237,17 +226,17 @@ def render_custom_resource_row(method, r, conf, enabled_methods, custom_resource
 
     batch_amount = next((float(b.get("amount", 0)) for b in custom_resources if b["name"] == r), 0.0)
     if batch_amount <= 0:
-        if is_sec:
-            st.info(
-                f"No available quantity set for **{r}** in Resource Inputs.",
-                icon=":material/info:",
-            )
-        else:
-            st.info(
-                f"No available quantity set for **{r}** in Resource Inputs — "
-                "this method won't be used in the optimization.",
-                icon=":material/info:",
-            )
+        # Not necessarily true that the method "won't be used": it may still
+        # run via the standard resource this batch complements, or via a
+        # sibling batch of the same reference — so just report this specific
+        # batch's own availability, same message regardless of is_sec.
+        st.info(
+            f"No available quantity set for **{r}** in Resource Inputs.",
+            icon=":material/info:",
+        )
+        # Don't render the slider — with zero supply, its coefficient has no
+        # effect on the result.
+        return
 
     col1, col2 = st.columns([3, 1])
     with col1:
@@ -327,12 +316,10 @@ def panel_method_editor(
 
             st.markdown(f'<p class="crra-group-name">{group_name}</p>', unsafe_allow_html=True)
 
-            resources_with_batches = set(custom_resource_to_sub_group.values())
             for r in used:
                 conf = method_sliders[r]
                 render_standard_resource_row(
                     method, r, conf, resource_display.get(r, r), enabled_methods,
-                    has_custom_batch=(r in resources_with_batches),
                 )
 
             for r in custom_in_group: