Update main.py

main.py

@@ -3,7 +3,8 @@ import os
 import json
 import re
 import requests
-from typing import Optional, Any, Dict
+import builtins
+from typing import Optional, Any, Dict, List
 from contextlib import asynccontextmanager
 from fastapi import FastAPI, HTTPException
 from fastapi.middleware.cors import CORSMiddleware
@@ -23,6 +24,13 @@ from services.generate_ticket import get_valid_token, create_incident
 VERIFY_SSL = os.getenv("SERVICENOW_SSL_VERIFY", "true").lower() in ("1", "true", "yes")
 GEMINI_SSL_VERIFY = os.getenv("GEMINI_SSL_VERIFY", "true").lower() in ("1", "true", "yes")
 
+# --- Safe stringify to avoid shadowing 'str' ---
+def safe_str(e: Any) -> str:
+    try:
+        return builtins.str(e)
+    except Exception:
+        return "<error stringify failed>"
+
 load_dotenv()
 os.environ["POSTHOG_DISABLED"] = "true"
 
@@ -36,7 +44,7 @@ async def lifespan(app: FastAPI):
         else:
             print(f"✅ KB already populated with {collection.count()} entries. Skipping ingestion.")
     except Exception as e:
-        print(f"⚠️ KB ingestion failed: {e}")
+        print(f"⚠️ KB ingestion failed: {safe_str(e)}")
     yield
 
 app = FastAPI(lifespan=lifespan)
@@ -152,7 +160,7 @@ def _build_clarifying_message() -> str:
         "Reply with these details and I’ll search again."
     )
 
-def _build_tracking_descriptions(issue_text: str, resolved_text: str) -> tuple[str, str]:
+def _build_tracking_descriptions(issue_text: str, resolved_text: str) -> Tuple[str, str]:
     issue = (issue_text or "").strip()
     resolved = (resolved_text or "").strip()
     short_desc = issue[:100] if issue else (resolved[:100] or "Issue resolved (user confirmation)")
@@ -222,9 +230,12 @@ def _classify_resolution_llm(user_message: str) -> bool:
         resp = requests.post(GEMINI_URL, headers=headers, json=payload, timeout=12, verify=GEMINI_SSL_VERIFY)
         data = resp.json()
         text = (
-            data.get("candidates", [{}])[0].get("content", {}).get("parts", [{}])[0].get("text", "")
-        ).strip().lower()
-        return "true" in text
+            data.get("candidates", [{}])[0]
+            .get("content", {})
+            .get("parts", [{}])[0]
+            .get("text", "")
+        )
+        return "true" in (text or "").strip().lower()
     except Exception:
         return False
 
@@ -248,11 +259,11 @@ def _normalize_for_match(text: str) -> str:
     t = re.sub(r"\s+", " ", t).strip()
     return t
 
-def _split_sentences(ctx: str) -> list[str]:
+def _split_sentences(ctx: str) -> List[str]:
     raw_sents = re.split(r"(?<=[.!?])\s+|\n+|•\s*|-\s*", ctx or "")
     return [s.strip() for s in raw_sents if s and len(s.strip()) > 2]
 
-def _filter_context_for_query(context: str, query: str) -> tuple[str, dict]:
+def _filter_context_for_query(context: str, query: str) -> Tuple[str, Dict[str, Any]]:
     ctx = (context or "").strip()
     if not ctx or not query:
         return ctx, {'mode': 'concise', 'matched_count': 0, 'all_sentences': 0}
@@ -303,7 +314,7 @@ ACTION_SYNS_FLAT = {
     "navigate": ["navigate", "go to", "open"],
 }
 
-def _action_in_line(ln: str, target_actions: list[str]) -> bool:
+def _action_in_line(ln: str, target_actions: List[str]) -> bool:
     s = (ln or "").lower()
     for act in target_actions:
         for syn in ACTION_SYNS_FLAT.get(act, [act]):
@@ -327,13 +338,12 @@ def _is_procedural_line(ln: str) -> bool:
         return True
     return False
 
-def _extract_steps_only(text: str, max_lines: int = 12, target_actions: list[str] | None = None) -> str:
+def _extract_steps_only(text: str, max_lines: int = 12, target_actions: Optional[List[str]] = None) -> str:
     lines = [ln.strip() for ln in (text or "").splitlines() if ln.strip()]
     kept = []
     for ln in lines:
         if _is_procedural_line(ln):
-            # If specific action requested (e.g., create), keep only lines containing that action
-            if target_actions and len(target_actions) > 0:
+            if target_actions:
                 if not _action_in_line(ln, target_actions):
                     continue
             kept.append(ln)
@@ -429,7 +439,7 @@ async def chat_with_ai(input_data: ChatInput):
                     }
             except Exception as e:
                 return {
-                    "bot_response": f"⚠️ Something went wrong while creating the tracking incident: {str(e)}",
+                    "bot_response": f"⚠️ Something went wrong while creating the tracking incident: {safe_str(e)}",
                     "status": "PARTIAL",
                     "context_found": False,
                     "ask_resolved": False,
@@ -505,12 +515,16 @@ async def chat_with_ai(input_data: ChatInput):
                 data = response.json()
                 lst = data.get("result", [])
                 result = (lst or [{}])[0] if response.status_code == 200 else {}
-                state_code = str(result.get("state", "unknown"))
+                state_code = builtins.str(result.get("state", "unknown"))
                 state_label = STATE_MAP.get(state_code, state_code)
                 short = result.get("short_description", "")
                 num = result.get("number", number or "unknown")
                 return {
-                    "bot_response": (f"**Ticket:** {num} \n" f"**Status:** {state_label} \n" f"**Issue description:** {short}"),
+                    "bot_response": (
+                        f"**Ticket:** {num} \n"
+                        f"**Status:** {state_label} \n"
+                        f"**Issue description:** {short}"
+                    ),
                     "status": "OK",
                     "show_assist_card": True,
                     "context_found": False,
@@ -522,7 +536,7 @@ async def chat_with_ai(input_data: ChatInput):
                     "debug": {"intent": "status", "http_status": response.status_code},
                 }
             except Exception as e:
-                raise HTTPException(status_code=500, detail=str(e))
+                raise HTTPException(status_code=500, detail=safe_str(e))
 
         # ---- Hybrid KB search ----
         kb_results = hybrid_search_knowledge_base(input_data.user_message, top_k=10, alpha=0.6, beta=0.4)
@@ -537,7 +551,6 @@ async def chat_with_ai(input_data: ChatInput):
         detected_intent = kb_results.get("user_intent", "neutral")
         actions = kb_results.get("actions", [])
 
-        # Shape context by intent + action
         q = (input_data.user_message or "").lower()
         if detected_intent == "steps" or any(k in q for k in ["steps", "procedure", "perform", "do", "process"]):
             context = _extract_steps_only(context, max_lines=12, target_actions=actions)
@@ -546,7 +559,6 @@ async def chat_with_ai(input_data: ChatInput):
         elif any(k in q for k in ["navigate", "navigation", "menu", "screen"]):
             context = _extract_navigation_only(context, max_lines=6)
 
-        # Gating
         short_query = len((input_data.user_message or "").split()) <= 4
         gate_combined_no_kb = 0.22 if short_query else 0.28
         gate_combined_ok = 0.60 if short_query else 0.55
@@ -574,12 +586,11 @@ async def chat_with_ai(input_data: ChatInput):
                 "debug": {"used_chunks": 0, "second_try": second_try, "best_distance": best_distance, "best_combined": best_combined},
             }
 
-        # LLM rewrite (optional, may rate-limit)
         enhanced_prompt = (
             "From the provided context, output only the actionable steps/procedure relevant to the user's question. "
             "Use ONLY the provided context; do NOT add information that is not present. "
-            ("Return ONLY lines containing the requested action verbs." if actions else "")
-            + " Do NOT include document names, section titles, or 'Source:' lines.\n\n"
+            + ("Return ONLY lines containing the requested action verbs. " if actions else "")
+            + "Do NOT include document names, section titles, or 'Source:' lines.\n\n"
             f"### Context\n{context}\n\n"
             f"### Question\n{input_data.user_message}\n\n"
             "### Output\n"
@@ -604,7 +615,7 @@ async def chat_with_ai(input_data: ChatInput):
             bot_text = ""
 
         if not bot_text.strip():
-            bot_text = context  # strict steps-only fallback
+            bot_text = context
         bot_text = _strip_any_source_lines(bot_text).strip()
 
         status = "OK" if (
@@ -640,7 +651,8 @@ async def chat_with_ai(input_data: ChatInput):
     except HTTPException:
         raise
     except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+        # Ensure we never crash due to shadowed str()
+        raise HTTPException(status_code=500, detail=safe_str(e))
 
 def _set_incident_resolved(sys_id: str) -> bool:
     try:
@@ -668,7 +680,7 @@ def _set_incident_resolved(sys_id: str) -> bool:
                 resp1 = requests.patch(url, headers=headers, json={"state": "2"}, verify=VERIFY_SSL, timeout=25)
                 print(f"[SN PATCH progress] status={resp1.status_code} body={resp1.text[:500]}")
             except Exception as e:
-                print(f"[SN PATCH progress] exception={str(e)}")
+                print(f"[SN PATCH progress] exception={safe_str(e)}")
 
         def clean(d: dict) -> dict:
             return {k: v for k, v in d.items() if v is not None}
@@ -721,7 +733,7 @@ def _set_incident_resolved(sys_id: str) -> bool:
         print(f"[SN PATCH resolve C] status={respC.status_code} body={respC.text[:500]}")
         return False
     except Exception as e:
-        print(f"[SN PATCH resolve] exception={str(e)}")
+        print(f"[SN PATCH resolve] exception={safe_str(e)}")
         return False
 
 @app.post("/incident")
@@ -746,7 +758,7 @@ async def raise_incident(input_data: IncidentInput):
             "followup": "Is there anything else I can assist you with?",
         }
     except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail=safe_str(e))
 
 @app.post("/generate_ticket_desc")
 async def generate_ticket_desc_ep(input_data: TicketDescInput):
@@ -783,7 +795,7 @@ async def generate_ticket_desc_ep(input_data: TicketDescInput):
         except Exception:
             return {"ShortDescription": "", "DetailedDescription": "", "error": "Invalid JSON returned"}
     except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail=safe_str(e))
 
 @app.post("/incident_status")
 async def incident_status(input_data: TicketStatusInput):
@@ -806,16 +818,32 @@ async def incident_status(input_data: TicketStatusInput):
             result = (lst or [{}])[0] if response.status_code == 200 else {}
         else:
             raise HTTPException(status_code=400, detail="Provide IncidentID (number) or sys_id")
-        state_code = str(result.get("state", "unknown"))
+        state_code = builtins.str(result.get("state", "unknown"))
         state_label = STATE_MAP.get(state_code, state_code)
         short = result.get("short_description", "")
         number = result.get("number", input_data.number or "unknown")
         return {
-            "bot_response": (f"**Ticket:** {number} \n" f"**Status:** {state_label} \n" f"**Issue description:** {short}").replace("\n", " \n"),
+            "bot_response": (
+                f"**Ticket:** {number} \n"
+                f"**Status:** {state_label} \n"
+                f"**Issue description:** {short}"
+            ).replace("\n", " \n"),
             "followup": "Is there anything else I can assist you with?",
             "show_assist_card": True,
             "persist": True,
             "debug": "Incident status fetched",
         }
     except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail=safe_str(e))
+
+# ---- Admin (optional) ----
+@app.get("/kb/info")
+async def kb_info():
+    from services.kb_creation import get_kb_runtime_info
+    return get_kb_runtime_info()
+
+@app.post("/kb/reset")
+async def kb_reset():
+    from services.kb_creation import reset_kb
+    folder_path = os.path.join(os.getcwd(), "documents")
+    return reset_kb(folder_path)