Update services/kb_creation.py

services/kb_creation.py

@@ -1,3 +1,4 @@
+#updated
 
 # services/kb_creation.py
 import os
@@ -318,17 +319,19 @@ def bm25_search(query: str, top_k: int = 50) -> List[Tuple[int, float]]:
 # ---------------------------- Semantic-only ----------------------------
 def search_knowledge_base(query: str, top_k: int = 10) -> dict:
     query_embedding = model.encode(query).tolist()
+    # Some Chroma client versions do not support "ids" in include.
     res = collection.query(
         query_embeddings=[query_embedding],
         n_results=top_k,
-        include=['documents', 'metadatas', 'distances', 'ids']
+        include=['documents', 'metadatas', 'distances']  # no 'ids' here
     )
     documents = (res.get("documents", [[]]) or [[]])[0]
     metadatas = (res.get("metadatas", [[]]) or [[]])[0]
     distances = (res.get("distances", [[]]) or [[]])[0]
-    ids = (res.get("ids", [[]]) or [[]])[0]
 
-    if not ids and documents:
+    # Synthesize IDs from metadata (filename:section:chunk_index)
+    ids: List[str] = []
+    if documents:
         synthesized = []
         for i, m in enumerate(metadatas):
             fn = (m or {}).get("filename", "unknown")
@@ -337,7 +340,7 @@ def search_knowledge_base(query: str, top_k: int = 10) -> dict:
             synthesized.append(f"{fn}:{sec}:{idx}")
         ids = synthesized
 
-    print(f"[KB] search → {len(documents)} docs (top_k={top_k}); first distance: {distances[0] if distances else 'n/a'}; ids={len(ids)}")
+    print(f"[KB] search → {len(documents)} docs (top_k={top_k}); first distance: {distances[0] if distances else 'n/a'}; ids synthesized={len(ids)}")
     return {
         "documents": documents,
         "metadatas": metadatas,
@@ -653,4 +656,4 @@ def reset_kb(folder_path: str) -> Dict[str, Any]:
         result["info"] = get_kb_runtime_info()
         return result
     except Exception as e:
-        return {"status": "ERROR", "error": f"{e}", "info": get_kb_runtime_info()}
+        return {"status": "ERROR", "error": f"{e}", "info": get_kb_runtime_info()}