Update app.py

app.py

@@ -275,12 +275,8 @@ def log_event(data: Dict):
             "question": data.get("question"),
             "student_id": data.get("student_id"),
         }
-        # ✅ 让 event_type 作为 metadata 字段，这样在 Dataset 列表里能直接看到 / 过滤
-        metadata = {
-            k: v
-            for k, v in data.items()
-            if k not in ("question", "answer")
-        }
+        # ✅ event_type 等字段作为 metadata，这样在 Dataset 列表里能直接看到 / 过滤
+        metadata = {k: v for k, v in data.items() if k not in ("question", "answer")}
 
         ls_client.create_example(
             inputs=inputs,
@@ -390,6 +386,9 @@ with gr.Blocks(
     user_name_state = gr.State("")
     user_id_state = gr.State("")
 
+    # ✅ 当前“最近一次回答”是否已经被点赞/点踩（只允许一次）
+    feedback_used_state = gr.State(False)
+
     # --- Header ---
     with gr.Row(elem_classes="header-container"):
         with gr.Column(scale=3):
@@ -684,6 +683,7 @@ with gr.Blocks(
                 ),
                 user_name_state: gr.update(),
                 user_id_state: gr.update(),
+                feedback_used_state: False,
                 user_input: gr.update(interactive=False),
                 clear_btn: gr.update(interactive=False),
                 export_btn: gr.update(interactive=False),
@@ -696,8 +696,8 @@ with gr.Blocks(
                 learning_mode: gr.update(interactive=False),
                 model_name: gr.update(interactive=False),
                 docs_btn: gr.update(interactive=False),
-                thumb_up_btn: gr.update(interactive=False),
-                thumb_down_btn: gr.update(interactive=False),
+                thumb_up_btn: gr.update(interactive=False, value="👍 Helpful"),
+                thumb_down_btn: gr.update(interactive=False, value="👎 Not helpful"),
                 feedback_toggle_btn: gr.update(interactive=False),
                 feedback_text: gr.update(visible=False, value=""),
                 feedback_submit_btn: gr.update(interactive=False, visible=False),
@@ -716,6 +716,7 @@ with gr.Blocks(
             student_info_html: gr.update(value=info_html),
             user_name_state: name,
             user_id_state: id_val,
+            feedback_used_state: False,
             user_input: gr.update(
                 interactive=True,
                 placeholder="Ask about Module 10 concepts, Responsible AI, or let Clare test you...",
@@ -731,8 +732,9 @@ with gr.Blocks(
             learning_mode: gr.update(interactive=True),
             model_name: gr.update(interactive=False),
             docs_btn: gr.update(interactive=True),
-            thumb_up_btn: gr.update(interactive=True),
-            thumb_down_btn: gr.update(interactive=True),
+            # ✅ 登录后仍然不允许点赞点踩，必须“有回答”才解锁
+            thumb_up_btn: gr.update(interactive=False, value="👍 Helpful"),
+            thumb_down_btn: gr.update(interactive=False, value="👎 Not helpful"),
             feedback_toggle_btn: gr.update(interactive=True),
             feedback_text: gr.update(visible=False, value=""),
             feedback_submit_btn: gr.update(interactive=True, visible=False),
@@ -748,6 +750,7 @@ with gr.Blocks(
             student_info_html,
             user_name_state,
             user_id_state,
+            feedback_used_state,
             user_input,
             clear_btn,
             export_btn,
@@ -777,6 +780,7 @@ with gr.Blocks(
             id_input: gr.update(value=""),
             user_name_state: "",
             user_id_state: "",
+            feedback_used_state: False,
             student_info_html: gr.update(value=""),
             user_input: gr.update(
                 value="",
@@ -793,8 +797,8 @@ with gr.Blocks(
             language_preference: gr.update(interactive=False),
             learning_mode: gr.update(interactive=False),
             docs_btn: gr.update(interactive=False),
-            thumb_up_btn: gr.update(interactive=False),
-            thumb_down_btn: gr.update(interactive=False),
+            thumb_up_btn: gr.update(interactive=False, value="👍 Helpful"),
+            thumb_down_btn: gr.update(interactive=False, value="👎 Not helpful"),
             feedback_toggle_btn: gr.update(interactive=False),
             feedback_text: gr.update(visible=False, value=""),
             feedback_submit_btn: gr.update(interactive=False, visible=False),
@@ -810,6 +814,7 @@ with gr.Blocks(
             id_input,
             user_name_state,
             user_id_state,
+            feedback_used_state,
             student_info_html,
             user_input,
             clear_btn,
@@ -888,7 +893,9 @@ with gr.Blocks(
         mode_val,
         doc_type_val,
         user_id_val,
+        feedback_used,
     ):
+        # 未登录：不解锁按钮
         if not user_id_val:
             out_msg = (
                 "🔒 Please log in with your Student Name and Email/ID on the right "
@@ -900,17 +907,40 @@ with gr.Blocks(
                 weaknesses or [],
                 cognitive_state or {"confusion": 0, "mastery": 0},
             )
-            return "", new_history, weaknesses, cognitive_state, new_status, "", ""
+            return (
+                "",
+                new_history,
+                weaknesses,
+                cognitive_state,
+                new_status,
+                "",
+                "",
+                feedback_used,
+                gr.update(interactive=False, value="👍 Helpful"),
+                gr.update(interactive=False, value="👎 Not helpful"),
+            )
 
         resolved_lang = detect_language(message or "", lang_pref)
 
+        # 空输入：不改变按钮状态
         if not message or not message.strip():
             new_status = render_session_status(
                 mode_val or "Concept Explainer",
                 weaknesses or [],
                 cognitive_state or {"confusion": 0, "mastery": 0},
             )
-            return "", chat_history, weaknesses, cognitive_state, new_status, "", ""
+            return (
+                "",
+                chat_history,
+                weaknesses,
+                cognitive_state,
+                new_status,
+                "",
+                "",
+                feedback_used,
+                gr.update(),
+                gr.update(),
+            )
 
         weaknesses = update_weaknesses_from_message(message, weaknesses or [])
         cognitive_state = update_cognitive_state_from_message(message, cognitive_state)
@@ -972,7 +1002,19 @@ with gr.Blocks(
 
         new_status = render_session_status(mode_val, weaknesses, cognitive_state)
 
-        return "", new_history, weaknesses, cognitive_state, new_status, message, answer
+        # ✅ 有新回答：重置 feedback_used=False，并解锁按钮（恢复文案）
+        return (
+            "",
+            new_history,
+            weaknesses,
+            cognitive_state,
+            new_status,
+            message,
+            answer,
+            False,
+            gr.update(interactive=True, value="👍 Helpful"),
+            gr.update(interactive=True, value="👎 Not helpful"),
+        )
 
     user_input.submit(
         respond,
@@ -988,6 +1030,7 @@ with gr.Blocks(
             learning_mode,
             doc_type,
             user_id_state,
+            feedback_used_state,
         ],
         [
             user_input,
@@ -997,6 +1040,9 @@ with gr.Blocks(
             session_status,
             last_question_state,
             last_answer_state,
+            feedback_used_state,
+            thumb_up_btn,
+            thumb_down_btn,
         ],
     )
 
@@ -1129,10 +1175,33 @@ with gr.Blocks(
         [feedback_text, feedback_submit_btn],
     )
 
-    def send_thumb_up(last_q, last_a, user_id_val, mode_val, model_name_val, lang_pref):
+    def send_thumb_up(
+        last_q,
+        last_a,
+        user_id_val,
+        mode_val,
+        model_name_val,
+        lang_pref,
+        feedback_used,
+    ):
+        # 没有可评价回答：保持禁用
         if not last_q and not last_a:
             print("No last QA to log for thumbs_up.")
-            return
+            return (
+                feedback_used,
+                gr.update(interactive=False, value="👍 Helpful"),
+                gr.update(interactive=False, value="👎 Not helpful"),
+            )
+
+        # 已经反馈过：直接禁用
+        if feedback_used:
+            print("Feedback already sent for this answer (thumb_up).")
+            return (
+                feedback_used,
+                gr.update(interactive=False),
+                gr.update(interactive=False),
+            )
+
         try:
             log_event(
                 {
@@ -1151,10 +1220,38 @@ with gr.Blocks(
         except Exception as e:
             print("thumb_up log error:", e)
 
-    def send_thumb_down(last_q, last_a, user_id_val, mode_val, model_name_val, lang_pref):
+        # 点完一次：置 True + 按钮置灰 + 文案 sent
+        return (
+            True,
+            gr.update(interactive=False, value="👍 Helpful (sent)"),
+            gr.update(interactive=False),
+        )
+
+    def send_thumb_down(
+        last_q,
+        last_a,
+        user_id_val,
+        mode_val,
+        model_name_val,
+        lang_pref,
+        feedback_used,
+    ):
         if not last_q and not last_a:
             print("No last QA to log for thumbs_down.")
-            return
+            return (
+                feedback_used,
+                gr.update(interactive=False, value="👍 Helpful"),
+                gr.update(interactive=False, value="👎 Not helpful"),
+            )
+
+        if feedback_used:
+            print("Feedback already sent for this answer (thumb_down).")
+            return (
+                feedback_used,
+                gr.update(interactive=False),
+                gr.update(interactive=False),
+            )
+
         try:
             log_event(
                 {
@@ -1173,6 +1270,12 @@ with gr.Blocks(
         except Exception as e:
             print("thumb_down log error:", e)
 
+        return (
+            True,
+            gr.update(interactive=False),
+            gr.update(interactive=False, value="👎 Not helpful (sent)"),
+        )
+
     thumb_up_btn.click(
         send_thumb_up,
         [
@@ -1182,8 +1285,9 @@ with gr.Blocks(
             learning_mode,
             model_name,
             language_preference,
+            feedback_used_state,
         ],
-        [],
+        [feedback_used_state, thumb_up_btn, thumb_down_btn],
     )
 
     thumb_down_btn.click(
@@ -1195,8 +1299,9 @@ with gr.Blocks(
             learning_mode,
             model_name,
             language_preference,
+            feedback_used_state,
         ],
-        [],
+        [feedback_used_state, thumb_up_btn, thumb_down_btn],
     )
 
     def submit_detailed_feedback(
@@ -1272,7 +1377,19 @@ with gr.Blocks(
     def clear_all():
         empty_state = {"confusion": 0, "mastery": 0}
         default_status = render_session_status("Concept Explainer", [], empty_state)
-        return [], [], empty_state, [], "", default_status, "", ""
+        return (
+            [],
+            [],
+            empty_state,
+            [],
+            "",
+            default_status,
+            "",
+            "",
+            False,
+            gr.update(interactive=False, value="👍 Helpful"),
+            gr.update(interactive=False, value="👎 Not helpful"),
+        )
 
     clear_btn.click(
         clear_all,
@@ -1286,6 +1403,9 @@ with gr.Blocks(
             session_status,
             last_question_state,
             last_answer_state,
+            feedback_used_state,
+            thumb_up_btn,
+            thumb_down_btn,
         ],
         queue=False,
     )