Update app.py

app.py

@@ -367,16 +367,14 @@ def create_subtitle_clip_pil(text, start_time, end_time, video_width, video_heig
     try:
         subtitle_width = int(video_width * 0.8)
         aspect_ratio = video_height / video_width
-        if aspect_ratio > 1.2:  # Portrait video
-            subtitle_font_size = int(video_width // 22)
-        else:  # Landscape video
-            subtitle_font_size = int(video_height // 24)
+        subtitle_font_size = int(video_width // 22 if aspect_ratio > 1.2 else video_height // 24)
 
         font = ImageFont.truetype(font_path, subtitle_font_size)
 
         dummy_img = Image.new("RGBA", (subtitle_width, 1), (0, 0, 0, 0))
         draw = ImageDraw.Draw(dummy_img)
 
+        # Word wrapping
         lines = []
         line = ""
         for word in text.split():
@@ -392,21 +390,34 @@ def create_subtitle_clip_pil(text, start_time, end_time, video_width, video_heig
 
         line_heights = [draw.textbbox((0, 0), l, font=font)[3] - draw.textbbox((0, 0), l, font=font)[1] for l in lines]
         total_height = sum(line_heights) + (len(lines) - 1) * 5
+
         img = Image.new("RGBA", (subtitle_width, total_height), (0, 0, 0, 0))
         draw = ImageDraw.Draw(img)
 
+        def draw_text_with_outline(draw, pos, text, font, fill="white", outline="black", outline_width=2):
+            x, y = pos
+            # Draw outline
+            for dx in range(-outline_width, outline_width + 1):
+                for dy in range(-outline_width, outline_width + 1):
+                    if dx != 0 or dy != 0:
+                        draw.text((x + dx, y + dy), text, font=font, fill=outline)
+            # Draw main text
+            draw.text((x, y), text, font=font, fill=fill)
+
         y = 0
         for idx, line in enumerate(lines):
             bbox = draw.textbbox((0, 0), line, font=font)
             w = bbox[2] - bbox[0]
-            draw.text(((subtitle_width - w) // 2, y), line, font=font, fill="yellow")
+            x = (subtitle_width - w) // 2
+            draw_text_with_outline(draw, (x, y), line, font)
             y += line_heights[idx] + 5
-            
-        img_np = np.array(img)  # <- ✅ Fix: convert to NumPy
-        txt_clip = ImageClip(img_np).set_start(start_time).set_duration(end_time - start_time).set_position("bottom").set_opacity(0.8)
+
+        img_np = np.array(img)
+        txt_clip = ImageClip(img_np).set_start(start_time).set_duration(end_time - start_time).set_position(("center", video_height * 0.85)).set_opacity(0.9)
         return txt_clip
+
     except Exception as e:
-        logger.error(f"\u274c Failed to create subtitle clip: {e}")
+        logger.error(f"❌ Failed to create subtitle clip: {e}")
         return None
 
 def solve_optimal_alignment(original_segments, generated_durations, total_duration):