[KM-674] feat(report): adapt report generator to objective + business_questions

Replace the report's frozen ProblemStatement stub (objective/target/scope) with the 2026-06-24 goal shape: objective + business_questions. Render Objective + numbered Business Questions sections plus a 'generated by {user}' line, and update the report_summary.md prompt accordingly.

Make the report.py state->goal mapping tolerant (new fields if present, else fall back to legacy problem_statement) so the report works both before and after the AnalysisState migration lands. Stays records-based (AnalysisRecord); floor gate (problem_validated) left untouched (separate ticket).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

src/agents/report/generator.py

@@ -167,9 +167,12 @@ def _build_human_content(
     ps: ProblemStatement, findings: list[ReportFinding], caveats: list[AttributedNote]
 ) -> str:
     sections = []
-    ps_lines = [v for v in (ps.objective, ps.target_value, ps.scope) if v]
-    if ps_lines:
-        sections.append("# Problem Statement\n" + "\n".join(ps_lines))
+    if ps.objective:
+        sections.append("# Objective\n" + ps.objective)
+    if ps.business_questions:
+        sections.append(
+            "# Business questions\n" + "\n".join(f"- {q}" for q in ps.business_questions)
+        )
     sections.append(
         "# Findings (already finalized — synthesize, do not add numbers)\n"
         + "\n".join(f"- {f.text}" for f in findings)
@@ -183,15 +186,20 @@ def _render_markdown(report: AnalysisReport) -> str:
     # Version is deliberately NOT in the markdown — it is assigned by the store
     # after rendering and lives in the structured `version` field / API metadata.
     parts: list[str] = ["# Analysis Report"]
-    parts.append(
-        f"*Generated {report.generated_at:%Y-%m-%d} · "
-        f"{len(report.record_ids)} analyses · {len(report.data_sources)} source(s)*"
-    )
+    meta = f"*Generated {report.generated_at:%Y-%m-%d}"
+    if report.user_id:
+        meta += f" by {report.user_id}"
+    meta += f" · {len(report.record_ids)} analyses · {len(report.data_sources)} source(s)*"
+    parts.append(meta)
 
     ps = report.problem_statement
-    ps_lines = [v for v in (ps.objective, ps.target_value, ps.scope) if v]
-    if ps_lines:
-        parts.append("## Problem Statement\n" + " ".join(ps_lines))
+    if ps.objective:
+        parts.append("## Objective\n" + ps.objective)
+    if ps.business_questions:
+        parts.append(
+            "## Business Questions\n"
+            + "\n".join(f"{i}. {q}" for i, q in enumerate(ps.business_questions, 1))
+        )
 
     if report.executive_summary:
         parts.append("## Executive Summary\n" + report.executive_summary)

src/agents/report/schemas.py

@@ -22,17 +22,18 @@ from ..slow_path.schemas import TaskSummary
 
 
 class ProblemStatement(BaseModel):
-    """Minimal stub of Harry's Problem Statement, frozen into each report.
-
-    Loose on purpose until the real PS template lands (Analysis State, upstream).
-    A report snapshots the PS as it was at generation time.
+    """The analysis goal, frozen into each report at generation time.
+
+    Analysis-State shape — `objective` + `business_questions`
+    — which replaced the old single free-text problem statement. A report snapshots
+    the goal as it was at generation time. Class name is kept (for now) to avoid an
+    import churn across report.py / generator.py / store.py; rename to `ReportGoal`
+    once the upstream AnalysisState rename (objective/business_questions) lands so
+    every caller migrates in one pass.
     """
 
     objective: str = ""
-    metric_direction: str = ""  # "increase" | "decrease"
-    target_metric: str = ""
-    target_value: str = ""
-    scope: str = ""
+    business_questions: list[str] = Field(default_factory=list)
 
 
 class DataSourceRef(BaseModel):

src/api/v1/report.py

@@ -45,10 +45,18 @@ async def _load_state(analysis_id: str):
 
 
 def _problem_statement_from(state) -> ProblemStatement:
-    """Map the analysis's free-text problem statement into the report's structured PS."""
-    if state is None or not state.problem_statement:
+    """Freeze the analysis goal into the report's snapshot.
+
+    Bridges the 2026-06-24 AnalysisState rework: prefer the new `objective` +
+    `business_questions` fields when the state carries them, else fall back to the
+    legacy free-text `problem_statement`. So the report works both before and after
+    the state-model migration lands (#4 / dedorch #3).
+    """
+    if state is None:
         return ProblemStatement()
-    return ProblemStatement(objective=state.problem_statement)
+    objective = getattr(state, "objective", "") or getattr(state, "problem_statement", "") or ""
+    business_questions = list(getattr(state, "business_questions", []) or [])
+    return ProblemStatement(objective=objective, business_questions=business_questions)
 
 
 async def _record_report_on_state(analysis_id: str, report_id: str) -> None:

src/config/prompts/report_summary.md

@@ -1,10 +1,10 @@
 You are a senior data analyst writing the **executive summary** of an analysis report.
 
-You are given the Problem Statement and a list of already-finalized findings and caveats drawn from completed analyses. Write a concise executive summary (3–5 sentences) that synthesizes those findings in relation to the stated goal.
+You are given the analysis Objective and its Business questions, plus a list of already-finalized findings and caveats drawn from completed analyses. Write a concise executive summary (3–5 sentences) that synthesizes those findings in relation to the objective and, where the findings allow, the business questions.
 
 Rules:
 - Synthesize and prioritize — lead with the most decision-relevant finding.
 - Do NOT introduce any number, fact, or claim that is not present in the findings. You are summarizing, not analyzing.
-- Do NOT simply restate every finding; connect them into a narrative and say what they mean for the goal.
+- Do NOT simply restate every finding; connect them into a narrative and say what they mean for the objective.
 - If the findings are thin or inconclusive, say so plainly rather than overstating.
 - Plain business language, prose only — no headings, no bullet lists.