[NOTICKET] update table names to dedorch db

DEV_PLAN.md

@@ -29,15 +29,15 @@ describes the *in-flight plan* that changes it. New decisions from the 2026-06-2
 Confirms the 2026-06-24 direction and adds these concrete changes (folded into §4 as tasks 21–28):
 
 1. **Rename `analysis_records` → `agent_observability`** — no "record" in the name (avoids clashing
-   with Go's `analysis_message`). It **stays Python-owned** for now; once the columns/types are fixed,
+   with Go's `analyses_messages`). It **stays Python-owned** for now; once the columns/types are fixed,
    **hand the schema to Harry** so his dedorch migration creates it on env-move — this is how #16 is
    resolved (the table exists post-`SKIP_INIT_DB`). Open: does the write scope broaden to *every agent
    call* (true observability) or stay *one row per slow-path analysis*?
-2. **`analysis` table (Go) gains columns:** `status` (active/inactive soft-delete, like chat rooms),
-   `data_bind` + `data_bind_version` (per-analysis binding; version bumps on change), `report_collection`
-   (generated reports by id + version). Plus Harry drops the duplicate/wrong `analysis` table. (→ #3)
-3. **`analysis_message` (Go) = the analysis chat room** (user Q + agent A) — the new `chat_messages`
-   equivalent; Python reads conversation history from here. (→ #25)
+2. **`analyses` table (Go) — `status`, `data_bind` + `data_bind_version`, `report_collection`** (id+version).
+   **Verified 2026-06-25: these + `user_id` are ALREADY present in dedorch `analyses`.** Plus Harry drops
+   the duplicate/wrong singular `analysis` table. (→ #3)
+3. **`analyses_messages` (Go) = the analysis chat room** (user Q + agent A) — replaces the now-**deprecated**
+   `chat_messages`/`rooms`; Python's chat read/write must migrate here before cutover. (→ #25)
 4. **Reports: Go owns ALL writes.** Report stays a **skill** (no router intent): FE → Go → Python;
    Python only returns content. Input = the records table (now `agent_observability`); edit-mode may
    also need the last report. (→ #7/#18/#24)
@@ -112,8 +112,8 @@ Status legend: ⬜ not started · 🔄 in progress · ✅ done · ⛔ blocked ·
 |---|---|---|---|---|
 | 1 | Comment out `problem_statement` skill **+ `Intent` literal + router prompt + gate redirect target**; remove `/problem-statement` from `list_tools` | Rifqi | ✅ | Done 2026-06-25 (one commit w/ #2). Unwired in `orchestration.py`, `intent_router.md`, `chat_handler.py`, `tools.py`; `problem_statement.py` kept intact |
 | 2 | Drop `problem_validated`: gate neutered; `is_report_ready`/`report_floor` → **≥1 completed analysis** only, no-LLM | Rifqi | ✅ | Done 2026-06-25. `gate.py` no-op, gate call site commented in `chat_handler.py`, `report_floor` drops the goal check. Tests updated (`test_gate`/`test_chat_handler`/`test_readiness`). Suite: **284 passed, 7 skipped**; ruff clean |
-| 3 | dedorch `analysis` migration: drop `problem_statement`/`problem_validated`, add `objective` + `business_questions`, rename `owner_id`→`user_id` | Harry | ⬜ | Blocks #4. **Checkpoint expands it:** also add `status` (soft-delete), `data_bind` + `data_bind_version`, `report_collection` (id+version); drop the duplicate/wrong `analysis` table |
-| 4 | Update Python `analysis` model + `state_store` + `analysis.py` to match #3; `owner_id`→`user_id` | Rifqi/Sofhia | ⛔ after #3 | getattr-tolerant so deploy order isn't a hard blocker |
+| 3 | dedorch `analyses` migration: drop `problem_statement`/`problem_validated`, add `objective` + `business_questions` | Harry | 🔄 | **Verified dedorch 2026-06-25:** `analyses` (plural) ALREADY has `user_id` + `status` + `data_bind` + `data_bind_version` + `report_collection` → those parts done. **Remaining:** drop `problem_statement`/`problem_validated` + add `objective`/`business_questions`. Singular `analysis` = deprecated duplicate to drop |
+| 4 | Update Python `analyses` model + `state_store` + `analysis.py` to match dedorch; `owner_id`→`user_id` | Rifqi/Sofhia | 🔄 | **Tablename done** (`models.py` `analysis`→`analyses`, uncommitted). **Remaining:** `owner_id`→`user_id` + add `status`/`data_bind`/`data_bind_version`/`report_collection` across `models.py`/`gate.py`/`state_store.py`/`analysis.py` (getattr-tolerant) + a test run before HF |
 | 5 | Report generator → `objective`+`business_questions`, "generated by {user}", formal outline | Sofhia | ✅ | Goal-shape (KM-674) + author name (#19) + outline (KM-680): Objective → Business Questions → Executive Summary → Key Findings → EDA → Notes & Limitations → How This Was Analyzed |
 | 6 | Report skill input contract: `analysis_id` + `user_id` (no `chat_history`) | Sofhia/Rifqi | ✅ | No-op: `POST /report` already takes only analysis_id + user_id (records-based). Documented in API_ENDPOINTS.md §5. *(Edit-mode input revisited in #24.)* |
 | 7 | `report_id` state update via request to Go, not direct DB | Sofhia + Harry | ⬜ | Needs Go endpoint. **Checkpoint:** Go owns ALL `reports` writes; Python stops any direct insert/update and only returns content; report stays a **skill** (no intent). See #18 |
@@ -134,7 +134,7 @@ Status legend: ⬜ not started · 🔄 in progress · ✅ done · ⛔ blocked ·
 | 22 | Finalize `agent_observability` schema → hand to Harry for the dedorch migration/startup | Rifqi → Harry | ⬜ new | Resolves #16 (table created post-cutover). Python still creates it locally until then |
 | 23 | Report markdown formatting: tables, **bold**, *italic*, horizontal separators | Sofhia | ✅ | Done 2026-06-25. Added `---` separators between header + each section in `_render_markdown`. Tables (EDA) / bold (method labels) / italic (meta + citations) already emitted. Relaxed `report_summary.md` to allow inline `**bold**`/`*italic*` for emphasis (kept no-headings/no-bullets so it doesn't duplicate the section structure / Key Findings). Compile + ruff clean |
 | 24 | Clarify report input contract: records table (+ `last_report` for edit mode?) | Rifqi/Sofhia ↔ Harry | ⬜ new | Edit-mode input left open at the checkpoint |
-| 25 | Confirm Python history source = Go `analysis_message` | Rifqi ↔ Harry | ⬜ new | New chat-room table (Q + A); replaces `chat_messages` for analyses |
+| 25 | Migrate Python chat path to Go `analyses_messages` (+ `analyses`) | Rifqi ↔ Harry | ⬜ | **Bigger than "confirm" (verified 2026-06-25):** dedorch `rooms` + `chat_messages` are **deprecated** (`zdeprecated_*`). Python's `Room`/`ChatMessage` models + `chat.py` `load_history`/`save_messages` target them → **break post-cutover**. Move history read/write to `analyses_messages` before the conn-string cutover |
 | 26 | **Charts (DEFERRED):** store Plotly JSON in a future `chart` table (not matplotlib PNG) | — | ⏸️ | After the markdown path is done end-to-end |
 | 27 | **Images (DEFERRED):** image table (id, analysis_id, msg/report ref, order) + originals in a bucket | — | ⏸️ | Maintenance-heavy; parked |
 | 28 | **UI research** (FE): new-analysis form, knowledge menu (user vs analysis level), report artifacts + version selector | Team | ⬜ new | No dedicated UI person; interview + old analysis UI removed |
@@ -142,8 +142,8 @@ Status legend: ⬜ not started · 🔄 in progress · ✅ done · ⛔ blocked ·
 ## 5. Critical path & sequencing
 
 - **Critical path:** #3 → #4 (de-risked by getattr tolerance). #21 → #22 (rename + hand schema to Harry). HF deploy (#13) for the playground.
-- **Parallelizable now (no blockers):** #11, #21, #23.
-- **Harry-blocked:** #3 (blocks #4), #7 (Go endpoint), #18 (Go state ownership), #24/#25 (contracts).
+- **Parallelizable now:** #11, #21. #4 in progress (tablename done; columns + readers next).
+- **Harry-blocked / coordinated:** #3 (now 🔄, blocks #4), #7 (Go endpoint), #18 (Go state ownership), #24 (contract). **#25 = chat-path migration to `analyses_messages` — a cutover blocker.**
 - **Demo gate (playground, #13):** deploy the remove-`problem_statement` work to HF — slow path (#15 ✅)
   and the report path are verified locally, and #16 is resolved (#22 hands Harry the schema). **Keep it
   playground-able.**

src/db/postgres/models.py

@@ -138,8 +138,15 @@ class AnalysisRecordRow(Base):
 
     `analysis_id` is nullable until the Analysis State (owned upstream) is wired
     into the slow path; records still persist (and carry `user_id`) before then.
+
+    OWNERSHIP / HANDOFF (2026-06-25 checkpoint): **Python-owned for now**, but to be
+    **renamed `agent_observability`** (task #21 — Harry doesn't want "record" in the name;
+    it clashes with Go's `analyses_messages`) with the finalized schema handed to Harry so
+    the dedorch migration creates it (task #22). Slated to **migrate to Go ownership later** —
+    keep this docstring + DEV_PLAN #21/#22 as the handoff record. NOTE: `analysis_records`
+    already exists (empty) in dedorch with this exact shape.
     """
-    __tablename__ = "analysis_records"
+    __tablename__ = "analysis_records"  # → rename to `agent_observability` (#21)
 
     id = Column(String, primary_key=True)  # AnalysisRecord.record_id
     analysis_id = Column(String, index=True)  # FK to the analysis session (nullable for now)
@@ -169,16 +176,26 @@ class AnalysisReportRow(Base):
 
 
 class AnalysisStateRow(Base):
-    """Per-analysis session state — the dedorch `analysis` table (Go-owned migration).
+    """Per-analysis session state — the dedorch **`analyses`** table (plural; Go-owned).
 
     One session = one analysis = one conversation; `id` is the shared session id
-    (canonical UUID). The orchestrator gate + Help skill read this every turn;
-    `problem_validated` gates structured analysis; the Problem Statement skill flips
-    it; `report_id` is null until a report exists. `id`/`report_id` are Postgres
-    `uuid` in dedorch, so they bind as UUID (canonical-string in/out). Class name
-    kept as `AnalysisStateRow`; only the table + id types changed for dedorch.
+    (canonical UUID). Verified against the dedorch DB 2026-06-25.
+
+    dedorch `analyses` ACTUAL columns: `id` (uuid), `analysis_title`, `user_id` (text),
+    `report_id` (uuid), `created_at`, `updated_at`, `problem_statement`,
+    `problem_validated`, `status` (text 'active'|'inactive' — soft-delete),
+    `data_bind` (jsonb), `data_bind_version` (int), `report_collection` (jsonb).
+
+    ⚠️ This model is NOT yet column-reconciled to that shape (task #4): it still declares
+    `owner_id` (dedorch uses `user_id`) and omits `status`/`data_bind`/`data_bind_version`/
+    `report_collection`. dedorch still carries `problem_statement`/`problem_validated` and
+    does NOT yet have `objective`/`business_questions` — Harry's #3 drops the former + adds
+    the latter. Readers are getattr-tolerant so the eventual swap stays non-breaking.
+
+    `analysis` (singular) is the deprecated DUPLICATE table Harry will drop — never use it.
+    Class name kept as `AnalysisStateRow`.
     """
-    __tablename__ = "analysis"
+    __tablename__ = "analyses"
 
     id = Column(UUID(as_uuid=False), primary_key=True)  # shared session id (uuid)
     analysis_title = Column(String, nullable=False, default="New analysis")