Spaces:
Running
Running
File size: 13,223 Bytes
016b413 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 |
"""Unit tests for ProofreaderAgent."""
from typing import Any
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from pydantic_ai import AgentRunResult
from src.agents.proofreader import ProofreaderAgent, create_proofreader_agent
from src.utils.models import ReportDraft, ReportDraftSection
@pytest.fixture
def mock_model() -> MagicMock:
"""Create a mock Pydantic AI model."""
model = MagicMock()
model.name = "test-model"
return model
@pytest.fixture
def mock_agent_result() -> AgentRunResult[Any]:
"""Create a mock agent result."""
result = MagicMock(spec=AgentRunResult)
result.output = """# Final Report
## Summary
This is a polished report.
## Introduction
Introduction content.
## References:
[1] https://example.com
"""
return result
@pytest.fixture
def proofreader_agent(mock_model: MagicMock) -> ProofreaderAgent:
"""Create a ProofreaderAgent instance with mocked model."""
return ProofreaderAgent(model=mock_model)
@pytest.fixture
def sample_report_draft() -> ReportDraft:
"""Create a sample ReportDraft for testing."""
return ReportDraft(
sections=[
ReportDraftSection(
section_title="Introduction",
section_content="Introduction content with [1].",
),
ReportDraftSection(
section_title="Methods",
section_content="Methods content with [2].",
),
]
)
class TestProofreaderAgentInit:
"""Test ProofreaderAgent initialization."""
def test_proofreader_agent_init_with_model(self, mock_model: MagicMock) -> None:
"""Test ProofreaderAgent initialization with provided model."""
agent = ProofreaderAgent(model=mock_model)
assert agent.model == mock_model
assert agent.agent is not None
@patch("src.agents.proofreader.get_model")
def test_proofreader_agent_init_without_model(
self, mock_get_model: MagicMock, mock_model: MagicMock
) -> None:
"""Test ProofreaderAgent initialization without model (uses default)."""
mock_get_model.return_value = mock_model
agent = ProofreaderAgent()
assert agent.model == mock_model
mock_get_model.assert_called_once()
def test_proofreader_agent_has_correct_system_prompt(
self, proofreader_agent: ProofreaderAgent
) -> None:
"""Test that ProofreaderAgent has correct system prompt."""
# System prompt should exist and contain key instructions
# Check the source constant directly since system_prompt property may be a callable
from src.agents.proofreader import SYSTEM_PROMPT
assert SYSTEM_PROMPT is not None
assert "proofread" in SYSTEM_PROMPT.lower()
assert "report" in SYSTEM_PROMPT.lower()
class TestProofread:
"""Test proofread() method."""
@pytest.mark.asyncio
async def test_proofread_basic(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
sample_report_draft: ReportDraft,
) -> None:
"""Test basic proofreading."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
query = "Test query"
result = await proofreader_agent.proofread(query=query, report_draft=sample_report_draft)
assert isinstance(result, str)
assert "Final Report" in result or "Introduction" in result
assert proofreader_agent.agent.run.called
@pytest.mark.asyncio
async def test_proofread_single_section(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
) -> None:
"""Test proofreading with single section."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
report_draft = ReportDraft(
sections=[
ReportDraftSection(
section_title="Single Section",
section_content="Content",
)
]
)
result = await proofreader_agent.proofread(query="Test", report_draft=report_draft)
assert isinstance(result, str)
assert proofreader_agent.agent.run.called
@pytest.mark.asyncio
async def test_proofread_multiple_sections(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
sample_report_draft: ReportDraft,
) -> None:
"""Test proofreading with multiple sections."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
result = await proofreader_agent.proofread(query="Test", report_draft=sample_report_draft)
assert isinstance(result, str)
# Check that draft was included in prompt
call_args = proofreader_agent.agent.run.call_args[0][0]
assert "Introduction" in call_args or "Methods" in call_args
@pytest.mark.asyncio
async def test_proofread_removes_duplicates(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
) -> None:
"""Test that proofreader removes duplicate content."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
report_draft = ReportDraft(
sections=[
ReportDraftSection(
section_title="Section 1",
section_content="Duplicate content",
),
ReportDraftSection(
section_title="Section 2",
section_content="Duplicate content", # Duplicate
),
]
)
result = await proofreader_agent.proofread(query="Test", report_draft=report_draft)
assert isinstance(result, str)
# System prompt should instruct to remove duplicates
call_args = proofreader_agent.agent.run.call_args[0][0]
assert "duplicate" in call_args.lower() or "De-duplicate" in call_args
@pytest.mark.asyncio
async def test_proofread_adds_summary(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
sample_report_draft: ReportDraft,
) -> None:
"""Test that proofreader adds summary."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
result = await proofreader_agent.proofread(query="Test", report_draft=sample_report_draft)
assert isinstance(result, str)
# System prompt should instruct to add summary - check source constant
from src.agents.proofreader import SYSTEM_PROMPT
assert "summary" in SYSTEM_PROMPT.lower() or "Add a summary" in SYSTEM_PROMPT
@pytest.mark.asyncio
async def test_proofread_preserves_references(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
sample_report_draft: ReportDraft,
) -> None:
"""Test that proofreader preserves references."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
result = await proofreader_agent.proofread(query="Test", report_draft=sample_report_draft)
assert isinstance(result, str)
# System prompt should instruct to preserve sources - check source constant
from src.agents.proofreader import SYSTEM_PROMPT
assert (
"sources" in SYSTEM_PROMPT.lower()
or "references" in SYSTEM_PROMPT.lower()
or "Preserve sources" in SYSTEM_PROMPT
)
@pytest.mark.asyncio
async def test_proofread_empty_draft(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
) -> None:
"""Test proofreading with empty draft."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
report_draft = ReportDraft(sections=[])
result = await proofreader_agent.proofread(query="Test", report_draft=report_draft)
assert isinstance(result, str)
# When draft is empty, agent returns early without calling run
assert "Research Report" in result
assert "Query" in result
# Agent.run should not be called for empty drafts (early return)
assert not proofreader_agent.agent.run.called
@pytest.mark.asyncio
async def test_proofread_single_section_draft(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
) -> None:
"""Test proofreading with single section draft."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
report_draft = ReportDraft(
sections=[
ReportDraftSection(
section_title="Single Section",
section_content="Content",
)
]
)
result = await proofreader_agent.proofread(query="Test", report_draft=report_draft)
assert isinstance(result, str)
@pytest.mark.asyncio
async def test_proofread_very_long_draft(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
) -> None:
"""Test proofreading with very long draft."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
report_draft = ReportDraft(
sections=[
ReportDraftSection(
section_title="Long Section",
section_content="Content. " * 1000, # Very long
)
]
)
result = await proofreader_agent.proofread(query="Test", report_draft=report_draft)
assert isinstance(result, str)
assert proofreader_agent.agent.run.called
@pytest.mark.asyncio
async def test_proofread_malformed_sections(
self,
proofreader_agent: ProofreaderAgent,
mock_agent_result: AgentRunResult[Any],
) -> None:
"""Test proofreading with malformed sections."""
proofreader_agent.agent.run = AsyncMock(return_value=mock_agent_result)
report_draft = ReportDraft(
sections=[
ReportDraftSection(
section_title="",
section_content="", # Empty section
)
]
)
result = await proofreader_agent.proofread(query="Test", report_draft=report_draft)
assert isinstance(result, str)
@pytest.mark.asyncio
async def test_proofread_llm_failure(
self, proofreader_agent: ProofreaderAgent, sample_report_draft: ReportDraft
) -> None:
"""Test proofreading handles LLM failures gracefully."""
proofreader_agent.agent.run = AsyncMock(side_effect=Exception("LLM error"))
result = await proofreader_agent.proofread(query="Test", report_draft=sample_report_draft)
# Should return fallback report
assert isinstance(result, str)
assert "Research Report" in result
assert "Introduction" in result
@pytest.mark.asyncio
async def test_proofread_returns_fallback_on_error(
self, proofreader_agent: ProofreaderAgent, sample_report_draft: ReportDraft
) -> None:
"""Test that fallback report is returned on error."""
proofreader_agent.agent.run = AsyncMock(side_effect=RuntimeError("Test error"))
result = await proofreader_agent.proofread(query="Test", report_draft=sample_report_draft)
assert isinstance(result, str)
# Fallback should combine sections manually
assert sample_report_draft.sections[0].section_title in result
class TestCreateProofreaderAgent:
"""Test create_proofreader_agent factory function."""
@patch("src.agents.proofreader.get_model")
@patch("src.agents.proofreader.ProofreaderAgent")
def test_create_proofreader_agent_success(
self,
mock_proofreader_agent_class: MagicMock,
mock_get_model: MagicMock,
mock_model: MagicMock,
) -> None:
"""Test successful proofreader agent creation."""
mock_get_model.return_value = mock_model
mock_agent_instance = MagicMock()
mock_proofreader_agent_class.return_value = mock_agent_instance
result = create_proofreader_agent()
assert result == mock_agent_instance
mock_proofreader_agent_class.assert_called_once_with(model=mock_model)
@patch("src.agents.proofreader.get_model")
@patch("src.agents.proofreader.ProofreaderAgent")
def test_create_proofreader_agent_with_custom_model(
self,
mock_proofreader_agent_class: MagicMock,
mock_get_model: MagicMock,
mock_model: MagicMock,
) -> None:
"""Test proofreader agent creation with custom model."""
mock_agent_instance = MagicMock()
mock_proofreader_agent_class.return_value = mock_agent_instance
result = create_proofreader_agent(model=mock_model)
assert result == mock_agent_instance
mock_proofreader_agent_class.assert_called_once_with(model=mock_model)
mock_get_model.assert_not_called()
|