Update app.py

app.py

@@ -84,69 +84,78 @@ if role == "Quiz Creator":
             requests.put(url, json={"questions": questions})
             st.success(f"Đã lưu quiz '{quiz_name}' với 10 câu hỏi!")
 
-# ==========================
-# STUDENT EVALUATION
-# ==========================
-if role == "Student Evaluation":
-    st.subheader("Bảng đánh giá học sinh")
+# ================================
+# STUDENT EVALUATION (UPDATED)
+# ================================
+elif choice == "Student Evaluation":
+    st.header("Student Evaluation & Feedback")
+
+    # Nút Refresh
+    if st.button("🔄 Refresh Data"):
+        st.cache_data.clear()
+        st.rerun()
+
+    # Lấy danh sách toàn bộ student
+    students = fetch_data(FIREBASE_URL + "/Students.json")
+    if not students:
+        st.warning("No student data found!")
+        st.stop()
 
-    # Lấy all student quizzes
-    res = requests.get(f"{FIREBASE_URL}/student_quizzes.json?auth={FIREBASE_AUTH}")
-    students = res.json() if res.status_code == 200 else {}
+    student_ids = list(students.keys())
+    selected_id = st.selectbox("Select Student ID", student_ids)
+
+    student_info = students[selected_id]
+
+    st.subheader("Student Information")
+    st.write(f"**Name:** {student_info.get('Name','')}")
+    st.write(f"**Class:** {student_info.get('Class','')}")
+
+    # Lấy danh sách Quiz của student (Quiz1, Quiz2, ...)
+    quiz_keys = [k for k in student_info.keys() if k.startswith("Quiz")]
+
+    if not quiz_keys:
+        st.info("Student has no quiz data yet.")
+        st.stop()
+
+    # Chuẩn bị bảng hiển thị
+    table_rows = []
+    for q in quiz_keys:
+        qdata = student_info[q]
+
+        score   = qdata.get("Score", "")
+        time    = qdata.get("Time", "")
+        fb_text = qdata.get("Feedback", "")
+        fb_flag = "Yes" if fb_text else "No"
+
+        table_rows.append({
+            "Quiz": q,
+            "Score": score,
+            "Time": time,
+            "Feedbacked": fb_flag
+        })
+
+    st.subheader("Quiz Overview")
+    st.table(table_rows)
+
+    # -------- Feedback Section --------
+    st.subheader("Give Feedback")
+
+    selected_quiz = st.selectbox("Select quiz for feedback", quiz_keys)
+
+    # Nếu quiz đã có Feedback -> hiển thị
+    existing_fb = student_info[selected_quiz].get("Feedback", "")
+    if existing_fb:
+        st.info(f"Existing feedback for **{selected_quiz}**:\n\n{existing_fb}")
+
+    feedback_text = st.text_area("Enter new feedback")
+
+    if st.button("Submit Feedback"):
+        update_path = f"/Students/{selected_id}/{selected_quiz}/Feedback.json"
+        result = update_data(FIREBASE_URL + update_path, feedback_text)
+
+        if result is not None:
+            st.success(f"Feedback saved for {selected_quiz}!")
+            st.rerun()
+        else:
+            st.error("Failed to save feedback.")
 
-    if not students:
-        st.info("Chưa có học sinh nào.")
-    else:
-        rows = []
-
-        # ==========================
-        # TẠO BẢNG DATAFRAME
-        # ==========================
-        for student_id, data in students.items():
-            name = data.get("Name", "")
-            class_ = data.get("Class", "")
-
-            for key, quiz_data in data.items():
-                if key.startswith("Quiz"):
-                    # Xử lý dữ liệu cũ dạng string
-                    if isinstance(quiz_data, str):
-                        quiz_data = {"Score": quiz_data, "Time": ""}
-
-                    score = quiz_data.get("Score", "")
-                    time = quiz_data.get("Time", "")
-
-                    rows.append({
-                        "ID": student_id,
-                        "Name": name,
-                        "Class": class_,
-                        "Quiz": key,
-                        "Score": score,
-                        "Time": time
-                    })
-
-        df = pd.DataFrame(rows)
-        st.subheader("Danh sách học sinh và quiz")
-        st.dataframe(df)
-
-        # ==========================
-        # NHẬP FEEDBACK
-        # ==========================
-        st.subheader("Nhập Feedback cho từng quiz")
-
-        for student_id, data in students.items():
-            for key, quiz_data in data.items():
-                if key.startswith("Quiz"):
-
-                    # Chuyển dữ liệu cũ
-                    if isinstance(quiz_data, str):
-                        quiz_data = {"Score": quiz_data, "Time": ""}
-
-                    st.markdown(f"**ID: {student_id} - {data.get('Name','')} - {key}**")
-
-                    existing_fb = quiz_data.get("feedback", "")
-                    feedback = st.text_area("Feedback", value=existing_fb, key=f"fb_{student_id}_{key}")
-
-                    if st.button(f"Gửi Feedback cho {student_id} - {key}", key=f"submit_fb_{student_id}_{key}"):
-                        url_fb = f"{FIREBASE_URL}/student_quizzes/{student_id}/{key}/feedback.json?auth={FIREBASE_AUTH}"
-                        requests.put(url_fb, json=feedback)
-                        st.success(f"Đã gửi feedback cho {student_id} - {key}")