Update app.py

app.py

@@ -5,6 +5,7 @@ from reportlab.pdfgen import canvas
 import bleach
 import logging
 import os
+import tempfile
 from huggingface_hub import InferenceClient
 from retry import retry
 import time
@@ -275,63 +276,59 @@ def generate_pdf(score, checklist_summary, missing_summary, checklist_status, lo
         qa_report = sanitize_input(qa_report) if qa_report else "No QA report provided"
         punch_list_text = sanitize_input(punch_list_text) if punch_list_text else "No punch list provided"
 
-        # Define the temporary file path
-        pdf_path = "readiness_report.pdf"
+        # Use a temporary directory for PDF generation
+        with tempfile.NamedTemporaryFile(suffix=".pdf", delete=False, dir="/tmp") as temp_file:
+            pdf_path = temp_file.name
         logging.info(f"Attempting to create PDF at {pdf_path}")
 
-        # Ensure the directory is writable
-        pdf_dir = os.path.dirname(pdf_path) or "."
-        if not os.access(pdf_dir, os.W_OK):
-            logging.error(f"No write permissions in directory: {pdf_dir}")
-            raise PermissionError(f"No write permissions in directory: {pdf_dir}")
-
         # Create the PDF using reportlab
         c = canvas.Canvas(pdf_path, pagesize=letter)
-        
+
         # Set initial font and draw title
-        logging.info("Setting font to Times-Bold for title")
+        logging.info("Setting font to Helvetica-Bold for title (fallback)")
         try:
-            c.setFont("Times-Bold", 16)
+            c.setFont("Helvetica-Bold", 16)
         except Exception as e:
-            logging.error(f"Font error: {str(e)}. Falling back to default font.")
-            c.setFont("Helvetica-Bold", 16)  # Fallback font
+            logging.error(f"Font error: {str(e)}. Using default font.")
+            c.setFont("Helvetica", 16)
         c.drawString(50, 750, "Project Closure Readiness Report")
-        
+
         # Draw basic fields
-        logging.info("Drawing basic fields")
+        logging.info("Drawing basic fields with Helvetica")
         try:
-            c.setFont("Times-Roman", 12)
+            c.setFont("Helvetica", 12)
         except Exception as e:
-            logging.error(f"Font error: {str(e)}. Falling back to default font.")
-            c.setFont("Helvetica", 12)  # Fallback font
+            logging.error(f"Font error: {str(e)}. Continuing with default font.")
         c.drawString(50, 720, f"Readiness Score: {score}%")
         c.drawString(50, 700, f"Status: {checklist_status}")
-        c.drawString(50, 680, "Checklist Summary:")
 
-        # Draw checklist summary with Y-position overflow handling
+        # Draw checklist summary
         logging.info("Drawing checklist summary")
-        y = 660
-        BOTTOM_MARGIN = 50
+        y = 680
         LINE_HEIGHT = 20
+        BOTTOM_MARGIN = 50
+        c.drawString(50, y, "Checklist Summary:")
+        y -= LINE_HEIGHT
+
         lines = checklist_summary.split("\n")
-        if not lines:
+        if not lines or lines == [""]:
             lines = ["No checklist summary available"]
         for line in lines:
             # Truncate long lines to prevent overflow
-            if len(line) > 80:  # Approximate character limit per line
+            if len(line) > 80:
                 line = line[:77] + "..."
             if y < BOTTOM_MARGIN:
                 logging.info("Y position below margin, creating new page")
                 c.showPage()
                 try:
-                    c.setFont("Times-Roman", 12)
-                except:
                     c.setFont("Helvetica", 12)
+                except:
+                    pass
                 y = 750
             c.drawString(50, y, line)
             y -= LINE_HEIGHT
 
-        # Draw additional sections
+        # Draw missing summary
         logging.info("Drawing missing summary")
         y -= 20
         c.drawString(50, y, "Missing Items:")
@@ -343,9 +340,9 @@ def generate_pdf(score, checklist_summary, missing_summary, checklist_status, lo
             if y < BOTTOM_MARGIN:
                 c.showPage()
                 try:
-                    c.setFont("Times-Roman", 12)
-                except:
                     c.setFont("Helvetica", 12)
+                except:
+                    pass
                 y = 750
             c.drawString(50, y, line)
             y -= LINE_HEIGHT
@@ -354,23 +351,21 @@ def generate_pdf(score, checklist_summary, missing_summary, checklist_status, lo
         logging.info("Drawing signature slots")
         y -= 20
         if y - 40 < BOTTOM_MARGIN:
-            logging.info("Y position below margin, creating new page")
             c.showPage()
             try:
-                c.setFont("Times-Roman", 12)
-            except:
                 c.setFont("Helvetica", 12)
+            except:
+                pass
             y = 750
         c.drawString(50, y - 20, "Stakeholder Signature: ____________________")
 
         y -= 20
         if y - 60 < BOTTOM_MARGIN:
-            logging.info("Y position below margin, creating new page")
             c.showPage()
             try:
-                c.setFont("Times-Roman", 12)
-            except:
                 c.setFont("Helvetica", 12)
+            except:
+                pass
             y = 750
         c.drawString(50, y - 40, "Date: ____________________")
 
@@ -388,7 +383,7 @@ def generate_pdf(score, checklist_summary, missing_summary, checklist_status, lo
         logging.info(f"Simulated public URL for PDF: {simulated_public_url}")
 
         logging.info(f"PDF generated successfully at {pdf_path}")
-        return simulated_public_url, "PDF generation completed. Click the link to download."
+        return simulated_public_url, f"PDF generation completed. File saved at {pdf_path}. Click the link to download."
     except Exception as e:
         logging.error(f"Error in generate_pdf: {str(e)}")
         raise