Spaces:
Sleeping
Sleeping
File size: 25,250 Bytes
a3934b1 7bbd836 a3934b1 7bbd836 a3934b1 7bbd836 a3934b1 7bbd836 a3934b1 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 |
# test_feedback_handler.py
"""
Tests for verification feedback handler.
Tests feedback collection, validation, and storage functionality.
"""
import pytest
from datetime import datetime
from src.core.verification_feedback_handler import (
VerificationFeedbackHandler,
FeedbackValidationError,
)
from src.core.verification_models import (
VerificationRecord,
VerificationSession,
TestMessage,
)
from src.core.verification_store import JSONVerificationStore
from src.core.message_queue_manager import MessageQueueManager
class TestCorrectFeedbackHandling:
"""Tests for handling 'Correct' feedback."""
def test_handle_correct_feedback_saves_record(
self, sample_verification_session, temp_storage_dir
):
"""Verify correct feedback saves verification record."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="I'm feeling anxious",
pre_classified_label="yellow",
),
TestMessage(
message_id="msg_002",
text="I'm feeling great",
pre_classified_label="green",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Handle correct feedback
result = handler.handle_correct_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
)
assert result is True
# Verify record was saved
loaded_session = store.load_session(sample_verification_session.session_id)
assert len(loaded_session.verifications) == 1
assert loaded_session.verifications[0].message_id == "msg_001"
assert loaded_session.verifications[0].is_correct is True
def test_handle_correct_feedback_marks_as_correct(
self, sample_verification_session, temp_storage_dir
):
"""Verify correct feedback marks record as correct."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="I'm feeling anxious",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
handler.handle_correct_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
)
loaded_session = store.load_session(sample_verification_session.session_id)
record = loaded_session.verifications[0]
assert record.is_correct is True
assert record.ground_truth_label == "yellow"
assert record.classifier_decision == "yellow"
def test_handle_correct_feedback_advances_queue(
self, sample_verification_session, temp_storage_dir
):
"""Verify correct feedback advances to next message."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="First message",
pre_classified_label="yellow",
),
TestMessage(
message_id="msg_002",
text="Second message",
pre_classified_label="green",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Initially at first message
assert queue_manager.get_current_message_id() == "msg_001"
# Handle correct feedback
handler.handle_correct_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
)
# Should advance to second message
assert queue_manager.get_current_message_id() == "msg_002"
def test_handle_correct_feedback_stores_all_fields(
self, sample_verification_session, temp_storage_dir
):
"""Verify correct feedback stores all required fields."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Test message",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
handler.handle_correct_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.92,
classifier_indicators=["anxiety", "stress"],
)
loaded_session = store.load_session(sample_verification_session.session_id)
record = loaded_session.verifications[0]
assert record.message_id == "msg_001"
assert record.original_message == "Test message"
assert record.classifier_decision == "yellow"
assert record.classifier_confidence == 0.92
assert record.classifier_indicators == ["anxiety", "stress"]
assert record.ground_truth_label == "yellow"
assert record.verifier_notes == ""
assert record.is_correct is True
assert isinstance(record.timestamp, datetime)
class TestIncorrectFeedbackHandling:
"""Tests for handling 'Incorrect' feedback."""
def test_handle_incorrect_feedback_saves_record(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback saves verification record."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="I'm feeling anxious",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Handle incorrect feedback
result = handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label="red",
verifier_notes="Missed severe indicators",
)
assert result is True
# Verify record was saved
loaded_session = store.load_session(sample_verification_session.session_id)
assert len(loaded_session.verifications) == 1
assert loaded_session.verifications[0].message_id == "msg_001"
assert loaded_session.verifications[0].is_correct is False
def test_handle_incorrect_feedback_marks_as_incorrect(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback marks record as incorrect."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="I'm feeling anxious",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label="red",
verifier_notes="",
)
loaded_session = store.load_session(sample_verification_session.session_id)
record = loaded_session.verifications[0]
assert record.is_correct is False
assert record.ground_truth_label == "red"
assert record.classifier_decision == "yellow"
def test_handle_incorrect_feedback_stores_notes(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback stores optional notes."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Test message",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
notes = "Missed severe distress indicators"
handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label="red",
verifier_notes=notes,
)
loaded_session = store.load_session(sample_verification_session.session_id)
record = loaded_session.verifications[0]
assert record.verifier_notes == notes
def test_handle_incorrect_feedback_advances_queue(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback advances to next message."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="First message",
pre_classified_label="yellow",
),
TestMessage(
message_id="msg_002",
text="Second message",
pre_classified_label="green",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Initially at first message
assert queue_manager.get_current_message_id() == "msg_001"
# Handle incorrect feedback
handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label="red",
verifier_notes="",
)
# Should advance to second message
assert queue_manager.get_current_message_id() == "msg_002"
def test_handle_incorrect_feedback_requires_correction(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback requires correction selection."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Test message",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Try to handle incorrect feedback without correction
with pytest.raises(FeedbackValidationError) as exc_info:
handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label="",
verifier_notes="",
)
assert "Please select a correction" in str(exc_info.value)
def test_handle_incorrect_feedback_validates_correction_option(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback validates correction is valid option."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Test message",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Try to handle incorrect feedback with invalid correction
with pytest.raises(FeedbackValidationError) as exc_info:
handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label="invalid",
verifier_notes="",
)
assert "Invalid correction option" in str(exc_info.value)
def test_handle_incorrect_feedback_accepts_all_valid_corrections(
self, sample_verification_session, temp_storage_dir
):
"""Verify incorrect feedback accepts all valid correction options."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
# Test each correction option with a different classifier decision
# to ensure the correction is actually different from the classifier's decision
test_cases = [
("green", "yellow"), # classifier says yellow, correction is green
("yellow", "red"), # classifier says red, correction is yellow
("red", "green"), # classifier says green, correction is red
]
for correction, classifier_decision in test_cases:
session = VerificationSession(
session_id=f"session_{correction}",
verifier_name="Test Verifier",
dataset_id="dataset_001",
dataset_name="Test Dataset",
)
store.save_session(session)
queue_manager = MessageQueueManager(session)
messages = [
TestMessage(
message_id=f"msg_{correction}",
text="Test message",
pre_classified_label=classifier_decision,
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(session, store, queue_manager)
# Should not raise exception - correction is different from classifier decision
result = handler.handle_incorrect_feedback(
message=messages[0],
classifier_decision=classifier_decision,
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
ground_truth_label=correction,
verifier_notes="",
)
assert result is True
class TestFeedbackValidation:
"""Tests for feedback validation."""
def test_validate_feedback_input_correct_is_valid(
self, sample_verification_session, temp_storage_dir
):
"""Verify validation passes for correct feedback."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
is_valid, error_msg = handler.validate_feedback_input(is_correct=True)
assert is_valid is True
assert error_msg is None
def test_validate_feedback_input_incorrect_requires_correction(
self, sample_verification_session, temp_storage_dir
):
"""Verify validation fails for incorrect without correction."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
is_valid, error_msg = handler.validate_feedback_input(
is_correct=False, ground_truth_label=""
)
assert is_valid is False
assert "Correction Required" in error_msg or "select" in error_msg.lower()
def test_validate_feedback_input_incorrect_with_valid_correction(
self, sample_verification_session, temp_storage_dir
):
"""Verify validation passes for incorrect with valid correction."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
is_valid, error_msg = handler.validate_feedback_input(
is_correct=False, ground_truth_label="red"
)
assert is_valid is True
assert error_msg is None
def test_validate_notes_field_accepts_empty_notes(
self, sample_verification_session, temp_storage_dir
):
"""Verify validation accepts empty notes."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
is_valid, error_msg = handler.validate_notes_field("")
assert is_valid is True
assert error_msg is None
def test_validate_notes_field_accepts_valid_notes(
self, sample_verification_session, temp_storage_dir
):
"""Verify validation accepts valid notes."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
notes = "This is a valid note explaining the correction"
is_valid, error_msg = handler.validate_notes_field(notes)
assert is_valid is True
assert error_msg is None
def test_validate_notes_field_rejects_excessive_length(
self, sample_verification_session, temp_storage_dir
):
"""Verify validation rejects notes exceeding 500 characters."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
notes = "x" * 501
is_valid, error_msg = handler.validate_notes_field(notes)
assert is_valid is False
assert "500 characters" in error_msg
class TestSessionStatistics:
"""Tests for session statistics retrieval."""
def test_get_session_statistics_after_feedback(
self, sample_verification_session, temp_storage_dir
):
"""Verify session statistics are updated after feedback."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Message 1",
pre_classified_label="yellow",
),
TestMessage(
message_id="msg_002",
text="Message 2",
pre_classified_label="green",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Add correct feedback
handler.handle_correct_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
)
stats = handler.get_session_statistics()
assert stats["verified_count"] == 1
assert stats["correct_count"] == 1
assert stats["incorrect_count"] == 0
def test_is_session_complete_false_when_messages_remain(
self, sample_verification_session, temp_storage_dir
):
"""Verify session is not complete when messages remain."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Message 1",
pre_classified_label="yellow",
),
TestMessage(
message_id="msg_002",
text="Message 2",
pre_classified_label="green",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
assert handler.is_session_complete() is False
def test_is_session_complete_true_when_all_verified(
self, sample_verification_session, temp_storage_dir
):
"""Verify session is complete when all messages verified."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Message 1",
pre_classified_label="yellow",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
# Verify the only message
handler.handle_correct_feedback(
message=messages[0],
classifier_decision="yellow",
classifier_confidence=0.85,
classifier_indicators=["anxiety"],
)
assert handler.is_session_complete() is True
def test_get_queue_position(
self, sample_verification_session, temp_storage_dir
):
"""Verify queue position is returned correctly."""
store = JSONVerificationStore(storage_dir=temp_storage_dir)
store.save_session(sample_verification_session)
queue_manager = MessageQueueManager(sample_verification_session)
messages = [
TestMessage(
message_id="msg_001",
text="Message 1",
pre_classified_label="yellow",
),
TestMessage(
message_id="msg_002",
text="Message 2",
pre_classified_label="green",
),
TestMessage(
message_id="msg_003",
text="Message 3",
pre_classified_label="red",
),
]
queue_manager.initialize_queue(messages)
handler = VerificationFeedbackHandler(
sample_verification_session, store, queue_manager
)
current_pos, total = handler.get_queue_position()
assert current_pos == 1
assert total == 3
|