fix: Or feedback — Provider Summary flag error, stale verification on clear, latency timing

#1 Conversation Verification "Error" badge on every component when saving the
final Provider Summary with text only: the handlers returned "" for the
correct-classification Radio, which Gradio 6 rejects (value not in choices),
failing the whole event response. Replace "" with None across all conv
verification handlers (via new _classification_update helper) and hide the flag
on the PROVIDER_SUMMARY final step, since the flag was already chosen earlier.
Also fixes a latent arity mismatch in the empty-records early returns.

#2 "Clear Chat" left the Conversation Verification tab showing the previous
scenario. handle_clear_simplified now also resets conv_verify_state/records/index
and the displayed components; clear_btn wiring updated (mirrored in gradio_app /
chat_handlers for local parity).

#3 Add lightweight per-stage [PERF] timing in the message path (PERF_TIMING env,
default on) to diagnose >10s responses. No model changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/interface/chat_handlers.py

@@ -172,7 +172,15 @@ def handle_clear(session: SimplifiedSessionData):
         gr.update(visible=False),  # Hide provider_summary_content group
         "No provider summary available",  # Clear provider_summary_status
         "",  # Clear provider_summary_display HTML
-        ""  # Clear coherent_summary_display - direct value
+        "",  # Clear coherent_summary_display - direct value
+        # Also reset the Conversation Verification tab (avoid stale scenario)
+        None,  # conv_verify_state
+        [],  # conv_verify_records
+        0,  # conv_verify_index
+        "",  # conv_verify_status
+        "",  # conv_verify_exchange
+        "",  # conv_position
+        "",  # conv_stats
     )
 
 def send_example(example_text: str, history, session: SimplifiedSessionData):

src/interface/gradio_app.py

@@ -582,7 +582,13 @@ def create_simplified_interface():
         clear_btn.click(
             chat_handlers.handle_clear,
             inputs=[session_data],
-            outputs=[chatbot, status_box, session_data, provider_summary_content, provider_summary_status, provider_summary_display, coherent_summary_display]
+            outputs=[
+                chatbot, status_box, session_data,
+                provider_summary_content, provider_summary_status, provider_summary_display, coherent_summary_display,
+                # Also reset the Conversation Verification tab (avoid stale scenario)
+                conv_verify_state, conv_verify_records, conv_verify_index,
+                conv_verify_status, conv_verify_exchange, conv_position, conv_stats,
+            ]
         )
         
         # Refresh status

src/interface/simplified_chat_handlers.py

@@ -9,9 +9,21 @@ show the Provider Summary message for the spiritual care team."
 
 import gradio as gr
 import html
+import os
+import time
 from src.interface.session_manager import SimplifiedSessionData
 from src.interface.stats_handlers import get_conversation_stats
 
+# Lightweight latency diagnosis. Prints per-stage timing to the server log (visible
+# in Hugging Face Spaces logs) so we can see where a >10s response is spent.
+# Enabled by default; set PERF_TIMING=false to silence. Overhead is negligible.
+_PERF_TIMING = os.getenv("PERF_TIMING", "true").lower() == "true"
+
+
+def _perf(label: str, start: float):
+    if _PERF_TIMING:
+        print(f"[PERF] {label}: {(time.perf_counter() - start) * 1000:.0f} ms")
+
 
 def handle_message_simplified(message: str, history, session: SimplifiedSessionData):
     """
@@ -25,7 +37,8 @@ def handle_message_simplified(message: str, history, session: SimplifiedSessionD
     """
     if session is None:
         session = SimplifiedSessionData()
-    
+
+    _t_handler = time.perf_counter()
     session.update_activity()
 
     # Apply per-session model overrides (if configured)
@@ -45,9 +58,11 @@ def handle_message_simplified(message: str, history, session: SimplifiedSessionD
     # Store previous spiritual state to detect transitions
     previous_state = session.app_instance.spiritual_state.spiritual_state
     
-    # Process message
+    # Process message (classification + assistant response — usually the bulk of latency)
+    _t_pm = time.perf_counter()
     new_history, status = session.app_instance.process_message(message, history)
-    
+    _perf("process_message", _t_pm)
+
     # Check if we just transitioned to RED state (consent was given)
     current_state = session.app_instance.spiritual_state.spiritual_state
     consent_just_given = (previous_state.value == "awaiting_consent" and 
@@ -61,8 +76,10 @@ def handle_message_simplified(message: str, history, session: SimplifiedSessionD
             # Get the COHERENT NARRATIVE summary (LLM-generated from spiritual_care_message.txt)
             # This is the Medical Brain compatible format, not the structured format
             try:
+                _t_cs = time.perf_counter()
                 provider_summary_text = session.app_instance.provider_summary_generator.format_coherent_paragraph(last_summary)
-                
+                _perf("format_coherent_paragraph (extra LLM call, one-time on RED+consent)", _t_cs)
+
                 if not provider_summary_text:
                     # Fallback to structured format if coherent generation fails
                     provider_summary_text = session.app_instance.provider_summary_generator.format_for_export(last_summary)
@@ -154,11 +171,13 @@ def handle_message_simplified(message: str, history, session: SimplifiedSessionD
     
     # Get updated conversation stats
     stats = get_conversation_stats(session)
-    
+
+    _perf("handle_message_simplified TOTAL", _t_handler)
+
     return (
-        new_history, 
-        status, 
-        session, 
+        new_history,
+        status,
+        session,
         "",  # Clear input
         stats
     )
@@ -167,22 +186,31 @@ def handle_message_simplified(message: str, history, session: SimplifiedSessionD
 def handle_clear_simplified(session: SimplifiedSessionData):
     """
     Handle clear chat button for simplified interface.
-    
+
     Resets entire session including:
     - Chat history
     - Spiritual monitoring state
     - Conversation statistics
+    - Conversation Verification tab (state + displayed components), so a new
+      scenario doesn't show the previous scenario's verification.
     """
     if session is None:
         session = SimplifiedSessionData()
-    
+
     session.update_activity()
     new_history, status = session.app_instance.reset_session()
-    
+
     return (
         new_history,  # Clear chat history
         status,  # Reset status
-        session  # Updated session
+        session,  # Updated session
+        None,  # conv_verify_state
+        [],  # conv_verify_records
+        0,  # conv_verify_index
+        "",  # conv_verify_status
+        "",  # conv_verify_exchange
+        "",  # conv_position
+        "",  # conv_stats
     )
 
 

src/interface/simplified_gradio_app.py

@@ -167,14 +167,14 @@ def create_simplified_interface():
                 # Shown only when marking Incorrect
                 with gr.Row(visible=False) as conv_incorrect_comment_row:
                     with gr.Column(scale=3):
-                        gr.Markdown("### Select Correct Classification:")
+                        # Hidden on the Provider Summary final step (flag already chosen earlier).
                         conv_correct_classification = gr.Radio(
                             choices=[
                                 "🟢 Should be GREEN - No distress",
-                                "🟡 Should be YELLOW - Needs clarification", 
+                                "🟡 Should be YELLOW - Needs clarification",
                                 "🔴 Should be RED - Spiritual distress"
                             ],
-                            label="Correct Classification",
+                            label="Select Correct Classification",
                             interactive=True
                         )
                         conv_incorrect_comment = gr.Textbox(
@@ -497,7 +497,12 @@ def create_simplified_interface():
         clear_btn.click(
             simplified_chat_handlers.handle_clear_simplified,
             inputs=[session_data],
-            outputs=[chatbot, status_box, session_data]
+            outputs=[
+                chatbot, status_box, session_data,
+                # Also reset the Conversation Verification tab (avoid stale scenario)
+                conv_verify_state, conv_verify_records, conv_verify_index,
+                conv_verify_status, conv_verify_exchange, conv_position, conv_stats,
+            ]
         )
         
         # Refresh status

src/interface/verification_handlers.py

@@ -1005,9 +1005,32 @@ def _generate_conv_verification(session: SimplifiedSessionData):
     html, pos, stats = _render_conv_exchange(records_as_dicts, 0)
     return meta, records_as_dicts, 0, f"✅ Generated session `{vs.session_id}`", html, pos, stats
 
+# Display text for each classification flag (shared by the verification handlers).
+_CLASSIFICATION_DISPLAY = {
+    "GREEN": "🟢 Should be GREEN - No distress",
+    "YELLOW": "🟡 Should be YELLOW - Needs clarification",
+    "RED": "🔴 Should be RED - Spiritual distress",
+}
+
+def _classification_update(records: list, idx: int):
+    """Build the gr.update for the 'Correct Classification' Radio.
+
+    - Hides the Radio on the PROVIDER_SUMMARY final step (the flag was already
+      chosen in earlier phases, so it must not be required there).
+    - Always uses None (never "") as the value: Gradio rejects a Radio value that
+      is not one of its choices and fails the whole response with an "Error" badge.
+    """
+    value = None
+    is_provider_summary = False
+    if records and 0 <= idx < len(records) and isinstance(records[idx], dict):
+        r = records[idx]
+        is_provider_summary = r.get("original_classification") == "PROVIDER_SUMMARY"
+        value = _CLASSIFICATION_DISPLAY.get(r.get("correct_classification"))
+    return gr.update(visible=not is_provider_summary, value=value)
+
 def _mark_conv_correct(records: list, idx: int):
     if not records:
-        return records, idx, "", "", "", gr.update(visible=False), "", ""
+        return records, idx, "", "", "", "", gr.update(visible=False), "", gr.update(value=None)
     idx = max(0, min(idx, len(records) - 1))
     if isinstance(records[idx], dict):
         records[idx]["is_correct"] = True
@@ -1016,29 +1039,17 @@ def _mark_conv_correct(records: list, idx: int):
         records[idx]["correct_classification"] = None
     html, pos, stats = _render_conv_exchange(records, idx)
     row_upd, note_val = _comment_ui_state(records, idx)
-    return records, idx, "✅ Marked correct", html, pos, stats, row_upd, note_val, ""
+    return records, idx, "✅ Marked correct", html, pos, stats, row_upd, note_val, _classification_update(records, idx)
 
 def _mark_conv_incorrect(records: list, idx: int):
     if not records:
-        return records, idx, "", "", "", gr.update(visible=False), "", ""
+        return records, idx, "", "", "", "", gr.update(visible=False), "", gr.update(value=None)
     idx = max(0, min(idx, len(records) - 1))
     if isinstance(records[idx], dict):
         records[idx]["is_correct"] = False
     html, pos, stats = _render_conv_exchange(records, idx)
     row_upd, note_val = _comment_ui_state(records, idx)
-    # Get existing correct_classification if any
-    existing_classification = ""
-    if isinstance(records[idx], dict):
-        correct_class = records[idx].get("correct_classification")
-        if correct_class:
-            # Map back to display text
-            reverse_map = {
-                "GREEN": "🟢 Should be GREEN - No distress",
-                "YELLOW": "🟡 Should be YELLOW - Needs clarification", 
-                "RED": "🔴 Should be RED - Spiritual distress"
-            }
-            existing_classification = reverse_map.get(correct_class, "")
-    return records, idx, "❌ Marked incorrect", html, pos, stats, row_upd, note_val, existing_classification
+    return records, idx, "❌ Marked incorrect", html, pos, stats, row_upd, note_val, _classification_update(records, idx)
 
 def _show_incorrect_comment_ui(records: list, idx: int):
     """Mark incorrect and open the comment row, pre-filling any existing note."""
@@ -1047,14 +1058,14 @@ def _show_incorrect_comment_ui(records: list, idx: int):
 
 def _save_incorrect_comment(records: list, idx: int, note: str, correct_classification: str):
     if not records:
-        return records, idx, "", "", "", "", gr.update(visible=False), "", ""
+        return records, idx, "", "", "", "", gr.update(visible=False), "", gr.update(value=None)
     idx = max(0, min(idx, len(records) - 1))
     if isinstance(records[idx], dict):
         records[idx]["verifier_notes"] = (note or "").strip()
         # Map display text to classification code
         classification_map = {
             "🟢 Should be GREEN - No distress": "GREEN",
-            "🟡 Should be YELLOW - Needs clarification": "YELLOW", 
+            "🟡 Should be YELLOW - Needs clarification": "YELLOW",
             "🔴 Should be RED - Spiritual distress": "RED"
         }
         if correct_classification and correct_classification in classification_map:
@@ -1062,7 +1073,7 @@ def _save_incorrect_comment(records: list, idx: int, note: str, correct_classifi
     html, pos, stats = _render_conv_exchange(records, idx)
     row_upd, note_val = _comment_ui_state(records, idx)
     # keep row visible after save (since still incorrect)
-    return records, idx, "💾 Comment saved", html, pos, stats, row_upd, note_val, ""
+    return records, idx, "💾 Comment saved", html, pos, stats, row_upd, note_val, _classification_update(records, idx)
 
 def _download_reviewed_json(meta: dict, records: list):
     return _export_conv_records_to_json(meta, records)
@@ -1072,22 +1083,11 @@ def _download_reviewed_csv(meta: dict, records: list):
 
 def _nav_conv(records: list, idx: int, delta: int):
     if not records:
-        return idx, "", "", "", gr.update(visible=False), "", ""
+        return idx, "", "", "", gr.update(visible=False), "", gr.update(value=None)
     idx = max(0, min(idx + delta, len(records) - 1))
     html, pos, stats = _render_conv_exchange(records, idx)
     row_upd, note_val = _comment_ui_state(records, idx)
-    # Get existing correct_classification if any
-    existing_classification = ""
-    if isinstance(records[idx], dict):
-        correct_class = records[idx].get("correct_classification")
-        if correct_class:
-            reverse_map = {
-                "GREEN": "🟢 Should be GREEN - No distress",
-                "YELLOW": "🟡 Should be YELLOW - Needs clarification", 
-                "RED": "🔴 Should be RED - Spiritual distress"
-            }
-            existing_classification = reverse_map.get(correct_class, "")
-    return idx, html, pos, stats, row_upd, note_val, existing_classification
+    return idx, html, pos, stats, row_upd, note_val, _classification_update(records, idx)
 
 
 # ============================================================================