Wrath of the json

business_continuity.py

@@ -117,22 +117,23 @@ def generate_recovery_strategies(request: BusinessContinuityRequest):
         raise HTTPException(status_code=400, detail="Department cannot be empty")
     
     try:
-        # Create system prompt - simplified and direct
-        system_prompt = """You are a business continuity expert. Your response must be a valid JSON object only.
-Follow this exact format:
+        # Create system prompt with strong emphasis on valid JSON output
+        system_prompt = """You are a business continuity expert. CRITICAL: You must ONLY output a valid, parsable JSON object and nothing else. No explanations, no formatting, just pure JSON.
+
+Your output MUST be in this EXACT format with NO DEVIATIONS:
 
 {
-  "people_unavailability_strategy": "Strategy for when key staff are unavailable (2 sentences).",
+  "people_unavailability_strategy": "Strategy for when key staff are unavailable (2-3 sentences).",
   "people_reasoning": "Why this strategy works for this process (1 sentence).",
-  "technology_data_unavailability_strategy": "Strategy for system failures (2 sentences).",
+  "technology_data_unavailability_strategy": "Strategy for system failures (2-3 sentences).",
   "technology_reasoning": "Why this technology strategy works (1 sentence).",
-  "site_unavailability_strategy": "Strategy for site unavailability (2 sentences).",
+  "site_unavailability_strategy": "Strategy for site unavailability (2-3 sentences).",
   "site_reasoning": "Why this site strategy works (1 sentence).",
-  "third_party_vendors_unavailability_strategy": "Strategy for supplier disruptions (2 sentences).",
+  "third_party_vendors_unavailability_strategy": "Strategy for supplier disruptions (2-3 sentences).",
   "vendor_reasoning": "Why this vendor strategy works (1 sentence)."
 }
 
-Do not include any other text or formatting in your response."""
+DO NOT add markdown code blocks, explanations, or any text before or after the JSON. ONLY output the raw JSON object."""
 
         # Create user message - simplified
         user_message = f"""Generate business continuity strategies for:
@@ -148,28 +149,16 @@ Description: {request.business_process.process_description}"""
             logger.error(f"Request {request_id}: API call failed - {str(e)}")
             return create_error_response(request_id, "API error")
         
-        # Parse JSON response with safer approach
+        # Parse JSON response directly
         try:
-            # First try direct parsing
+            # Simple direct parsing - trust the LLM to format correctly
             strategies_data = json.loads(api_response)
             logger.info(f"Request {request_id}: Successfully parsed JSON")
-        except json.JSONDecodeError:
-            logger.warning(f"Request {request_id}: Direct JSON parsing failed, trying to clean response")
-            
-            # Clean the response - look for JSON inside any markdown or text
-            try:
-                # Try to find JSON pattern
-                json_match = re.search(r'({[\s\S]*?})(?:\s*$|\n)', api_response)
-                if json_match:
-                    json_text = json_match.group(1)
-                    strategies_data = json.loads(json_text)
-                    logger.info(f"Request {request_id}: Successfully parsed JSON after cleaning")
-                else:
-                    raise ValueError("Could not find JSON in response")
-            except Exception as e:
-                logger.error(f"Request {request_id}: JSON parsing failed after cleaning - {str(e)}")
-                logger.error(f"Request {request_id}: Raw response preview: {api_response[:300]}")
-                return create_error_response(request_id, "Could not parse API response")
+        except json.JSONDecodeError as e:
+            # If parsing fails, just return the error
+            logger.error(f"Request {request_id}: JSON parsing failed - {str(e)}")
+            logger.error(f"Request {request_id}: Raw response preview: {api_response[:300]}")
+            return create_error_response(request_id, "Invalid JSON response from API")
         
         # Safely get fields with fallbacks
         return RecoveryStrategiesResponse(