black padd threshhold

src/utils.py

@@ -717,7 +717,7 @@ def resize_video(input_path: str, target_width: int = 1080, target_height: int =
 
     return temp_output
 
-def remove_black_padding(input_path: str, overwrite: bool = False) -> str:
+def remove_black_padding(input_path: str, overwrite: bool = False, threshold_pct: float = 0.1) -> str:
     """
     Automatically detect and remove black padding (crop only) using FFmpeg.
     Saves to /tmp with a unique UUID filename unless overwrite=True.
@@ -725,9 +725,11 @@ def remove_black_padding(input_path: str, overwrite: bool = False) -> str:
     Args:
         input_path (str): Path to the input video.
         overwrite (bool): If True, safely replace the original file.
+        threshold_pct (float): Only crop if black padding > threshold_pct (0.0 to 1.0).
+                              0.0 = always crop if any padding detected.
 
     Returns:
-        str: Path to the cropped video.
+        str: Path to the cropped video (or original if no crop needed).
     """
     if not os.path.exists(input_path):
         raise FileNotFoundError(f"Input video not found: {input_path}")
@@ -741,11 +743,39 @@ def remove_black_padding(input_path: str, overwrite: bool = False) -> str:
     matches = re.findall(r"crop=\S+", result.stderr)
 
     if not matches:
-        raise RuntimeError("Could not detect any crop region — video may not have black bars.")
+        logger.info("No black padding detected.")
+        return input_path
 
     # Get most frequent crop value
     crop_value = max(set(matches), key=matches.count)
-    logger.info(f"Detected crop: {crop_value}")
+    
+    # Parse crop string: crop=w:h:x:y
+    # Example: crop=1080:1520:0:200
+    try:
+        match = re.search(r"crop=(\d+):(\d+):(\d+):(\d+)", crop_value)
+        if match:
+            c_w, c_h, _, _ = map(int, match.groups())
+            
+            # Get original resolution
+            orig_w, orig_h = _get_video_resolution(input_path)
+            
+            orig_area = orig_w * orig_h
+            crop_area = c_w * c_h
+            padding_area = orig_area - crop_area
+            padding_pct = padding_area / orig_area if orig_area > 0 else 0
+            
+            if padding_pct < threshold_pct:
+                logger.info(f"Skipping crop: Padding {padding_pct:.1%} < Threshold {threshold_pct:.1%}")
+                return input_path
+            
+            logger.info(f"Detected crop: {crop_value} (Padding: {padding_pct:.1%})")
+            
+    except Exception as e:
+        logger.warning(f"Could not parse crop value '{crop_value}' for threshold check: {e}")
+        # Proceed with cropping if parsing fails, or return? 
+        # Safest is to proceed as before or log and continue. 
+        # Let's proceed to maintain existing behavior on failure unless explicitly stopped.
+        logger.info(f"Proceeding with crop: {crop_value}")
 
     # Step 2: Create temp output file
     tmp_output = os.path.join("/tmp", f"{uuid.uuid4().hex}_cropped.mp4")