Update training/gold_trainer.py

training/gold_trainer.py

@@ -1,86 +1,79 @@
-# training/gold_trainer.py  
-  
-from __future__ import annotations  
-from typing import Dict, Any  
-  
-# Stage 10C — schema and signal training  
-from training.schema_expander import expand_schema  
-from training.signal_trainer import train_signals  
-  
-  
-def train_from_gold() -> Dict[str, Any]:  
-    """  
-    Run all training components over the gold_tests dataset.  
-  
-    Returns a dict:  
-    {  
-      "alias_trainer": {...},  
-      "schema_expander": {...},  
-      "signals_trainer": {...}  
-    }  
-    """  
-  
-    # --------------------------------------------------------  
-    # 1) Alias Trainer (DISABLED IN STAGE 10C)  
-    #  
-    # The alias trainer previously created destructive mappings  
-    # (e.g. collapsing unrelated media/sugar tests), which harmed  
-    # accuracy and stability. For now we disable it completely.  
-    #  
-    # Alias maps can still be edited manually in:  
-    #   data/alias_maps.json  
-    #  
-    # Later stages will introduce a safe Alias Trainer v2.  
-    # --------------------------------------------------------  
-    alias_result = {  
-        "ok": False,  
-        "message": (  
-            "Alias trainer is disabled in Stage 10C to prevent unsafe "  
-            "auto-mappings. Edit data/alias_maps.json manually if needed."  
-        ),  
-        "alias_map_path": "data/alias_maps.json",  
-    }  
-  
-    # --------------------------------------------------------  
-    # 2) Schema Expander (Stage 10C)  
-    #  
-    # Reads:  
-    #   - training/gold_tests.json  
-    #   - data/extended_schema.json  
-    #  
-    # Produces:  
-    #   - auto-added fields  
-    #   - proposed fields (to review before committing)  
-    # --------------------------------------------------------  
-    try:  
-        schema_result = expand_schema()  
-    except Exception as e:  
-        schema_result = {  
-            "ok": False,  
-            "error": f"Schema expander failed: {e}",  
-        }  
-  
-    # --------------------------------------------------------  
-    # 3) Signals Trainer (Placeholder)  
-    #  
-    # Later versions will update:  
-    #   - data/signals_catalog.json  
-    #  
-    # For now it returns a stub response.  
-    # --------------------------------------------------------  
-    try:  
-        signals_result = train_signals()  
-    except Exception as e:  
-        signals_result = {  
-            "ok": False,  
-            "error": f"Signal trainer failed: {e}",  
-        }  
-  
-    # --------------------------------------------------------  
-    # Return all three components  
-    # --------------------------------------------------------  
-    return {  
-        "alias_trainer": alias_result,  
-        "schema_expander": schema_result,  
-        "signals_trainer": signals_result,  
+# training/gold_trainer.py
+# ------------------------------------------------------------
+# Stage 10C — Orchestrates gold-test-driven training:
+#   1) Alias trainer (DISABLED for safety)
+#   2) Schema expander (safe v10C)
+#   3) Signals trainer     (placeholder)
+#
+# This file MUST successfully import and expose train_from_gold().
+# ------------------------------------------------------------
+
+from __future__ import annotations
+from typing import Dict, Any
+
+# Safe schema expander
+from training.schema_expander import expand_schema
+
+# Placeholder signals trainer
+from training.signal_trainer import train_signals
+
+
+def train_from_gold() -> Dict[str, Any]:
+    """
+    Runs all gold-test–driven training components (Stage 10C).
+
+    Returns a dict:
+    {
+      "alias_trainer": {...},
+      "schema_expander": {...},
+      "signals_trainer": {...}
+    }
+    """
+
+    # --------------------------------------------------------
+    # 1) Alias Trainer — DISABLED to avoid destructive mappings
+    # --------------------------------------------------------
+    alias_result = {
+        "ok": False,
+        "message": (
+            "Alias trainer is disabled in Stage 10C to prevent unsafe "
+            "auto-mappings. Edit data/alias_maps.json manually if needed."
+        ),
+        "alias_map_path": "data/alias_maps.json",
+    }
+
+    # --------------------------------------------------------
+    # 2) Schema Expander — Safe version
+    # --------------------------------------------------------
+    try:
+        schema_result = expand_schema()
+    except Exception as e:
+        schema_result = {
+            "ok": False,
+            "message": f"Schema expander crashed: {e}",
+            "auto_added_fields": {},
+            "proposed_fields": [],
+            "schema_path": "data/extended_schema.json",
+            "proposals_path": "data/extended_proposals.jsonl",
+        }
+
+    # --------------------------------------------------------
+    # 3) Signals Trainer (placeholder)
+    # --------------------------------------------------------
+    try:
+        signals_result = train_signals()
+    except Exception as e:
+        signals_result = {
+            "ok": False,
+            "message": f"Signal trainer crashed: {e}",
+            "signals_catalog_path": "data/signals_catalog.json",
+        }
+
+    # --------------------------------------------------------
+    # Combined report
+    # --------------------------------------------------------
+    return {
+        "alias_trainer": alias_result,
+        "schema_expander": schema_result,
+        "signals_trainer": signals_result,
     }