Update app.py

app.py

@@ -8,10 +8,15 @@ from PIL import Image
 # =========================
 
 GROQ_API_KEY = os.getenv("GROQ_API_KEY")
+# Ideally, use a robust check or default to None if handling locally
 if not GROQ_API_KEY:
-    raise RuntimeError("⚠️ GROQ_API_KEY is missing! Add it in Hugging Face → Settings → Secrets.")
+    print("⚠️ GROQ_API_KEY is missing! Ensure it is set in your environment or Secrets.")
 
-client = Groq(api_key=GROQ_API_KEY)
+try:
+    client = Groq(api_key=GROQ_API_KEY)
+except Exception as e:
+    client = None
+    print(f"Error initializing Groq client: {e}")
 
 DEFAULT_MODEL = "llama-3.1-8b-instant"
 
@@ -23,7 +28,7 @@ MODE_PROMPTS = {
 }
 
 # =========================
-#  ASCII CONVERSION (FIXED)
+#  ASCII CONVERSION
 # =========================
 
 def image_to_ascii(image_path, output_width=100):
@@ -32,7 +37,7 @@ def image_to_ascii(image_path, output_width=100):
         img = Image.open(image_path).convert("L")
         w, h = img.size
         if w == 0:
-            return "[Error converting image to ASCII: image width is zero]"
+            return "[Error: image width is zero]"
         ratio = h / w
         new_height = max(1, int(output_width * ratio * 0.55))
         img = img.resize((output_width, new_height))
@@ -47,80 +52,55 @@ def image_to_ascii(image_path, output_width=100):
         return f"[Error converting image to ASCII: {e}]"
 
 # =========================
-#  CHAT FUNCTION (WITH HISTORY & MESSAGE SANITIZATION)
+#  CHAT FUNCTION (FIXED FOR MESSAGES FORMAT)
 # =========================
 
 def chat_fn(message, history, mode="Normal Chat", model=DEFAULT_MODEL, image=None, include_ascii=False):
     try:
-        # Start with a validated system prompt
+        if not client:
+            return "⚠️ Error: Groq client not initialized. Check API Key."
+
+        # 1. Prepare System Prompt
         system_prompt = MODE_PROMPTS.get(mode, MODE_PROMPTS["Normal Chat"])
         messages = [{"role": "system", "content": str(system_prompt).strip()}]
 
-        # SAFELY process history — only accept valid [user, assistant] pairs
+        # 2. Add History (Now in Dictionary Format)
         if isinstance(history, list):
-            for pair in history:
-                if isinstance(pair, (list, tuple)) and len(pair) == 2:
-                    user_msg, assistant_msg = pair
-
-                    if isinstance(user_msg, str) and user_msg.strip():
-                        messages.append({
-                            "role": "user",
-                            "content": user_msg.strip()
-                        })
-
-                    if isinstance(assistant_msg, str) and assistant_msg.strip():
-                        messages.append({
-                            "role": "assistant",
-                            "content": assistant_msg.strip()
-                        })
-
-        # If image uploaded + toggle ON → convert to ASCII safely
+            for msg in history:
+                if isinstance(msg, dict) and "role" in msg and "content" in msg:
+                    messages.append(msg)
+
+        # 3. Handle Image / Current Message
+        safe_message_text = str(message).strip() if message else ""
+        
         if image and include_ascii:
             try:
-                ascii_art = image_to_ascii(image.name)
+                ascii_art = image_to_ascii(image)
+                final_content = f"[ASCII Art from Uploaded Image]\n{ascii_art}\n\nUser message: {safe_message_text}"
             except Exception:
-                ascii_art = "[Error converting image to ASCII]"
-
-            safe_message_text = str(message).strip() if message else ""
-            message = f"[ASCII Art from Uploaded Image]\n{ascii_art}\n\nUser message: {safe_message_text}"
-
-        # Ensure current message is always a clean string
-        current_user_content = str(message).strip() if message else ""
-        messages.append({
-            "role": "user",
-            "content": current_user_content
-        })
-
-        # Final validation: ensure every message is a dict with role + content
-        validated_messages = []
-        for m in messages:
-            if not isinstance(m, dict):
-                continue
-            role = m.get("role")
-            content = m.get("content")
-            if role in ("system", "user", "assistant") and isinstance(content, str):
-                validated_messages.append({"role": role, "content": content})
-
-        if not validated_messages:
-            return "⚠️ Error: No valid messages to send."
-
-        # Call Groq
+                final_content = safe_message_text
+        else:
+            final_content = safe_message_text
+
+        # Append current user message
+        if final_content:
+            messages.append({"role": "user", "content": final_content})
+        else:
+            return "⚠️ Error: No message content provided."
+
+        # 4. Call Groq API
         response = client.chat.completions.create(
             model=model,
-            messages=validated_messages
+            messages=messages
         )
 
-        # Extract assistant reply safely
-        try:
-            return response.choices[0].message.content
-        except Exception:
-            return "⚠️ Error: Unexpected response format from the model."
+        return response.choices[0].message.content
 
     except Exception as e:
         return f"⚠️ Error: {str(e)}"
 
 # =========================
-#  UI (FULLY FIXED)
+#  UI (FIXED)
 # =========================
 
 with gr.Blocks(title="🦙 NeoHelper — Eyad’s Groq-powered Assistant") as demo:
@@ -144,7 +124,8 @@ with gr.Blocks(title="🦙 NeoHelper — Eyad’s Groq-powered Assistant") as de
             label="Model"
         )
 
-    chatbot = gr.Chatbot(height=500)
+    # FIX 1: Set type="messages" to match the data format Gradio expects
+    chatbot = gr.Chatbot(height=500, type="messages")
 
     with gr.Row():
         user_input = gr.Textbox(
@@ -158,35 +139,29 @@ with gr.Blocks(title="🦙 NeoHelper — Eyad’s Groq-powered Assistant") as de
     ascii_toggle = gr.Checkbox(label="Convert image to ASCII", value=False)
 
     def on_send(msg, history, mode, model, image, include_ascii):
-        # Normalize history to a list if None
+        # Initialize history if empty
         if history is None:
             history = []
-
-        # Clean malformed history entries BEFORE sending to chat_fn
-        clean_history = []
-        for pair in history:
-            if isinstance(pair, (list, tuple)) and len(pair) == 2:
-                u, a = pair
-                if isinstance(u, str) and isinstance(a, str):
-                    clean_history.append([u.strip(), a.strip()])
-        history = clean_history
-
-        # Ensure msg is a string
+        
+        # User message string
         user_msg = str(msg).strip() if msg else ""
-
-        # Call chat function
+        
+        # Get response
         reply = chat_fn(
             user_msg,
-            history,
+            history, # Pass history as is (list of dicts)
             mode,
             model,
             image,
             include_ascii
         )
-
-        # Append sanitized strings to history
-        safe_reply = str(reply).strip() if reply else ""
-        history.append([user_msg, safe_reply])
+        
+        # FIX 2: Append dictionaries {role, content} instead of lists [user, bot]
+        if user_msg:
+            history.append({"role": "user", "content": user_msg})
+        
+        history.append({"role": "assistant", "content": str(reply)})
+        
         return history, ""
 
     send_btn.click(