File size: 13,951 Bytes
d97c43c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
88890c9
d97c43c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
88890c9
 
d97c43c
88890c9
 
d97c43c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
88890c9
d97c43c
 
88890c9
d97c43c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
88890c9
 
 
d97c43c
 
 
 
 
 
88890c9
d97c43c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
"""
tests/test_tool_interface.py

Tests for the Tool Integration Layer:
- Tool interface / lifecycle
- Mock adapters
- ToolManager (dispatch + memory)
- Environment TOOL_CALL action
- Failure handling (validation, rate limiting, unknown tool)

Run with: python tests/test_tool_interface.py
"""

import sys, os
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))

from feature_flag_env.tools.tool_interface import Tool, ToolResult, ToolCallRequest, ToolMode, ValidationResult
from feature_flag_env.tools.mock_adapters import MockGitHubTool, MockSlackTool
from feature_flag_env.tools.tool_manager import ToolManager, ToolMemory
from feature_flag_env.server.feature_flag_environment import FeatureFlagEnvironment
from feature_flag_env.models import FeatureFlagAction


# ===========================================================================
# Tool Interface Tests
# ===========================================================================

def test_mock_github_tool():
    """MockGitHubTool should return simulated responses."""
    print("πŸ§ͺ MockGitHubTool basic...")
    tool = MockGitHubTool()
    tool.set_env_state({"error_rate": 0.02, "rollout_percentage": 30.0})

    result = tool.call("get_deployment_status", {"environment": "production"})
    assert result.success, f"Expected success, got error: {result.error}"
    assert result.tool_name == "github"
    assert result.action_name == "get_deployment_status"
    assert "status" in result.data
    assert result.latency_ms >= 0

    print(f"   πŸ“Š Deployment status: {result.data['status']}")
    print("   βœ… Passed")


def test_mock_slack_tool():
    """MockSlackTool should log messages."""
    print("πŸ§ͺ MockSlackTool basic...")
    tool = MockSlackTool()

    result = tool.call("send_message", {"channel": "#deployments", "text": "Hello"})
    assert result.success
    assert len(tool.message_log) == 1
    assert tool.message_log[0]["text"] == "Hello"

    result2 = tool.call("send_rollout_update", {
        "channel": "#deployments",
        "feature_name": "checkout-v2",
        "action": "INCREASE_ROLLOUT",
        "percentage": 40,
    })
    assert result2.success
    assert len(tool.message_log) == 2

    print(f"   πŸ“Š Messages logged: {len(tool.message_log)}")
    print("   βœ… Passed")


# ===========================================================================
# Validation Tests
# ===========================================================================

def test_validation_unknown_action():
    """Should reject unknown action names."""
    print("πŸ§ͺ Validation: unknown action...")
    tool = MockGitHubTool()
    result = tool.call("nonexistent_action", {})
    assert not result.success
    assert "Unknown action" in result.error

    print(f"   πŸ“Š Error: {result.error}")
    print("   βœ… Passed")


def test_validation_missing_params():
    """Should reject calls with missing required params."""
    print("πŸ§ͺ Validation: missing params...")

    slack = MockSlackTool()
    result = slack.call("send_message", {})  # missing channel
    assert not result.success
    assert "channel" in result.error

    print("   βœ… Passed")


def test_rate_limiting():
    """Should reject calls after rate limit exceeded."""
    print("πŸ§ͺ Rate limiting...")
    tool = MockGitHubTool(max_calls_per_episode=3)
    tool.set_env_state({"error_rate": 0.02, "rollout_percentage": 10.0})

    for i in range(3):
        result = tool.call("get_deployment_status", {"environment": "production"})
        assert result.success, f"Call {i+1} should succeed"

    # 4th call should fail
    result = tool.call("get_deployment_status", {"environment": "production"})
    assert not result.success
    assert "Rate limit" in result.error

    print(f"   πŸ“Š Calls made: {tool.call_count}")
    print("   βœ… Passed")


def test_metrics_tracking():
    """Tool should track call count, errors, latency."""
    print("πŸ§ͺ Metrics tracking...")
    tool = MockGitHubTool()
    tool.set_env_state({"error_rate": 0.02, "rollout_percentage": 10.0})

    tool.call("get_deployment_status", {"environment": "production"})
    tool.call("get_cicd_status", {"branch": "main"})
    tool.call("bogus_action", {})  # validation failure β€” NOT counted in call_count

    metrics = tool.get_metrics()
    # Only successful calls go through _execute and increment call_count
    assert metrics["calls"] == 2, f"Expected 2 calls, got {metrics['calls']}"
    assert metrics["errors"] == 0, f"Expected 0 execution errors, got {metrics['errors']}"
    assert metrics["avg_latency_ms"] >= 0

    print(f"   πŸ“Š Metrics: {metrics}")
    print("   βœ… Passed")


# ===========================================================================
# ToolManager Tests
# ===========================================================================

def test_tool_manager_register():
    """ToolManager should register and dispatch tools."""
    print("πŸ§ͺ ToolManager register + dispatch...")
    manager = ToolManager()
    manager.register(MockGitHubTool())
    manager.register(MockSlackTool())

    assert manager.connected_count == 2
    assert "github" in manager.tool_names

    manager.update_env_state({"error_rate": 0.02, "latency_p99_ms": 100, "rollout_percentage": 10})

    result = manager.execute(ToolCallRequest(
        tool_name="github",
        action_name="get_deployment_status",
        params={"environment": "production"},
    ))
    assert result.success

    print(f"   πŸ“Š Connected tools: {manager.tool_names}")
    print("   βœ… Passed")


def test_tool_manager_unknown_tool():
    """ToolManager should return error for unknown tool."""
    print("πŸ§ͺ ToolManager: unknown tool...")
    manager = ToolManager()
    manager.register(MockGitHubTool())

    result = manager.execute(ToolCallRequest(
        tool_name="pagerduty",
        action_name="get_incidents",
    ))
    assert not result.success
    assert "Unknown tool" in result.error

    print(f"   πŸ“Š Error: {result.error}")
    print("   βœ… Passed")


def test_tool_memory():
    """ToolMemory should maintain rolling buffer."""
    print("πŸ§ͺ ToolMemory buffer...")
    manager = ToolManager(memory_size=3)
    manager.register(MockGitHubTool())
    manager.update_env_state({"error_rate": 0.02, "rollout_percentage": 10})

    for i in range(5):
        manager.execute(ToolCallRequest(
            tool_name="github",
            action_name="get_deployment_status",
            params={"environment": "production"},
        ))

    assert len(manager.memory.recent) == 3  # capped at 3
    summary = manager.memory.summary()
    assert summary["total_calls"] == 3  # buffer only holds 3
    assert len(summary["recent_results"]) <= 5

    print(f"   πŸ“Š Buffer size: {len(manager.memory.recent)}")
    print("   βœ… Passed")


def test_tool_manager_reset():
    """ToolManager.reset() should clear memory and tool counters."""
    print("πŸ§ͺ ToolManager reset...")
    manager = ToolManager()
    github = MockGitHubTool()
    manager.register(github)
    manager.update_env_state({"error_rate": 0.02, "rollout_percentage": 10})

    manager.execute(ToolCallRequest(
        tool_name="github", action_name="get_deployment_status", params={"environment": "prod"},
    ))
    assert github.call_count == 1

    manager.reset()
    assert github.call_count == 0
    assert manager.memory.last is None

    print("   βœ… Passed")


# ===========================================================================
# Environment Integration Tests
# ===========================================================================

def test_env_tool_call_action():
    """Environment should handle TOOL_CALL action type."""
    print("πŸ§ͺ Environment TOOL_CALL action...")
    env = FeatureFlagEnvironment(tools_enabled=True)
    obs = env.reset()

    action = FeatureFlagAction(
        action_type="TOOL_CALL",
        target_percentage=0.0,
        reason="Check deployment status",
        tool_call={
            "tool_name": "github",
            "action_name": "get_deployment_status",
            "params": {"environment": "production"},
        },
    )
    response = env.step(action)

    assert response.observation.last_tool_result is not None
    assert response.observation.last_tool_result["tool"] == "github"
    assert response.observation.last_tool_result["success"] is True
    assert "tool_call_result" in response.info

    print(f"   πŸ“Š Tool result: {response.observation.last_tool_result['action']}")
    print(f"   πŸ“Š Reward: {response.reward:+.2f}")
    print("   βœ… Passed")


def test_env_tool_call_prompt_string():
    """Observation prompt should include LAST TOOL RESULT section."""
    print("πŸ§ͺ TOOL_CALL prompt string...")
    env = FeatureFlagEnvironment(tools_enabled=True)
    env.reset()

    action = FeatureFlagAction(
        action_type="TOOL_CALL",
        target_percentage=0.0,
        reason="Check metrics",
        tool_call={
            "tool_name": "github",
            "action_name": "get_cicd_status",
            "params": {"branch": "main"},
        },
    )
    response = env.step(action)
    prompt = response.observation.to_prompt_string()

    assert "LAST TOOL RESULT" in prompt
    assert "github" in prompt

    print(f"   πŸ“Š Prompt length: {len(prompt)} chars")
    print("   βœ… Passed")


def test_env_mixed_actions():
    """Environment should handle mix of regular and TOOL_CALL actions."""
    print("πŸ§ͺ Mixed regular + TOOL_CALL actions...")
    env = FeatureFlagEnvironment(tools_enabled=True)
    env.reset()

    # Regular rollout action
    r1 = env.step(FeatureFlagAction(
        action_type="INCREASE_ROLLOUT", target_percentage=10.0, reason="test",
    ))
    assert r1.observation.last_tool_result is None  # no tool call

    # Tool call action
    r2 = env.step(FeatureFlagAction(
        action_type="TOOL_CALL", target_percentage=0.0, reason="check",
        tool_call={"tool_name": "github", "action_name": "get_cicd_status", "params": {"branch": "main"}},
    ))
    assert r2.observation.last_tool_result is not None
    # Rollout should NOT have changed
    assert r2.observation.current_rollout_percentage == 10.0

    # Another regular action
    r3 = env.step(FeatureFlagAction(
        action_type="INCREASE_ROLLOUT", target_percentage=20.0, reason="test",
    ))
    assert r3.observation.current_rollout_percentage == 20.0

    print(f"   πŸ“Š Rollout: 0 β†’ 10 β†’ 10 (tool) β†’ 20")
    print("   βœ… Passed")


def test_env_tools_disabled():
    """With tools_enabled=False, TOOL_CALL should still work but with penalty."""
    print("πŸ§ͺ TOOL_CALL with tools disabled...")
    env = FeatureFlagEnvironment(tools_enabled=False)
    env.reset()

    action = FeatureFlagAction(
        action_type="TOOL_CALL", target_percentage=0.0, reason="test",
        tool_call={"tool_name": "github", "action_name": "get_deployment_status", "params": {}},
    )
    response = env.step(action)
    # Should penalize since tool manager is not initialized
    assert response.reward < 0, f"Expected negative reward, got {response.reward}"

    print(f"   πŸ“Š Penalty reward: {response.reward:+.2f}")
    print("   βœ… Passed")


def test_env_tool_call_invalid():
    """Invalid tool call should return error result."""
    print("πŸ§ͺ Invalid tool call...")
    env = FeatureFlagEnvironment(tools_enabled=True)
    env.reset()

    action = FeatureFlagAction(
        action_type="TOOL_CALL", target_percentage=0.0, reason="test",
        tool_call={"tool_name": "nonexistent", "action_name": "foo", "params": {}},
    )
    response = env.step(action)
    assert response.observation.last_tool_result is not None
    assert response.observation.last_tool_result["success"] is False
    assert response.reward < 0

    print(f"   πŸ“Š Error: {response.observation.last_tool_result['error']}")
    print("   βœ… Passed")


# ===========================================================================
# Backward Compatibility
# ===========================================================================

def test_backward_compat():
    """Existing tests should still work (no tools enabled)."""
    print("πŸ§ͺ Backward compatibility...")
    env = FeatureFlagEnvironment()
    obs = env.reset()

    assert obs.last_tool_result is None
    assert obs.tool_memory_summary is None

    action = FeatureFlagAction(
        action_type="INCREASE_ROLLOUT", target_percentage=15.0, reason="test",
    )
    response = env.step(action)
    assert response.observation.last_tool_result is None
    assert response.observation.current_rollout_percentage == 15.0

    print("   βœ… Passed")


# ===========================================================================
# Main
# ===========================================================================

def main():
    print("=" * 60)
    print("πŸš€ TOOL INTEGRATION LAYER TESTS")
    print("=" * 60)

    results = [
        # Tool interface
        test_mock_github_tool(),
        test_mock_slack_tool(),

        # Validation & failure
        test_validation_unknown_action(),
        test_validation_missing_params(),
        test_rate_limiting(),
        test_metrics_tracking(),

        # ToolManager
        test_tool_manager_register(),
        test_tool_manager_unknown_tool(),
        test_tool_memory(),
        test_tool_manager_reset(),

        # Environment integration
        test_env_tool_call_action(),
        test_env_tool_call_prompt_string(),
        test_env_mixed_actions(),
        test_env_tools_disabled(),
        test_env_tool_call_invalid(),
        test_backward_compat(),
    ]

    print()
    print("=" * 60)
    if all(results):
        print(f"βœ… ALL {len(results)} TOOL INTEGRATION TESTS PASSED!")
    else:
        failed = sum(1 for r in results if not r)
        print(f"❌ {failed} TEST(S) FAILED.")
    print("=" * 60)


if __name__ == "__main__":
    main()