Spaces:
Sleeping
Sleeping
File size: 11,571 Bytes
08af9fd | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 | """
Unit tests for add_task tool.
"""
import pytest
from unittest.mock import MagicMock, patch
from sqlmodel import Session
from backend.mcp_server.tools.add_task import add_task
from backend.mcp_server.schemas import ErrorCode
def test_add_task_valid_input():
"""Test adding a task with valid input."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Buy groceries"
mock_task.description = "Milk, eggs, bread"
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title="Buy groceries",
description="Milk, eggs, bread"
)
assert result["success"] is True
assert result["data"]["task_id"] == 1
assert result["data"]["status"] == "created"
assert result["data"]["title"] == "Buy groceries"
assert result["error"] is None
def test_add_task_without_description():
"""Test adding a task without description (optional field)."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Call mom"
mock_task.description = None
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title="Call mom"
)
assert result["success"] is True
assert result["data"]["status"] == "created"
assert result["data"]["title"] == "Call mom"
def test_add_task_title_validation_empty():
"""Test add_task rejects empty title."""
result = add_task(
user_id="user_abc123",
title=""
)
assert result["success"] is False
assert result["data"] is None
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
assert "title" in result["error"]["message"].lower()
def test_add_task_title_validation_too_short():
"""Test add_task rejects title shorter than 1 character."""
result = add_task(
user_id="user_abc123",
title=""
)
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_add_task_title_validation_too_long():
"""Test add_task rejects title longer than 200 characters."""
long_title = "A" * 201
result = add_task(
user_id="user_abc123",
title=long_title
)
assert result["success"] is False
assert result["data"] is None
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
assert "title" in result["error"]["message"].lower()
def test_add_task_description_validation_too_long():
"""Test add_task rejects description longer than 1000 characters."""
long_desc = "A" * 1001
result = add_task(
user_id="user_abc123",
title="Valid title",
description=long_desc
)
assert result["success"] is False
assert result["data"] is None
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_add_task_user_association():
"""Test task is created with correct user association."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "User specific task"
mock_task.user_id = "user_xyz456"
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_xyz456",
title="User specific task"
)
assert result["success"] is True
# The task should be associated with user_xyz456
def test_add_task_returns_correct_format():
"""Test add_task returns consistent response format."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Test task"
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title="Test task"
)
# Response must have all three top-level keys
assert "success" in result
assert "data" in result
assert "error" in result
# Data must have required fields
assert result["data"]["task_id"] is not None
assert result["data"]["status"] is not None
assert result["data"]["title"] is not None
def test_add_task_special_characters_in_title():
"""Test add_task handles special characters in title."""
special_title = "Buy groceries! 🛒 (milk, eggs)"
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = special_title
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title=special_title
)
assert result["success"] is True
assert result["data"]["title"] == special_title
def test_add_task_special_characters_in_description():
"""Test add_task handles special characters in description."""
special_desc = "Remember to: buy milk 🥛, eggs 🥚, bread 🍞"
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Shopping list"
mock_task.description = special_desc
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title="Shopping list",
description=special_desc
)
assert result["success"] is True
assert result["data"]["title"] == "Shopping list"
def test_add_task_minimal_title():
"""Test add_task accepts minimum title length (1 character)."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "A"
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title="A"
)
assert result["success"] is True
assert result["data"]["title"] == "A"
def test_add_task_max_title():
"""Test add_task accepts maximum title length (200 characters)."""
max_title = "A" * 200
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = max_title
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title=max_title
)
assert result["success"] is True
assert len(result["data"]["title"]) == 200
def test_add_task_max_description():
"""Test add_task accepts maximum description length (1000 characters)."""
max_desc = "A" * 1000
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Task"
mock_task.description = max_desc
mock_task.completed = False
with patch('backend.mcp_server.tools.add_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.add_task.Session') as mock_session_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.add.return_value = None
mock_session.commit.return_value = None
mock_session.refresh.side_effect = lambda task: setattr(task, 'id', 1)
result = add_task(
user_id="user_abc123",
title="Task",
description=max_desc
)
assert result["success"] is True
|