Spaces:
Running
Running
File size: 8,673 Bytes
08af9fd |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 |
"""
Unit tests for update_task tool.
"""
import pytest
from unittest.mock import MagicMock, patch
from sqlmodel import Session
from backend.mcp_server.tools.update_task import update_task
from backend.mcp_server.schemas import ErrorCode
def test_update_task_title_only():
"""Test updating only the task title."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Old Title"
mock_task.description = "Original description"
mock_task.completed = False
with patch('backend.mcp_server.tools.update_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.update_task.Session') as mock_session_class, \
patch('backend.mcp_server.tools.update_task.select') as mock_select:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.exec.return_value.first.return_value = mock_task
result = update_task(user_id="user_abc123", task_id=1, title="New Title")
assert result["success"] is True
assert result["data"]["task_id"] == 1
assert result["data"]["status"] == "updated"
assert result["data"]["title"] == "New Title"
assert result["error"] is None
def test_update_task_description_only():
"""Test updating only the task description."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Task Title"
mock_task.description = "Old description"
mock_task.completed = False
with patch('backend.mcp_server.tools.update_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.update_task.Session') as mock_session_class, \
patch('backend.mcp_server.tools.update_task.select') as mock_select:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.exec.return_value.first.return_value = mock_task
result = update_task(user_id="user_abc123", task_id=1, description="New description")
assert result["success"] is True
assert result["data"]["task_id"] == 1
assert result["data"]["status"] == "updated"
def test_update_task_both_fields():
"""Test updating both title and description."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Old Title"
mock_task.description = "Old description"
mock_task.completed = False
with patch('backend.mcp_server.tools.update_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.update_task.Session') as mock_session_class, \
patch('backend.mcp_server.tools.update_task.select') as mock_select:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.exec.return_value.first.return_value = mock_task
result = update_task(
user_id="user_abc123",
task_id=1,
title="New Title",
description="New description"
)
assert result["success"] is True
assert result["data"]["task_id"] == 1
def test_update_task_neither_field():
"""Test updating with neither title nor description returns error."""
result = update_task(user_id="user_abc123", task_id=1)
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
assert "at least one" in result["error"]["message"].lower()
def test_update_task_not_found():
"""Test updating a non-existent task returns NOT_FOUND."""
with patch('backend.mcp_server.tools.update_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.update_task.Session') as mock_session_class, \
patch('backend.mcp_server.tools.update_task.select') as mock_select:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.exec.return_value.first.return_value = None
result = update_task(user_id="user_abc123", task_id=999, title="New Title")
assert result["success"] is False
assert result["data"] is None
assert result["error"]["code"] == ErrorCode.NOT_FOUND
def test_update_task_invalid_title_length():
"""Test updating with title that exceeds 200 characters."""
result = update_task(
user_id="user_abc123",
task_id=1,
title="A" * 201
)
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_update_task_invalid_description_length():
"""Test updating with description that exceeds 1000 characters."""
result = update_task(
user_id="user_abc123",
task_id=1,
description="A" * 1001
)
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_update_task_invalid_user_id():
"""Test updating a task with empty user_id."""
result = update_task(user_id="", task_id=1, title="New Title")
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_update_task_invalid_task_id():
"""Test updating a task with invalid task_id."""
result = update_task(user_id="user_abc123", task_id=0, title="New Title")
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_update_task_response_format():
"""Test update_task returns correct response format."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Task Title"
mock_task.description = "Description"
mock_task.completed = False
with patch('backend.mcp_server.tools.update_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.update_task.Session') as mock_session_class, \
patch('backend.mcp_server.tools.update_task.select') as mock_select:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.exec.return_value.first.return_value = mock_task
result = update_task(user_id="user_abc123", task_id=1, title="New Title")
# Response must have all three top-level keys
assert "success" in result
assert "data" in result
assert "error" in result
# Data must have required fields
assert result["data"]["task_id"] is not None
assert result["data"]["status"] is not None
assert result["data"]["title"] is not None
def test_update_task_filters_by_user_id():
"""Test that update_task filters by user_id."""
mock_task = MagicMock()
mock_task.id = 1
mock_task.title = "Task Title"
mock_task.user_id = "user_abc123"
with patch('backend.mcp_server.tools.update_task.get_engine') as mock_get_engine, \
patch('backend.mcp_server.tools.update_task.Session') as mock_session_class, \
patch('backend.mcp_server.tools.update_task.select') as mock_select, \
patch('backend.mcp_server.tools.update_task.Task') as mock_task_class:
mock_get_engine.return_value = MagicMock()
mock_session = MagicMock()
mock_session_class.return_value.__enter__.return_value = mock_session
mock_session_class.return_value.__exit__.return_value = False
mock_session.exec.return_value.first.return_value = mock_task
update_task(user_id="user_abc123", task_id=1, title="New Title")
# Verify select was called
mock_select.assert_called()
def test_update_task_whitespace_only_title():
"""Test updating with title that contains only whitespace."""
result = update_task(
user_id="user_abc123",
task_id=1,
title=" "
)
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
def test_update_task_empty_title():
"""Test updating with empty string title."""
result = update_task(
user_id="user_abc123",
task_id=1,
title=""
)
assert result["success"] is False
assert result["error"]["code"] == ErrorCode.INVALID_INPUT
|