Update backend/server.js

backend/server.js

@@ -21,7 +21,7 @@ app.use(express.json());
 app.use('/uploads', express.static(path.join(__dirname, 'uploads')));
 
 // Ensure directories exist
-const dirs = ['uploads', 'temp', 'results'];
+const dirs = ['uploads', 'temp', 'results']; // Removed 'database' to prevent permission errors
 dirs.forEach(dir => {
     const dirPath = path.join(__dirname, dir);
     if (!fs.existsSync(dirPath)) {
@@ -35,76 +35,21 @@ dirs.forEach(dir => {
 console.log('DATABASE: Temporarily disabled for deployment. No data will be saved or retrieved.');
 const db = null;
 
-
-// --- MULTER CONFIG FOR IMAGE UPLOADS ---
-const imageStorage = multer.diskStorage({
+// --- UNIFIED MULTER CONFIG ---
+// A single configuration for handling all file uploads to a temporary directory.
+const storage = multer.diskStorage({
     destination: (req, file, cb) => {
-        cb(null, path.join(__dirname, 'uploads/'));
+        cb(null, path.join(__dirname, 'temp/'));
     },
     filename: (req, file, cb) => {
-        const uniqueName = `${Date.now()}-${Math.round(Math.random() * 1E9)}${path.extname(file.originalname)}`;
+        const uniqueName = `${file.fieldname}-${Date.now()}-${Math.round(Math.random() * 1E9)}${path.extname(file.originalname)}`;
         cb(null, uniqueName);
     }
 });
 
-const imageUpload = multer({
-    storage: imageStorage,
-    limits: { fileSize: 10 * 1024 * 1024 }, // 10MB limit
-    fileFilter: (req, file, cb) => {
-        if (file.mimetype.startsWith('image/')) {
-            cb(null, true);
-        } else {
-            cb(new Error('Only image files are allowed!'), false);
-        }
-    }
-});
-
-// --- MULTER CONFIG FOR AUDIO UPLOADS ---
-const audioStorage = multer.diskStorage({
-    destination: function (req, file, cb) {
-        cb(null, path.join(__dirname, 'temp/')); // Save audio files in a temp directory
-    },
-    filename: function (req, file, cb) {
-        const uniqueSuffix = Date.now() + '-' + Math.round(Math.random() * 1E9);
-        cb(null, 'audio-' + uniqueSuffix + path.extname(file.originalname));
-    }
-});
-
-const audioUpload = multer({
-    storage: audioStorage,
-    limits: { fileSize: 25 * 1024 * 1024 }, // 25MB limit for audio
-    fileFilter: (req, file, cb) => {
-        if (file.mimetype.startsWith('audio/')) {
-            cb(null, true);
-        } else {
-            cb(new Error('Only audio files are allowed!'), false);
-        }
-    }
-});
-
-// --- MULTER CONFIG FOR DNA SEQUENCE FILES ---
-const dnaFileStorage = multer.diskStorage({
-    destination: function (req, file, cb) {
-        cb(null, path.join(__dirname, 'temp/')); // Save DNA files in the same temp directory
-    },
-    filename: function (req, file, cb) {
-        const uniqueSuffix = Date.now() + '-' + Math.round(Math.random() * 1E9);
-        cb(null, 'dna-' + uniqueSuffix + path.extname(file.originalname));
-    }
-});
-
-const dnaUpload = multer({
-    storage: dnaFileStorage,
-    limits: { fileSize: 50 * 1024 * 1024 }, // 50MB limit for sequence files
-    fileFilter: (req, file, cb) => {
-        // Loosely accept text-based formats common for DNA
-        const allowedTypes = ['.fasta', '.fastq', '.txt', '.fa', '.fq'];
-        if (allowedTypes.includes(path.extname(file.originalname).toLowerCase())) {
-            cb(null, true);
-        } else {
-            cb(new Error('Invalid file type for DNA analysis!'), false);
-        }
-    }
+const upload = multer({
+    storage: storage,
+    limits: { fileSize: 50 * 1024 * 1024 }, // 50MB general limit
 });
 
 // --- HELPER FUNCTIONS ---
@@ -124,244 +69,98 @@ function fallbackAnalysis(imagePath, waterSource) {
     };
 }
 
-function callPythonAnalysis(imagePath, waterSource) {
+// Refactored helper to call any Python script, handle JSON, and manage errors.
+function callPythonScript(scriptName, args = [], inputData = null) {
     return new Promise((resolve, reject) => {
-        const scriptPath = path.join(__dirname, 'python', 'water_analysis.py');
-        const pythonProcess = spawn('python', [scriptPath, imagePath, waterSource || 'unknown']);
+        const scriptPath = path.join(__dirname, 'python', scriptName);
+        const pythonProcess = spawn('python3', [scriptPath, ...args]);
 
         let dataString = '';
         let errorString = '';
 
-        pythonProcess.stdout.on('data', (data) => {
-            dataString += data.toString();
-        });
+        pythonProcess.stdout.on('data', (data) => { dataString += data.toString(); });
+        pythonProcess.stderr.on('data', (data) => { errorString += data.toString(); });
 
-        pythonProcess.stderr.on('data', (data) => {
-            errorString += data.toString();
-        });
+        if (inputData) {
+            pythonProcess.stdin.write(JSON.stringify(inputData));
+            pythonProcess.stdin.end();
+        }
 
         pythonProcess.on('close', (code) => {
             if (code === 0) {
                 try {
-                    const result = JSON.parse(dataString);
-                    resolve(result);
+                    resolve(JSON.parse(dataString));
                 } catch (error) {
-                    reject(new Error('Failed to parse Python output'));
+                    console.error(`Error parsing JSON from ${scriptName}:`, dataString);
+                    reject(new Error(`Failed to parse Python output from ${scriptName}`));
                 }
             } else {
-                console.log(`Python script at ${scriptPath} not available or failed, using fallback. Error: ${errorString}`);
-                resolve(fallbackAnalysis(imagePath, waterSource));
+                console.error(`Error in ${scriptName} (code ${code}): ${errorString}`);
+                reject(new Error(errorString || `Python script ${scriptName} exited with code ${code}`));
             }
         });
     });
 }
 
-// Dummy C++ preprocessor call for demonstration
-async function callCppPreprocessing(imagePath) {
-    return new Promise((resolve, reject) => {
-        // In a real scenario, you would spawn a C++ executable.
-        // For this demo, we'll just simulate a failure to show the fallback.
-        reject(new Error("C++ preprocessor not found or failed."));
-    });
-}
-
 // --- API ROUTES ---
 
-// --- BIODIVERSITYEAR AUDIO ANALYSIS ENDPOINT ---
-app.post('/api/analyze-audio', audioUpload.single('audioFile'), (req, res) => {
-    console.log('✅ Backend: Received audio file analysis request.');
-
-    if (!req.file || req.file.size === 0) {
-        if (req.file) {
-            fs.unlink(req.file.path, (err) => {
-                if (err) console.error(`- Error deleting empty file: ${err.message}`);
-            });
-        }
-        return res.status(400).json({ message: 'The provided audio file is empty or missing. Please record for at least one second.' });
-    }
-
-    console.log(`- Audio file saved to: ${req.file.path}`);
-    console.log(`- Region: ${req.body.region}, Habitat: ${req.body.habitat}`);
-    console.log('▶️ Calling Python AI script for audio analysis...');
-
-    const pythonProcess = spawn('python', [
-        path.join(__dirname, 'python', 'audio_analyzer.py'),
-        req.file.path
-    ]);
-
-    let analysisResult = '';
-    let errorOutput = '';
-
-    pythonProcess.stdout.on('data', (data) => {
-        analysisResult += data.toString();
-    });
+// --- HEALTH CHECK ENDPOINT ---
+// This is crucial for platforms like Hugging Face to know the app is ready.
+app.get('/api/health', (req, res) => {
+    res.status(200).json({ status: 'ok', message: 'Backend is running' });
+});
 
-    pythonProcess.stderr.on('data', (data) => {
-        errorOutput += data.toString();
-    });
+// --- BIODIVERSITYEAR AUDIO ANALYSIS ENDPOINT ---
+app.post('/api/analyze-audio', upload.single('audioFile'), async (req, res) => {
+    if (!req.file) return res.status(400).json({ message: 'Audio file is missing.' });
 
-    pythonProcess.on('close', (code) => {
-        // Clean up the uploaded audio file after analysis
+    try {
+        console.log('▶️ Calling Python AI script for audio analysis...');
+        const result = await callPythonScript('audio_analyzer.py', [req.file.path]);
+        res.status(200).json(result);
+    } catch (error) {
+        res.status(500).json({ message: 'Error during audio analysis.', error: error.message });
+    } finally {
+        // Clean up the temporary file
         fs.unlink(req.file.path, (err) => {
             if (err) console.error(`- Error deleting temp audio file: ${err.message}`);
-            else console.log(`- Temporary audio file ${req.file.path} deleted.`);
         });
-
-        if (code === 0) {
-            console.log('✅ Backend: Python audio script finished successfully.');
-            try {
-                const jsonData = JSON.parse(analysisResult);
-                res.status(200).json(jsonData);
-            } catch (e) {
-                console.error('❌ Backend: Error parsing JSON from Python audio script.', e);
-                res.status(500).json({ message: 'Failed to parse audio analysis result.' });
-            }
-        } else {
-            console.error(`❌ Backend: Python audio script exited with error code ${code}.`);
-            console.error(`- Python Error: ${errorOutput}`);
-            res.status(500).json({ message: 'Error during audio analysis.', error: errorOutput });
-        }
-    });
+    }
 });
 
 // --- BIO-STREAM AI DNA ANALYSIS ENDPOINT ---
-app.post('/api/analyze-dna', dnaUpload.single('dnaFile'), (req, res) => {
-    console.log('✅ Backend: Received DNA file analysis request for Bio-Stream AI.');
-
-    if (!req.file) {
-        return res.status(400).json({ message: 'No DNA file was uploaded.' });
-    }
-
-    console.log(`- DNA file saved to: ${req.file.path}`);
-    console.log('▶️ Calling Python AI script for DNA analysis...');
+app.post('/api/analyze-dna', upload.single('dnaFile'), async (req, res) => {
+    if (!req.file) return res.status(400).json({ message: 'DNA file is missing.' });
 
-    const pythonProcess = spawn('python', [
-        path.join(__dirname, 'python', 'dna_analyzer.py'),
-        req.file.path // Pass the full path of the uploaded file to the script
-    ]);
-
-    let analysisResult = '';
-    let errorOutput = '';
-
-    pythonProcess.stdout.on('data', (data) => {
-        analysisResult += data.toString();
-    });
-
-    pythonProcess.stderr.on('data', (data) => {
-        errorOutput += data.toString();
-    });
-
-    pythonProcess.on('close', (code) => {
-        // IMPORTANT: Clean up the uploaded DNA file after analysis is complete
+    try {
+        console.log('▶️ Calling Python AI script for DNA analysis...');
+        const result = await callPythonScript('dna_analyzer.py', [req.file.path]);
+        res.status(200).json(result);
+    } catch (error) {
+        res.status(500).json({ message: 'Error during DNA analysis.', error: error.message });
+    } finally {
         fs.unlink(req.file.path, (err) => {
             if (err) console.error(`- Error deleting temp DNA file: ${err.message}`);
-            else console.log(`- Temporary DNA file ${req.file.path} deleted.`);
         });
-
-        if (code === 0) {
-            console.log('✅ Backend: Python DNA analysis script finished successfully.');
-            try {
-                const jsonData = JSON.parse(analysisResult);
-                res.status(200).json(jsonData);
-            } catch (e) {
-                console.error('❌ Backend: Error parsing JSON from Python DNA script.', e);
-                res.status(500).json({ message: 'Failed to parse DNA analysis result.' });
-            }
-        } else {
-            console.error(`❌ Backend: Python DNA script exited with error code ${code}.`);
-            console.error(`- Python Error: ${errorOutput}`);
-            res.status(500).json({ message: 'Error during DNA analysis.', error: errorOutput });
-        }
-    });
-});
-
-// --- PHANTOM FOOTPRINT ANALYSIS ENDPOINT ---
-app.post('/api/analyze-footprint', (req, res) => {
-    const { url } = req.body;
-    console.log(`✅ Backend: Received Phantom Footprint analysis request for URL: ${url}`);
-
-    if (!url) {
-        return res.status(400).json({ message: 'Product URL is required.' });
     }
-
-    const pythonProcess = spawn('python', [
-        path.join(__dirname, 'python', 'phantom_footprint_analyzer.py')
-    ]);
-
-    let analysisResult = '';
-    let errorOutput = '';
-
-    pythonProcess.stdin.write(JSON.stringify({ url: url }));
-    pythonProcess.stdin.end();
-
-    pythonProcess.stdout.on('data', (data) => {
-        analysisResult += data.toString();
-    });
-
-    pythonProcess.stderr.on('data', (data) => {
-        errorOutput += data.toString();
-    });
-
-    pythonProcess.on('close', (code) => {
-        if (code === 0) {
-            console.log('✅ Backend: Python footprint script finished successfully.');
-            try {
-                const jsonData = JSON.parse(analysisResult);
-                res.status(200).json(jsonData);
-            } catch (e) {
-                console.error('❌ Backend: Error parsing JSON from Python script.', e);
-                res.status(500).json({ message: 'Failed to parse analysis result.' });
-            }
-        } else {
-            console.error(`❌ Backend: Python footprint script exited with error code ${code}.`);
-            console.error(`- Python Error: ${errorOutput}`);
-            res.status(500).json({ message: 'Error during footprint analysis.', error: errorOutput });
-        }
-    });
 });
 
-// --- E-WASTE ANALYSIS ENDPOINT ---
-app.post('/api/analyze-ewaste', (req, res) => {
-    console.log('✅ Backend: Received e-waste form analysis request.');
-
-    const pythonProcess = spawn('python', [
-        path.join(__dirname, 'python', 'ewaste_analyzer.py')
-    ]);
-
-    let analysisResult = '';
-    let errorOutput = '';
-
-    pythonProcess.stdin.write(JSON.stringify(req.body));
-    pythonProcess.stdin.end();
-
-    pythonProcess.stdout.on('data', (data) => {
-        analysisResult += data.toString();
-    });
-
-    pythonProcess.stderr.on('data', (data) => {
-        errorOutput += data.toString();
-    });
+// --- JSON-based Analysis Endpoints (Footprint, E-Waste) ---
+async function handleJsonAnalysis(req, res, scriptName, logMessage) {
+    console.log(`✅ Backend: Received ${logMessage} request.`);
+    try {
+        const result = await callPythonScript(scriptName, [], req.body);
+        res.status(200).json(result);
+    } catch (error) {
+        res.status(500).json({ message: `Error during ${logMessage} analysis.`, error: error.message });
+    }
+}
 
-    pythonProcess.on('close', (code) => {
-        if (code === 0) {
-            console.log('✅ Backend: Python e-waste script finished successfully.');
-            try {
-                const jsonData = JSON.parse(analysisResult);
-                res.status(200).json(jsonData);
-            } catch (e) {
-                console.error('❌ Backend: Error parsing JSON from Python script.', e);
-                res.status(500).json({ message: 'Failed to parse e-waste analysis result.' });
-            }
-        } else {
-            console.error(`❌ Backend: Python e-waste script exited with error code ${code}.`);
-            console.error(`- Python Error: ${errorOutput}`);
-            res.status(500).json({ message: 'Error during e-waste analysis.', error: errorOutput });
-        }
-    });
-});
+app.post('/api/analyze-footprint', (req, res) => handleJsonAnalysis(req, res, 'phantom_footprint_analyzer.py', 'Phantom Footprint'));
+app.post('/api/analyze-ewaste', (req, res) => handleJsonAnalysis(req, res, 'ewaste_analyzer.py', 'E-Waste'));
 
 // --- AQUALENS WATER ANALYSIS ENDPOINT ---
-app.post('/api/analyze-water', imageUpload.single('image'), async (req, res) => {
+app.post('/api/analyze-water', upload.single('image'), async (req, res) => {
     const startTime = Date.now();
 
     try {
@@ -388,19 +187,17 @@ app.post('/api/analyze-water', imageUpload.single('image'), async (req, res) =>
 
         console.log('✅ Image preprocessing completed');
 
-        // Step 2: Advanced preprocessing with C++ (if available)
-        let processedImagePath = preprocessedPath;
+        // Step 2: AI analysis with Python
+        let analysisResult;
         try {
-            processedImagePath = await callCppPreprocessing(preprocessedPath);
-            console.log('✅ C++ preprocessing completed');
+            analysisResult = await callPythonScript('water_analysis.py', [preprocessedPath, waterSource || 'unknown']);
+            console.log('✅ AI analysis completed');
         } catch (error) {
-            console.log('⚠️ C++ preprocessing not available, using Sharp preprocessing');
+            // If the python script fails, use the fallback.
+            console.log(`Python script for water analysis failed, using fallback. Error: ${error.message}`);
+            analysisResult = fallbackAnalysis(preprocessedPath, waterSource);
         }
 
-        // Step 3: AI analysis with Python
-        const analysisResult = await callPythonAnalysis(processedImagePath, waterSource);
-        console.log('✅ AI analysis completed');
-
         const processingTime = (Date.now() - startTime) / 1000;
 
         // Step 4: Determine overall quality and safety
@@ -466,7 +263,7 @@ app.post('/api/analyze-water', imageUpload.single('image'), async (req, res) =>
         }
 
         setTimeout(() => {
-            [preprocessedPath, processedImagePath].forEach(p => {
+            [preprocessedPath, imagePath].forEach(p => {
                 if (fs.existsSync(p) && p !== imagePath) {
                     fs.unlinkSync(p);
                 }
@@ -509,6 +306,8 @@ app.post('/api/analyze-water', imageUpload.single('image'), async (req, res) =>
             details: error.message,
             timestamp: new Date().toISOString()
         });
+    } finally {
+        if (req.file) fs.unlink(req.file.path, (err) => { if (err) console.error(`- Error deleting temp image file: ${err.message}`); });
     }
 });
 
@@ -525,8 +324,8 @@ app.get('/api/water-map', (req, res) => {
 const buildPath = path.join(__dirname, '..', 'web', 'build');
 app.use(express.static(buildPath));
 
-// The "catchall" handler: for any request that doesn't match one of our API routes,
-// send back the React app's index.html file. This allows React Router to handle the route.
+// The "catchall" handler: for any request that doesn't match an API route or a static file,
+// send back the main index.html file. This allows React Router to handle client-side routing.
 app.get('*', (req, res) => {
     res.sendFile(path.join(buildPath, 'index.html'));
 });