File size: 25,157 Bytes
dfefe0b | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 | diff --git a/docs/source/en/kv_cache.md b/docs/source/en/kv_cache.md
index ed6fb9035e0c..9e64cb9e039a 100644
--- a/docs/source/en/kv_cache.md
+++ b/docs/source/en/kv_cache.md
@@ -349,7 +349,7 @@ In case you are using Sink Cache, you have to crop your inputs to that maximum l
>>> user_prompts = ["Hello, what's your name?", "Btw, yesterday I was on a rock concert."]
>>> past_key_values = DynamicCache()
->>> max_cache_length = past_key_values.get_max_length()
+>>> max_cache_length = past_key_values.get_max_cache_shape()
>>> messages = []
>>> for prompt in user_prompts:
diff --git a/src/transformers/cache_utils.py b/src/transformers/cache_utils.py
index b2be3f238d0c..427e1d4e3aea 100644
--- a/src/transformers/cache_utils.py
+++ b/src/transformers/cache_utils.py
@@ -29,6 +29,8 @@ class Cache(torch.nn.Module):
Base, abstract class for all caches. The actual data structure is specific to each subclass.
"""
+ is_compileable = False
+
def __init__(self):
super().__init__()
@@ -1098,6 +1100,8 @@ class StaticCache(Cache):
```
"""
+ is_compileable = True
+
# TODO (joao): remove `=None` in non-optional arguments in v4.46. Remove from `OBJECTS_TO_IGNORE` as well.
@deprecate_kwarg("layer_device_map", version="4.52.0")
def __init__(
@@ -1297,6 +1301,7 @@ class SlidingWindowCache(StaticCache):
"""
is_sliding = True
+ is_compileable = True
# TODO (joao): remove `=None` in non-optional arguments in v4.46. Remove from `OBJECTS_TO_IGNORE` as well.
def __init__(
@@ -1421,6 +1426,7 @@ def __init__(self, self_attention_cache: Cache, cross_attention_cache: Cache):
super().__init__()
self.self_attention_cache = self_attention_cache
self.cross_attention_cache = cross_attention_cache
+ self.is_compileable = getattr(self.self_attention_cache, "is_compileable", False)
self.is_updated = {}
for layer_idx in range(len(cross_attention_cache.key_cache)):
@@ -1612,6 +1618,8 @@ class HybridCache(Cache):
```
"""
+ is_compileable = True
+
# TODO (joao): remove `=None` in non-optional arguments in v4.46. Remove from `OBJECTS_TO_IGNORE` as well.
@deprecate_kwarg("layer_device_map", version="4.52.0")
def __init__(
@@ -1832,6 +1840,8 @@ class MambaCache:
```
"""
+ is_compileable = True
+
# TODO (joao): remove `=None` in non-optional arguments in v4.46. Remove from `OBJECTS_TO_IGNORE` as well.
def __init__(
self,
@@ -1975,6 +1985,8 @@ class OffloadedStaticCache(StaticCache):
```
"""
+ is_compileable = True
+
@deprecate_kwarg("layer_device_map", version="4.52.0")
def __init__(
self,
diff --git a/src/transformers/generation/configuration_utils.py b/src/transformers/generation/configuration_utils.py
index 3f142ce77298..a0e96c31cb59 100644
--- a/src/transformers/generation/configuration_utils.py
+++ b/src/transformers/generation/configuration_utils.py
@@ -1579,7 +1579,7 @@ def construct_processor(self, vocab_size: int, device) -> "WatermarkLogitsProces
@dataclass
-class CompileConfig(object):
+class CompileConfig:
"""
Class that holds arguments relative to `torch.compile` behavior, when using automatic compilation in `generate`.
See [`torch.compile`](https://pytorch.org/docs/stable/generated/torch.compile.html) for more details on the arguments.
@@ -1620,7 +1620,9 @@ class CompileConfig(object):
backend: Union[str, Callable] = "inductor"
mode: str = "reduce-overhead"
options: Optional[dict] = None
+ # Used to flag our `generate` call to compile on e.g. CPU. Often not optimal, but useful for testing purposes.
+ _compile_all_devices = None
def to_dict(self) -> Dict[str, Any]:
"""Serializes this instance to a Python dictionary."""
- return copy.deepcopy(self.__dict__)
+ return copy.deepcopy({key: value for key, value in self.__dict__.items() if key != "_compile_all_devices"})
diff --git a/src/transformers/generation/utils.py b/src/transformers/generation/utils.py
index 94230d1b72fb..cb6ec15bb901 100644
--- a/src/transformers/generation/utils.py
+++ b/src/transformers/generation/utils.py
@@ -3177,9 +3177,11 @@ def _sample(
model_kwargs = self._get_initial_cache_position(input_ids, model_kwargs)
model_forward = self.__call__
- if isinstance(model_kwargs.get("past_key_values"), StaticCache):
- if self.device.type == "cuda":
- logger.warning_once("Using `torch.compile`.")
+ if isinstance(model_kwargs.get("past_key_values"), Cache):
+ is_compileable = model_kwargs["past_key_values"].is_compileable
+ if is_compileable and (
+ self.device.type == "cuda" or generation_config.compile_config._compile_all_devices
+ ):
os.environ["TOKENIZERS_PARALLELISM"] = "0"
model_forward = self.get_compiled_call(generation_config.compile_config)
diff --git a/src/transformers/models/aria/modeling_aria.py b/src/transformers/models/aria/modeling_aria.py
index 414301673552..c55d1feb6d9f 100644
--- a/src/transformers/models/aria/modeling_aria.py
+++ b/src/transformers/models/aria/modeling_aria.py
@@ -708,7 +708,7 @@ class AriaPreTrainedModel(PreTrainedModel):
_supports_flex_attn = True
_supports_cache_class = True
_supports_quantized_cache = True
- _supports_static_cache = True
+ _supports_static_cache = False # MoE models don't work with torch.compile (dynamic slicing)
_supports_attention_backend = False
def _init_weights(self, module):
@@ -1561,6 +1561,7 @@ def forward(
output_hidden_states=output_hidden_states,
return_dict=return_dict,
logits_to_keep=logits_to_keep,
+ cache_position=cache_position,
)
logits = outputs[0]
diff --git a/src/transformers/models/aria/modular_aria.py b/src/transformers/models/aria/modular_aria.py
index 5c40473a18f7..8bb79616ea95 100644
--- a/src/transformers/models/aria/modular_aria.py
+++ b/src/transformers/models/aria/modular_aria.py
@@ -1223,6 +1223,7 @@ def _init_weights(self, module):
class AriaPreTrainedModel(LlamaPreTrainedModel):
+ _supports_static_cache = False # MoE models don't work with torch.compile (dynamic slicing)
_supports_attention_backend = False
def _init_weights(self, module):
@@ -1535,6 +1536,7 @@ def forward(
output_hidden_states=output_hidden_states,
return_dict=return_dict,
logits_to_keep=logits_to_keep,
+ cache_position=cache_position,
)
logits = outputs[0]
diff --git a/src/transformers/models/dbrx/modeling_dbrx.py b/src/transformers/models/dbrx/modeling_dbrx.py
index 3230952bf5c7..41458ab6a361 100644
--- a/src/transformers/models/dbrx/modeling_dbrx.py
+++ b/src/transformers/models/dbrx/modeling_dbrx.py
@@ -833,6 +833,7 @@ class DbrxPreTrainedModel(PreTrainedModel):
_supports_sdpa = True
_supports_cache_class = True
_supports_quantized_cache = True
+ _supports_static_cache = False # MoE models don't work with torch.compile (`torch.where(condition)` not supported)
def _init_weights(self, module: nn.Module):
std = self.config.initializer_range
diff --git a/src/transformers/models/emu3/modeling_emu3.py b/src/transformers/models/emu3/modeling_emu3.py
index 6944f91b9758..b31e14910a9b 100644
--- a/src/transformers/models/emu3/modeling_emu3.py
+++ b/src/transformers/models/emu3/modeling_emu3.py
@@ -1802,6 +1802,7 @@ def forward(
class Emu3ForConditionalGeneration(Emu3PreTrainedModel, GenerationMixin):
_tied_weights_keys = ["text_model.lm_head.weight"]
+ _supports_static_cache = False # `get_image_tokens()`, called when `pixel_values` is passed, is not compileable
def __init__(self, config):
super().__init__(config)
diff --git a/src/transformers/models/emu3/modular_emu3.py b/src/transformers/models/emu3/modular_emu3.py
index 01d09b703d8e..d645a88baf38 100644
--- a/src/transformers/models/emu3/modular_emu3.py
+++ b/src/transformers/models/emu3/modular_emu3.py
@@ -1113,6 +1113,7 @@ def forward(**super_kwargs):
class Emu3ForConditionalGeneration(Emu3PreTrainedModel, GenerationMixin):
_tied_weights_keys = ["text_model.lm_head.weight"]
+ _supports_static_cache = False # `get_image_tokens()`, called when `pixel_values` is passed, is not compileable
def __init__(self, config):
super().__init__(config)
diff --git a/src/transformers/models/gpt_neox_japanese/modeling_gpt_neox_japanese.py b/src/transformers/models/gpt_neox_japanese/modeling_gpt_neox_japanese.py
index 6a9ae6b50f90..603b9f692241 100755
--- a/src/transformers/models/gpt_neox_japanese/modeling_gpt_neox_japanese.py
+++ b/src/transformers/models/gpt_neox_japanese/modeling_gpt_neox_japanese.py
@@ -52,7 +52,7 @@ class GPTNeoXJapanesePreTrainedModel(PreTrainedModel):
_skip_keys_device_placement = "past_key_values"
_supports_cache_class = True
_supports_quantized_cache = True
- _supports_static_cache = True
+ _supports_static_cache = False # TODO (fix me): compilation fails due to a stide error?
def _init_weights(self, module):
"""Initialize the weights"""
diff --git a/src/transformers/models/granitemoe/modeling_granitemoe.py b/src/transformers/models/granitemoe/modeling_granitemoe.py
index 306457d572e8..66aef05e67cb 100644
--- a/src/transformers/models/granitemoe/modeling_granitemoe.py
+++ b/src/transformers/models/granitemoe/modeling_granitemoe.py
@@ -843,6 +843,7 @@ class GraniteMoePreTrainedModel(PreTrainedModel):
_supports_sdpa = True
_supports_cache_class = True
_supports_quantized_cache = True
+ _supports_static_cache = False # MoE models don't work with torch.compile (`torch.where(condition)` not supported)
def _init_weights(self, module):
std = self.config.initializer_range
diff --git a/src/transformers/models/idefics/modeling_idefics.py b/src/transformers/models/idefics/modeling_idefics.py
index 3d0a956a7bf7..c59e05509d0d 100644
--- a/src/transformers/models/idefics/modeling_idefics.py
+++ b/src/transformers/models/idefics/modeling_idefics.py
@@ -917,6 +917,7 @@ class IdeficsPreTrainedModel(PreTrainedModel):
_no_split_modules = ["IdeficsDecoderLayer", "IdeficsGatedCrossAttentionLayer"]
_supports_sdpa = True
_supports_cache_class = True
+ _supports_static_cache = False # IDEFICS cannot compile due to dynamic control flow when checking inputs
def _init_weights(self, module):
# important: this ported version of Idefics isn't meant for training from scratch - only
diff --git a/src/transformers/models/mixtral/modeling_mixtral.py b/src/transformers/models/mixtral/modeling_mixtral.py
index 034ddba8c484..0d7bdb3394c9 100644
--- a/src/transformers/models/mixtral/modeling_mixtral.py
+++ b/src/transformers/models/mixtral/modeling_mixtral.py
@@ -485,7 +485,7 @@ class MixtralPreTrainedModel(PreTrainedModel):
_supports_flex_attn = True
_supports_cache_class = True
_supports_quantized_cache = True
- _supports_static_cache = True
+ _supports_static_cache = False # MoE models don't work with torch.compile (`torch.where(condition)` not supported)
_supports_attention_backend = True
def _init_weights(self, module):
diff --git a/src/transformers/models/mixtral/modular_mixtral.py b/src/transformers/models/mixtral/modular_mixtral.py
index a16e4c5a16d9..7890400934c6 100644
--- a/src/transformers/models/mixtral/modular_mixtral.py
+++ b/src/transformers/models/mixtral/modular_mixtral.py
@@ -45,7 +45,9 @@
MistralForSequenceClassification,
MistralForTokenClassification,
MistralModel,
+ MistralPreTrainedModel,
MistralRMSNorm,
+ MistralRotaryEmbedding,
)
from .configuration_mixtral import MixtralConfig
@@ -313,6 +315,14 @@ def forward(
return outputs
+class MixtralRotaryEmbedding(MistralRotaryEmbedding):
+ pass
+
+
+class MixtralPreTrainedModel(MistralPreTrainedModel):
+ _supports_static_cache = False # MoE models don't work with torch.compile (`torch.where(condition)` not supported)
+
+
class MixtralModel(MistralModel):
def __init__(self, config: MixtralConfig):
super().__init__(config)
diff --git a/src/transformers/models/olmoe/modeling_olmoe.py b/src/transformers/models/olmoe/modeling_olmoe.py
index 47126da95647..d1a9cdbce950 100644
--- a/src/transformers/models/olmoe/modeling_olmoe.py
+++ b/src/transformers/models/olmoe/modeling_olmoe.py
@@ -767,7 +767,7 @@ class OlmoePreTrainedModel(PreTrainedModel):
_supports_sdpa = True
_supports_cache_class = True
_supports_quantized_cache = True
- _supports_static_cache = True
+ _supports_static_cache = False # MoE models don't work with torch.compile (`torch.where(condition)` not supported)
def _init_weights(self, module):
std = self.config.initializer_range
diff --git a/src/transformers/models/phimoe/modeling_phimoe.py b/src/transformers/models/phimoe/modeling_phimoe.py
index ba4b76650730..5e0b95c4612d 100644
--- a/src/transformers/models/phimoe/modeling_phimoe.py
+++ b/src/transformers/models/phimoe/modeling_phimoe.py
@@ -912,7 +912,7 @@ class PhimoePreTrainedModel(PreTrainedModel):
_supports_sdpa = True
_supports_cache_class = True
_supports_quantized_cache = True
- _supports_static_cache = True
+ _supports_static_cache = False # MoE models don't work with torch.compile (`torch.where(condition)` not supported)
def _init_weights(self, module):
std = self.config.initializer_range
diff --git a/src/transformers/models/qwen2_5_vl/modeling_qwen2_5_vl.py b/src/transformers/models/qwen2_5_vl/modeling_qwen2_5_vl.py
index 2046deef0b3e..78a11176e192 100644
--- a/src/transformers/models/qwen2_5_vl/modeling_qwen2_5_vl.py
+++ b/src/transformers/models/qwen2_5_vl/modeling_qwen2_5_vl.py
@@ -332,7 +332,7 @@ class Qwen2_5_VLPreTrainedModel(PreTrainedModel):
_supports_flash_attn_2 = True
_supports_sdpa = True
_supports_cache_class = True
- _supports_static_cache = True
+ _supports_static_cache = False # TODO (joao): fix. torch.compile failing probably due to `cache_positions`
def _init_weights(self, module):
std = self.config.initializer_range
diff --git a/src/transformers/models/qwen2_vl/modeling_qwen2_vl.py b/src/transformers/models/qwen2_vl/modeling_qwen2_vl.py
index c680201f1923..dd0f80cc3e54 100644
--- a/src/transformers/models/qwen2_vl/modeling_qwen2_vl.py
+++ b/src/transformers/models/qwen2_vl/modeling_qwen2_vl.py
@@ -882,7 +882,7 @@ class Qwen2VLPreTrainedModel(PreTrainedModel):
_supports_flash_attn_2 = True
_supports_sdpa = True
_supports_cache_class = True
- _supports_static_cache = True
+ _supports_static_cache = False # TODO (joao): fix. torch.compile failing probably due to `cache_positions`
def _init_weights(self, module):
std = self.config.initializer_range
diff --git a/tests/generation/test_utils.py b/tests/generation/test_utils.py
index 6afafa8e65da..d9b4bbbe8c69 100644
--- a/tests/generation/test_utils.py
+++ b/tests/generation/test_utils.py
@@ -1978,52 +1978,82 @@ def test_generate_with_quant_cache(self):
model.generate(**generation_kwargs, **inputs_dict)
@pytest.mark.generate
- @require_torch_accelerator
- @slow
def test_generate_compile_model_forward(self):
"""
- Tests that `.generate` is compatible with torch.compile without graph breaks, keeping the same results. Tests
- end-to-end compilation and forward pass compilation only.
+ Tests that `.generate` is compatible with torch.compile without graph breaks, keeping the same results.
⚠️ Runs two sequential generations to ensure the cache doesn't get stuck after the first compiled run! ⚠️
"""
for model_class in self.all_generative_model_classes:
if not model_class._supports_static_cache:
- self.skipTest("This model doesn't support static cache")
+ self.skipTest("This model doesn't support static cache (= no expectations of compilation support)")
- config, inputs_dict = self.model_tester.prepare_config_and_inputs_for_common()
+ config, inputs_dict = self.prepare_config_and_inputs_for_generate(batch_size=4)
model = model_class(config).to(torch_device)
model.eval() # otherwise `self.training` is `True` -- this flag is used at attn mask creation time
- input_ids = inputs_dict["input_ids"].to(torch_device)
+ main_input = inputs_dict[model.main_input_name].to(torch_device)
# creates two sets of *different* inputs with the same shape
- half_batch_size = input_ids.shape[0] // 2
- input_ids_sets = [input_ids[:half_batch_size, :], input_ids[half_batch_size : half_batch_size * 2, :]]
- self.assertTrue(input_ids_sets[0].shape == input_ids_sets[1].shape)
+ half_batch_size = main_input.shape[0] // 2
+ input_1 = {}
+ input_2 = {}
+ for key, value in inputs_dict.items():
+ if isinstance(value, torch.Tensor):
+ input_1[key] = value[:half_batch_size, :].to(torch_device)
+ input_2[key] = value[half_batch_size : half_batch_size * 2, :].to(torch_device)
+ else:
+ input_1[key] = value
+ input_2[key] = value
+ model_input_sets = [input_1, input_2]
+ self.assertTrue(
+ model_input_sets[0][model.main_input_name].shape == model_input_sets[1][model.main_input_name].shape
+ )
+
+ # compilation-specific setup
+ torch.compiler.reset() # prevent cached compilation from being used in the test
+ has_defined_cache_implementation = model.generation_config.cache_implementation is not None
+ model.generation_config.compile_config._compile_all_devices = True # force compilation (e.g. fast CI, CPU)
generation_kwargs = {
"do_sample": False,
- "max_new_tokens": 10,
+ "max_new_tokens": 5,
"return_dict_in_generate": True,
"output_scores": True,
- "cache_implementation": "static",
}
# get eager + dynamic cache results for future comparison
dynamic_outputs = []
- for model_inputs in input_ids_sets:
- dynamic_outputs.append(model.generate(model_inputs, **generation_kwargs))
-
- # get compiled results
- generation_config = copy.deepcopy(model.generation_config)
- generation_config.update(**generation_kwargs)
- torch.compiler.reset()
+ for model_inputs in model_input_sets:
+ gen_out = model.generate(**model_inputs, **generation_kwargs)
+ dynamic_outputs.append(gen_out)
+ # sanity checks for the default cache implementation
+ if not has_defined_cache_implementation:
+ decoder_cache = (
+ gen_out.past_key_values.self_attention_cache
+ if config.is_encoder_decoder
+ else gen_out.past_key_values
+ )
+ self.assertTrue(isinstance(decoder_cache, DynamicCache))
+ self.assertFalse(decoder_cache.is_compileable)
+ self.assertFalse(hasattr(model, "_compiled_call")) # our auto compile should NOT have been called
- model.forward = torch.compile(model.forward, fullgraph=True, mode="reduce-overhead")
+ # get compiled results -- relies on the automatic compilation triggered by specific "cache_implementation"
+ if not has_defined_cache_implementation:
+ generation_kwargs["cache_implementation"] = "static"
compiled_outputs = []
- for model_inputs in input_ids_sets:
- compiled_outputs.append(model.generate(model_inputs, generation_config=generation_config))
+ for model_inputs in model_input_sets:
+ gen_out = model.generate(**model_inputs, **generation_kwargs)
+ compiled_outputs.append(gen_out)
+ # sanity checks
+ decoder_cache = (
+ gen_out.past_key_values.self_attention_cache
+ if config.is_encoder_decoder
+ else gen_out.past_key_values
+ )
+ self.assertFalse(isinstance(decoder_cache, DynamicCache))
+ self.assertTrue(decoder_cache.is_compileable)
+ self.assertTrue(hasattr(model, "_compiled_call")) # our auto compile should have been called
for dynamic_result, compiled_result in zip(dynamic_outputs, compiled_outputs):
self._check_similar_generate_outputs(dynamic_result, compiled_result)
diff --git a/tests/models/chameleon/test_modeling_chameleon.py b/tests/models/chameleon/test_modeling_chameleon.py
index f0d9107119fe..56cb9141d6b6 100644
--- a/tests/models/chameleon/test_modeling_chameleon.py
+++ b/tests/models/chameleon/test_modeling_chameleon.py
@@ -331,11 +331,6 @@ def test_model_rope_scaling(self, scaling_type):
def test_batching_equivalence(self):
pass
- # TODO (joao, raushan): fix me -- the problem is in `cache_position[0] == 0`, i.e. dynamic control flow
- @unittest.skip("Chameleon is not compatible with end-to-end generation compilation")
- def test_generate_compile_model_forward(self):
- pass
-
@require_torch
class ChameleonIntegrationTest(unittest.TestCase):
diff --git a/tests/models/dbrx/test_modeling_dbrx.py b/tests/models/dbrx/test_modeling_dbrx.py
index 556887bda1a9..a3d088e2160b 100644
--- a/tests/models/dbrx/test_modeling_dbrx.py
+++ b/tests/models/dbrx/test_modeling_dbrx.py
@@ -368,10 +368,6 @@ def test_disk_offload_safetensors(self):
def test_disk_offload_bin(self):
pass
- @unittest.skip("Dbrx does not support `torch.compile` with `fullgraph=True`.")
- def test_generate_compile_model_forward(self):
- pass
-
@require_torch
class DbrxModelIntegrationTest(unittest.TestCase):
diff --git a/tests/models/idefics/test_modeling_idefics.py b/tests/models/idefics/test_modeling_idefics.py
index 50b286ca51ab..01871e81b30e 100644
--- a/tests/models/idefics/test_modeling_idefics.py
+++ b/tests/models/idefics/test_modeling_idefics.py
@@ -780,10 +780,6 @@ def test_contrastive_generate_low_memory(self):
def test_custom_4d_attention_mask(self):
pass
- @unittest.skip(reason="IDEFICS cannot compile due to dynamic control flow when checking inputs")
- def test_generate_compile_model_forward(self):
- pass
-
@unittest.skip(reason="We only test the model that takes in multiple images")
def test_model(self):
pass
diff --git a/tests/models/qwen2_vl/test_modeling_qwen2_vl.py b/tests/models/qwen2_vl/test_modeling_qwen2_vl.py
index 18224c50bf16..8864185abf4f 100644
--- a/tests/models/qwen2_vl/test_modeling_qwen2_vl.py
+++ b/tests/models/qwen2_vl/test_modeling_qwen2_vl.py
@@ -332,10 +332,6 @@ def test_beam_search_low_memory(self):
def test_generate_from_inputs_embeds_with_static_cache(self):
pass
- @unittest.skip(reason="Can't compile fullgraph due to dynamic control flow in `prepare_inputs_for_generate`")
- def test_generate_compile_model_forward(self):
- pass
-
@require_torch
class Qwen2VLIntegrationTest(unittest.TestCase):
diff --git a/tests/models/whisper/test_modeling_whisper.py b/tests/models/whisper/test_modeling_whisper.py
index 80c4025c259c..ce30ea4eaeb0 100644
--- a/tests/models/whisper/test_modeling_whisper.py
+++ b/tests/models/whisper/test_modeling_whisper.py
@@ -1602,6 +1602,11 @@ def test_labels_sequence_max_length_error_after_changing_config(self):
with self.assertRaises(ValueError):
model(input_features=input_features, labels=labels)
+ # TODO (joao, eustache): fix me :)
+ @unittest.skip(reason="Whisper's custom generate is not consistent regarding the cache return types")
+ def test_generate_compile_model_forward(self):
+ pass
+
@require_torch
@require_torchaudio
diff --git a/tests/utils/test_cache_utils.py b/tests/utils/test_cache_utils.py
index d67b026638e9..6541dad8d016 100644
--- a/tests/utils/test_cache_utils.py
+++ b/tests/utils/test_cache_utils.py
@@ -364,7 +364,7 @@ def test_sink_cache_iterative_prompts(self):
input_ids = gen_out
# We went well beyond the cache length
- self.assertTrue(input_ids.shape[1] > cache.get_max_length() * 1.5)
+ self.assertTrue(input_ids.shape[1] > cache.get_max_cache_shape() * 1.5)
# And it still produces a coherent english
decoded = tokenizer.batch_decode(input_ids, skip_special_tokens=True)
|