patch

LoadBalancer.py

@@ -119,34 +119,55 @@ class LoadBalancer:
         logging.info(f"Updated instance {instance} with cache size {cache_size}")
 
     def download_music_to_best_instance(self, file_name):
-        """Downloads a music file to the first instance that has more free space on the self.instance_health list variable."""
+        """Downloads a music file to the instance with the most free space in self.instance_health."""
         best_instance = None
         max_free_space = -1
 
+        # Determine the instance with the most free space
         for instance_url, space_info in self.instances_health.items():
-            total_space = convert_to_gb(space_info['total'])
-            used_space = convert_to_gb(space_info['used'])
+            total_space = convert_to_gb(space_info.get('total', 0))
+            used_space = convert_to_gb(space_info.get('used', 0))
             free_space = total_space - used_space
 
             if free_space > max_free_space:
                 max_free_space = free_space
                 best_instance = instance_url
 
-        if best_instance:
+        if not best_instance:
+            logging.error("No suitable instance found for downloading the music.")
+            return {"error": "No suitable instance found for downloading the music."}
+
+        # Attempt to download music to the best instance
+        try:
             result = self.instances_api.download_music(best_instance, file_name)
+
+            # Check if the response is as expected
+            if not result or "music_id" not in result or "status" not in result:
+                logging.error(f"Unexpected response from instance {best_instance}: {result}")
+                return {
+                    "error": "Failed to retrieve valid download data from the instance.",
+                    "details": result if result else "Empty response"
+                }
+
+            # Prepare response with download progress URL
             music_id = result["music_id"]
             status = result["status"]
             progress_url = f'{best_instance}/api/get/progress/{music_id}'
+
             response = {
                 "music_id": music_id,
                 "status": status,
                 "progress_url": progress_url
             }
-
             return response
-        else:
-            logging.error("No suitable instance found for downloading the music.")
-            return {"error": "No suitable instance found for downloading the music."}
+
+        except Exception as e:
+            # Log network or API call-related errors
+            logging.error(f"Error downloading music to {best_instance}: {str(e)}")
+            return {
+                "error": "Error occurred during music download.",
+                "details": str(e)
+            }
 
     def find_music_path(self, title):
         """Find the path of the music in the indexed data based on the title."""