Michael Rabinovich Cursor commited on
Commit ·
380ae5d
1
Parent(s): b2e9d3a
dockerfile: drop github-api cache-bust ADD (now 403s, redundant for pinned SHA)
Browse filesThe `ADD https://api.github.com/.../commits/${SHA}` line existed only to
invalidate the pip layer when a floating ref moved. GitHub's API now
returns 403 on the HF build IP, failing the build at that step. With an
explicit SHA pinned in the ARG + install URL the pip layer is already
deterministic, so the line is removed. Re-pin by bumping CADGENBENCH_SHA.
Co-authored-by: Cursor <cursoragent@cursor.com>
- Dockerfile +6 -5
Dockerfile
CHANGED
|
@@ -50,11 +50,12 @@ RUN python -m ensurepip --upgrade \
|
|
| 50 |
# up latest, pre-v1); lock to a commit SHA at the v1 release for
|
| 51 |
# reproducible scores (see space-setup/post-gt-swap.md Stage F).
|
| 52 |
ARG CADGENBENCH_SHA=289a2fc
|
| 53 |
-
#
|
| 54 |
-
#
|
| 55 |
-
#
|
| 56 |
-
#
|
| 57 |
-
|
|
|
|
| 58 |
RUN python -m pip install --no-cache-dir \
|
| 59 |
"cadgenbench @ git+https://github.com/huggingface/cadgenbench.git@${CADGENBENCH_SHA}"
|
| 60 |
|
|
|
|
| 50 |
# up latest, pre-v1); lock to a commit SHA at the v1 release for
|
| 51 |
# reproducible scores (see space-setup/post-gt-swap.md Stage F).
|
| 52 |
ARG CADGENBENCH_SHA=289a2fc
|
| 53 |
+
# Pinned to an explicit commit SHA, so the pip layer below is already
|
| 54 |
+
# deterministic: changing the ARG changes the install command and busts
|
| 55 |
+
# the cached layer on its own. (We previously cache-busted with an
|
| 56 |
+
# `ADD https://api.github.com/.../commits/${SHA}`; GitHub's API now 403s
|
| 57 |
+
# on the build IP, failing the build, and it was redundant for a fixed
|
| 58 |
+
# SHA -- removed. Re-pin by bumping the ARG above, not via that ADD.)
|
| 59 |
RUN python -m pip install --no-cache-dir \
|
| 60 |
"cadgenbench @ git+https://github.com/huggingface/cadgenbench.git@${CADGENBENCH_SHA}"
|
| 61 |
|