joelniklaus HF Staff commited on
Commit
e569197
·
1 Parent(s): e621d55

fixed issue with average setups producing invalid results

Browse files
app/src/content/embeds/d3-benchmark-comparison.html CHANGED
@@ -825,9 +825,16 @@
825
  if (SETUPS && setupNames.length >= 2) {
826
  const avg = computeAverageData(parsed);
827
  avgDatasets = avg.datasets;
828
- parsedData = parsed.concat(avg.data);
829
- parsedData.columns = parsed.columns;
830
- if (currentSetup === AVG_SETUP_KEY) DATASETS = { ...avgDatasets };
 
 
 
 
 
 
 
831
  }
832
  filterData();
833
  metricKeys = detectMetrics(allData.columns);
 
825
  if (SETUPS && setupNames.length >= 2) {
826
  const avg = computeAverageData(parsed);
827
  avgDatasets = avg.datasets;
828
+ const hasAvgData = Object.values(avgDatasets).some(o => !o.baseline);
829
+ if (hasAvgData) {
830
+ parsedData = parsed.concat(avg.data);
831
+ parsedData.columns = parsed.columns;
832
+ if (currentSetup === AVG_SETUP_KEY) DATASETS = { ...avgDatasets };
833
+ } else {
834
+ const sel = container.querySelector('#setup-' + uid);
835
+ if (sel) { const o = sel.querySelector(`option[value="${AVG_SETUP_KEY}"]`); if (o) o.remove(); }
836
+ if (currentSetup === AVG_SETUP_KEY) { currentSetup = setupNames[0]; DATASETS = normalizeDatasets(SETUPS[currentSetup].datasets); if (sel) sel.value = currentSetup; }
837
+ }
838
  }
839
  filterData();
840
  metricKeys = detectMetrics(allData.columns);