Bring up advanced settings

app_dialogue.py

@@ -376,80 +376,78 @@ with gr.Blocks(title="AI Dad Jokes", theme=gr.themes.Base()) as demo:
                     clear_btn = gr.ClearButton([textbox, imagebox, chatbot], value="🧹 Clear")
                     regenerate_btn = gr.Button(value="🔄 Regenerate", visible=True)
                     upload_btn = gr.UploadButton("📁 Upload image", file_types=["image"],visible=False)
+            with gr.Accordion("Advanced settings", open=False, visible=True) as parameter_row:
+                system_prompt = gr.Textbox(
+                    value=SYSTEM_PROMPT,
+                    visible=False,
+                    lines=20,
+                    max_lines=50,
+                    interactive=True,
+                )
+                max_new_tokens = gr.Slider(
+                    minimum=8,
+                    maximum=256,
+                    value=64,
+                    step=1,
+                    interactive=True,
+                    label="Maximum number of new tokens to generate",
+                )
+                repetition_penalty = gr.Slider(
+                    minimum=0.0,
+                    maximum=5.0,
+                    value=1.2,
+                    step=0.01,
+                    interactive=True,
+                    label="Repetition penalty",
+                    info="1.0 is equivalent to no penalty",
+                )
+                decoding_strategy = gr.Radio(
+                    [
+                        "Greedy",
+                        "Top P Sampling",
+                    ],
+                    value="Top P Sampling",
+                    label="Decoding strategy",
+                    interactive=True,
+                    info="Higher values is equivalent to sampling more low-probability tokens.",
+                )
+                temperature = gr.Slider(
+                    minimum=0.0,
+                    maximum=5.0,
+                    value=0.6,
+                    step=0.1,
+                    interactive=True,
+                    visible=True,
+                    label="Sampling temperature",
+                    info="Higher values will produce more diverse outputs.",
+                )
+                decoding_strategy.change(
+                    fn=lambda selection: gr.Slider.update(
+                        visible=(
+                            selection in ["contrastive_sampling", "beam_sampling", "Top P Sampling", "sampling_top_k"]
+                        )
+                    ),
+                    inputs=decoding_strategy,
+                    outputs=temperature,
+                )
+                top_p = gr.Slider(
+                    minimum=0.01,
+                    maximum=0.99,
+                    value=0.8,
+                    step=0.01,
+                    interactive=True,
+                    visible=True,
+                    label="Top P",
+                    info="Higher values is equivalent to sampling more low-probability tokens.",
+                )
+                decoding_strategy.change(
+                    fn=lambda selection: gr.Slider.update(visible=(selection in ["Top P Sampling"])),
+                    inputs=decoding_strategy,
+                    outputs=top_p,
+                )
         with gr.Column():
             chatbot.render()
 
-    with gr.Row():
-        with gr.Accordion("Advanced settings", open=False, visible=True) as parameter_row:
-            system_prompt = gr.Textbox(
-                value=SYSTEM_PROMPT,
-                visible=False,
-                lines=20,
-                max_lines=50,
-                interactive=True,
-            )
-            max_new_tokens = gr.Slider(
-                minimum=8,
-                maximum=256,
-                value=64,
-                step=1,
-                interactive=True,
-                label="Maximum number of new tokens to generate",
-            )
-            repetition_penalty = gr.Slider(
-                minimum=0.0,
-                maximum=5.0,
-                value=1.2,
-                step=0.01,
-                interactive=True,
-                label="Repetition penalty",
-                info="1.0 is equivalent to no penalty",
-            )
-            decoding_strategy = gr.Radio(
-                [
-                    "Greedy",
-                    "Top P Sampling",
-                ],
-                value="Top P Sampling",
-                label="Decoding strategy",
-                interactive=True,
-                info="Higher values is equivalent to sampling more low-probability tokens.",
-            )
-            temperature = gr.Slider(
-                minimum=0.0,
-                maximum=5.0,
-                value=0.6,
-                step=0.1,
-                interactive=True,
-                visible=True,
-                label="Sampling temperature",
-                info="Higher values will produce more diverse outputs.",
-            )
-            decoding_strategy.change(
-                fn=lambda selection: gr.Slider.update(
-                    visible=(
-                        selection in ["contrastive_sampling", "beam_sampling", "Top P Sampling", "sampling_top_k"]
-                    )
-                ),
-                inputs=decoding_strategy,
-                outputs=temperature,
-            )
-            top_p = gr.Slider(
-                minimum=0.01,
-                maximum=0.99,
-                value=0.8,
-                step=0.01,
-                interactive=True,
-                visible=True,
-                label="Top P",
-                info="Higher values is equivalent to sampling more low-probability tokens.",
-            )
-            decoding_strategy.change(
-                fn=lambda selection: gr.Slider.update(visible=(selection in ["Top P Sampling"])),
-                inputs=decoding_strategy,
-                outputs=top_p,
-            )
-
     def model_inference(
         model_selector,
         system_prompt,