Fix: a public model repo needs no token -- is_available/download no longer hide BarScript when no HF_TOKEN secret is set

softchart/sc2_loader.py

@@ -298,9 +298,12 @@ def download_from_hub(repo_id=None, revision=None, token=None):
     """
     repo_id = repo_id or hub_repo_id()
     revision = revision or os.environ.get("SC2_REPO_REVISION") or None
+    # The repo is PUBLIC, so a token is optional.  Refusing before the request
+    # (as this did while it was private) turns "no credential configured" into
+    # "model unavailable" on every deployment without a secret.  Try the
+    # download; _no_token_error is raised only if the Hub actually refuses,
+    # which is when the credential really is the problem.
     resolved = resolve_token(token)
-    if resolved is None:
-        raise _no_token_error(repo_id)
     try:
         from huggingface_hub import snapshot_download
     except ImportError as exc:
@@ -312,6 +315,14 @@ def download_from_hub(repo_id=None, revision=None, token=None):
                                  revision=revision, token=resolved,
                                  allow_patterns=list(PACKAGE_FILES))
     except Exception as exc:  # noqa: BLE001 -- re-raised as PackageError
+        # 401/403/404 with no credential in hand: the repo is private (or was
+        # made private again) and this IS a credentials problem -- say so with
+        # the actionable message instead of a bare transport error.
+        denied = any(t in f"{type(exc).__name__} {exc}"
+                     for t in ("401", "403", "404", "RepositoryNotFound",
+                               "GatedRepo", "Unauthorized"))
+        if denied and resolved is None:
+            raise _no_token_error(repo_id) from exc
         raise _hub_download_error(repo_id, exc) from exc
     missing = [n for n in REQUIRED_FILES
                if not os.path.isfile(os.path.join(path, n))]
@@ -1045,7 +1056,15 @@ def is_available(package_dir=None):
         return True
     offline = os.environ.get("HF_HUB_OFFLINE", "").strip().lower() \
         in ("1", "true", "yes")
-    return (not offline) and resolve_token() is not None
+    if offline:
+        return False
+    # A PUBLIC repo needs no token.  Requiring one here (as this did while the
+    # repo was private) silently drops the entry from the model list on any
+    # deployment without a secret -- which is exactly the failure mode this
+    # function's docstring says to avoid.  Offer it whenever the Hub is
+    # reachable at all; download_from_hub still raises a named error if the
+    # repo turns out to be private and no credential is present.
+    return True
 
 
 __all__ = ["SoftChart2", "SlotExportError", "PackageError", "load",