Update graph_merged_simple.py

graph_merged_simple.py

@@ -594,22 +594,19 @@ def run_qa_agent(state: AgentState) -> Dict[str, Any]:
             **add_status("QA", "Approved (Lite tier)")
         }
     
-    # Check if at limit
+    # CRITICAL FIX: Check if at limit BEFORE trying to rework
     if rework_cycles >= max_rework:
+        log.warning(f"Rework limit reached ({rework_cycles}/{max_rework}), auto-approving")
         return {
             "approved": True,
-            **add_status("QA", "Limit reached - approved")
+            **add_status("QA", f"Approved (limit reached: {rework_cycles}/{max_rework})")
         }
     
     # QA review
     prompt = f"""Review this response against user request.
-
 REQUEST: {user_input}
-
 RESPONSE: {draft[:1000]}
-
 Is this complete and satisfactory? Reply APPROVED or provide specific feedback.
-
 REVIEW:"""
     
     try:
@@ -622,11 +619,15 @@ REVIEW:"""
                 **add_status("QA", "Approved")
             }
         else:
+            # Increment rework counter
+            new_cycles = rework_cycles + 1
+            log.info(f"QA requesting rework (cycle {new_cycles}/{max_rework})")
+            
             return {
                 "approved": False,
                 "qaFeedback": content[:500],
-                "rework_cycles": rework_cycles + 1,
-                **add_status("QA", f"Rework needed (cycle {rework_cycles + 1})")
+                "rework_cycles": new_cycles,
+                **add_status("QA", f"Rework needed (cycle {new_cycles}/{max_rework})")
             }
     except Exception as e:
         log.error(f"QA failed: {e}")
@@ -745,16 +746,18 @@ def should_rework(state: AgentState) -> str:
         else:
             return "archive"
     else:
-        # Check if can rework
+        # CRITICAL FIX: Check the rework cycles BEFORE incrementing
         cycles = state.get('rework_cycles', 0)
         max_cycles = state.get('max_rework_cycles', 0)
         
-        if cycles >= max_cycles:
+        # Add 1 because we're about to do another rework
+        if cycles + 1 >= max_cycles:
+            log.warning(f"Rework limit reached ({cycles + 1}/{max_cycles}), forcing approval")
             return "archive"  # Force completion
         else:
+            log.info(f"Rework cycle {cycles + 1}/{max_cycles}")
             return "planning"  # Rework
 
-
 def route_execution_mode(state: AgentState) -> str:
     """Route based on execution mode."""
     mode = state.get('execution_mode', 'coding')
@@ -971,19 +974,24 @@ def execute_request(user_input: str, session_id: str = None,
         "budget_limit": tier_config["max_cost"] or float('inf')
     }
     
-    # Select appropriate graph
+    # Select appropriate graph and set recursion limit
+    # CRITICAL: Recursion limits prevent infinite loops
     if preferred_tier == cfg.TIER_LITE:
         app = lite_app
+        recursion_limit = 10  # Lite: ~3-5 nodes
     elif preferred_tier == cfg.TIER_FULL:
         app = full_app
+        recursion_limit = 100  # Full: up to 3 reworks = ~40 nodes max
     else:
         app = standard_app
+        recursion_limit = 30  # Standard: up to 1 rework = ~15-20 nodes
     
-    log.info(f"🚀 Executing with {preferred_tier} tier")
+    log.info(f"🚀 Executing with {preferred_tier} tier (recursion_limit={recursion_limit})")
     
-    # Execute graph
+    # Execute graph with recursion limit config
     try:
-        final_state = app.invoke(initial_state)
+        config = {"recursion_limit": recursion_limit}
+        final_state = app.invoke(initial_state, config=config)
         return final_state
     except Exception as e:
         log.exception(f"Execution failed: {e}")
@@ -993,7 +1001,6 @@ def execute_request(user_input: str, session_id: str = None,
             "approved": False
         }
 
-
 # =============================================================================
 # SECTION 10: LEGACY COMPATIBILITY
 # =============================================================================