Update app.py

app.py

@@ -3,74 +3,104 @@ import gradio as gr
 import requests
 import json
 
-# Retrieve the API token from secrets
+# Constants
+API_URL = "https://api-inference.huggingface.co/models/mistralai/Mistral-7B-Instruct-v0.3"
+MAX_NEW_TOKENS = 500  # Increased to handle longer inputs
+TEMPERATURE = 0.5
+TOP_P = 0.9
+
+# Retrieve the API token from environment variables
 api_token = os.getenv("API_TOKEN")
 if not api_token:
-    raise ValueError("API token not found. Make sure 'API_TOKEN' is set in the Secrets.")
+    raise ValueError("API token not found. Make sure 'API_TOKEN' is set in the environment variables.")
 
-# Use the token in your request headers
-API_URL = "https://api-inference.huggingface.co/models/mistralai/Mistral-7B-Instruct-v0.3"
 HEADERS = {"Authorization": f"Bearer {api_token}"}
 
-def analyze_figure_of_speech(verse):
-    if not verse.strip():
-        return "Please enter a Bible verse."
+def analyze_figure_of_speech(text: str) -> str:
+    """
+    Analyze the figures of speech in a given Bible text using a Hugging Face model.
+    
+    Args:
+        text (str): The Bible text to analyze.
     
-    # Construct a prompt to instruct the model to analyze figures of speech in the verse.
-    prompt = f"""<s>[INST] You are JR-Sacred Syntax, an expert biblical scholar specializing in Bible analysis.
-    Analyze the following Bible verse to identify any figures of speech (e.g., Metaphor, Synecdoche, Hyperbole, Simile, Paradox, and others).
-    Return your answer as a JSON array where each element includes:
-    - "verses": the Bible verse in NJV,
-    - "figure": the type of figure of speech,
-    - "definition": define the figure of speech you identified, 
-    - "phrase": the exact phrase from the verse,
-    - "explanation": a brief explanation in the biblical context.
-    Bible Verse: "{verse}"
-    [/INST] Figures: </s>"""
+    Returns:
+        str: Analysis result formatted as text or error message.
+    """
+    if not text.strip():
+        return "Please enter a Bible verse or passage."
+    
+    # Construct the prompt for the model
+    prompt = (
+        f"""<s>[INST] You are JR-Sacred Syntax, an expert biblical scholar specializing in Bible analysis.
+        Analyze the following Bible passage to identify any figures of speech (e.g., Metaphor, Synecdoche, Hyperbole, Simile, Paradox, and others).
+        Return your answer as a JSON array where each element includes:
+        - "verses": the Bible verse(s) in NJV,
+        - "figure": the type of figure of speech,
+        - "definition": define the figure of speech you identified,
+        - "phrase": the exact phrase from the verse,
+        - "explanation": a brief explanation in the biblical context.
+        Bible Passage: "{text}"
+        [/INST] Figures: </s>"""
+    )
 
-    payload = {"inputs": prompt, "parameters": {"max_new_tokens": 250, "temperature": 0.5, "top_p": 0.9}}
+    payload = {
+        "inputs": prompt,
+        "parameters": {
+            "max_new_tokens": MAX_NEW_TOKENS,
+            "temperature": TEMPERATURE,
+            "top_p": TOP_P
+        }
+    }
     
     try:
+        # Send request to Hugging Face API
         response = requests.post(API_URL, headers=HEADERS, json=payload)
         response.raise_for_status()
+        
         result = response.json()
         
         if isinstance(result, list) and len(result) > 0:
             generated_text = result[0].get("generated_text", "")
-            marker = "Figures:"  # Marker to help extract the output
+            marker = "Figures:"
+            
             if marker in generated_text:
                 generated_text = generated_text.split(marker, 1)[1].strip()
+            
             try:
                 output_json = json.loads(generated_text)
-                if isinstance(output_json, list):  # Ensure it's a list
-                    # Extract and format only the values, skipping keys
+                if isinstance(output_json, list):
+                    # Format output for readability
                     formatted_output = "\n\n".join(
+                        f"Verse(s): {item.get('verses', '')}\n"
                         f"Figure: {item.get('figure', '')}\n"
+                        f"Definition: {item.get('definition', '')}\n"
                         f'Phrase: "{item.get("phrase", "")}"\n'
                         f"Explanation: {item.get('explanation', '')}"
                         for item in output_json
                     )
                     return formatted_output
                 else:
-                    return json.dumps(output_json, indent=2)  # Fallback to JSON formatting
+                    return json.dumps(output_json, indent=2)
             except json.JSONDecodeError:
                 return generated_text
         else:
             return "Error: Unexpected response format."
+    
     except requests.exceptions.RequestException as e:
         return f"API Error: {e}"
 
+# Gradio Interface setup
 demo = gr.Interface(
     fn=analyze_figure_of_speech,
     inputs=gr.Textbox(
-        label="Enter Bible Verse", 
-        placeholder="e.g., 'I am the vine, you are the branches' - John 15:5", 
-        lines=3
+        label="Enter Bible Verse(s) or Passage",
+        placeholder="e.g., 'I am the vine, you are the branches' - John 15:5 or multiple verses separated by newline",
+        lines=10  # Increased to allow input of multiple verses
     ),
     outputs=gr.Textbox(label="Figures of Speech Analysis"),
     title="JR-Sacred Syntax: Bible Figures of Speech Detector",
-    description="Enter a Bible verse to detect and analyze figures of speech with detailed biblical explanations."
+    description="Enter a Bible verse or passage to detect and analyze figures of speech with detailed biblical explanations."
 )
 
 if __name__ == "__main__":
-    demo.launch()
+    demo.launch()