Upload hub_dashboard.html

hub_dashboard.html

@@ -1531,47 +1531,13 @@ td.rc {
     });
 
     // ── Trade detection ──────────────────────────────────────────────────────
-    // We watch two independent signals:
-    //   Signal A: messages_rx counter increments (server-side op processed)
-    //   Signal B: new unique last_updated timestamps appear in _rankings feed
-    // Either triggers the alert. Both are checked after every refresh() call.
-
-    let _prevMsgRx    = 0;
-    let _seenTimestamps = new Set();
-    let _firstRefresh   = true;
+    // Sound fires ONLY when a genuinely new trade_id appears in the Open
+    // Positions panel (/api/trades → data.open[]).  Detection runs inside
+    // updateTerminal() which owns the canonical open-positions data.
+    // _onTradeRefresh is kept as a no-op stub so call-sites don't break.
 
     window._onTradeRefresh = function(rankings, health) {
-        // ── Signal A: message counter ────────────────────────────────────────
-        const msgRx = (health && health.messages_rx) || 0;
-        if (!_firstRefresh && msgRx > _prevMsgRx) {
-            window.playTradeSound();
-        }
-        _prevMsgRx = msgRx;
-
-        // ── Signal B: new last_updated timestamps in feed ────────────────────
-        let newTrade = false;
-        if (rankings && rankings.length) {
-            for (const r of rankings) {
-                if (!r.last_updated) continue;
-                const key = r.space_name + ':' + r.last_updated;
-                if (!_seenTimestamps.has(key)) {
-                    if (!_firstRefresh) newTrade = true;
-                    _seenTimestamps.add(key);
-                    // Prune set — keep only latest 500 keys to avoid memory growth
-                    if (_seenTimestamps.size > 500) {
-                        const oldest = [..._seenTimestamps][0];
-                        _seenTimestamps.delete(oldest);
-                    }
-                }
-            }
-        }
-
-        // Only fire once even if both signals trigger on same refresh cycle
-        if (!_firstRefresh && newTrade && msgRx <= _prevMsgRx) {
-            window.playTradeSound();
-        }
-
-        _firstRefresh = false;
+        // intentionally empty — sound is now driven by open-position diff only
     };
 
     console.log('[TradeAudio] Engine initialised — waiting for user gesture to unlock AudioContext');
@@ -3016,6 +2982,26 @@ async function updateTerminal() {
   const closed = data.closed || [];
   const stats  = data.stats  || {};
 
+  // ── Open-position trade alert ───────────────────────────────────────────────
+  // Sound fires once per genuinely new trade_id that appears in open[].
+  // _prevOpenTradeIds is module-scoped so it persists across polling cycles.
+  if (typeof window._prevOpenTradeIds === 'undefined') {
+    // First call — seed the set silently (don't alert on existing positions)
+    window._prevOpenTradeIds = new Set(open.map(t => t.trade_id).filter(Boolean));
+  } else {
+    let hasNewTrade = false;
+    const nextIds = new Set();
+    for (const t of open) {
+      if (!t.trade_id) continue;
+      nextIds.add(t.trade_id);
+      if (!window._prevOpenTradeIds.has(t.trade_id)) {
+        hasNewTrade = true;  // brand-new trade_id not seen before
+      }
+    }
+    if (hasNewTrade) window.playTradeSound();
+    window._prevOpenTradeIds = nextIds;  // update to current snapshot
+  }
+
   // ── KPI strip ──────────────────────────────────────────────────────────────
   const totalPnl    = stats.total_pnl || 0;
   const totalClosed = stats.total_closed || 0;