Update app.py

app.py

@@ -3,51 +3,31 @@ from llama_cpp import Llama
 from huggingface_hub import hf_hub_download
 import time
 
-# --- Configuration ---
 MODEL_REPO = "Kezovic/iris-q4gguf-nitrallora"
 MODEL_FILE = "Llama-3.2-1B-Instruct.Q4_K_M.gguf"
 CONTEXT_WINDOW = 2048
 MAX_NEW_TOKENS = 400
 TEMPERATURE = 1.5 
 
-# --- Model Loading ---
-llm_generator = None
-llm_analyst = None
-
-def load_llm():
-    global llm_generator, llm_analyst
-    llm = None
-    print("Downloading model...")
-    try:
-        model_path = hf_hub_download(repo_id=MODEL_REPO, filename=MODEL_FILE)
-        
-        # Function to create a Llama instance
-        def create_llama_instance():
-            return Llama(
+def create_llama_instance():
+    return Llama(
                 model_path=model_path,
                 n_ctx=CONTEXT_WINDOW,
                 n_threads=2,
                 verbose=False,
                 min_p = 0.1
-            )
-
-        # 1. Load Generator LLM
-        print("Loading LLM Generator instance...")
-        llm_generator = create_llama_instance()
-        print("LLM Generator loaded.")
-
-        # 2. Load Analyst LLM
-        print("Loading LLM Analyst instance...")
-        llm_analyst = create_llama_instance()
-        print("LLM Analyst loaded.")
+    )
+    
+def load_llm():
+    
+    model_path = hf_hub_download(repo_id=MODEL_REPO, filename=MODEL_FILE)
+    llm_generator = create_llama_instance()
+    llm_analyst = create_llama_instance()
 
-        print("Both models loaded successfully!")
-    except Exception as e:
-        print(f"Error loading model: {e}")
+    return llm_generator, llm_analyst
 
-load_llm()
+llm_generator, llm_analyst = load_llm()
 
-# --- Persona and Format Maps (Hardened Constraints) ---
 persona_map = {
         "Grumpy Pirate": "You are a grumpy and annoyed pirate captain. Use salty nautical slang, complain about the sea and use 'Arrr' and 'matey'.",
         "Philosopher": "You are a philosopher. Use metaphors and reflective musings about the human condition.",
@@ -57,7 +37,6 @@ persona_map = {
 }
 
 format_map = {
-
         "Free Verse": "Write in Free Verse about the topic. Focus on vivid imagery and emotion.",
         "Ballad": "Write a Ballad about the topic. It should tell a narrative story with a clear beginning, middle, and end. Use four-line stanzas (quatrains) and a simple rhyme scheme like A-B-C-B. Keep the language simple and musical.",
         "Ode": "Write an Ode about the topic. Use elevated, expressive language to praise or celebrate the subject. Focus on strong emotion, rich imagery, and admiration.",
@@ -66,19 +45,8 @@ format_map = {
         "Epic": "Write an Epic about the topic. Use grand, dramatic language."
 }
 
-# --- Refinement Instruction Map ---
-REFINEMENT_INSTRUCTIONS = {
-    "Make it Shorter": "Rewrite the poem to be significantly shorter, reducing the line count by at least 3 lines, while keeping the core meaning.",
-    "Use Flowery Language": "Rewrite the poem using highly elaborate, decorative, and verbose language with many adjectives and metaphors.",
-    "Make it More Intense": "Rewrite the poem with greater emotional intensity. Use stronger, more dramatic vocabulary and imagery.",
-    "Add a Title": "Rewrite the poem and include an original, appropriate title at the very beginning, followed by the poem text.",
-    "Be More Humorous": "Rewrite the poem to be more light-hearted and humorous. Add a punchline or witty observation."
-}
-
-
-# --- Prompt Construction Helper Function (Simplified) ---
 def build_poem_prompt(voice_instruction, constraint_instruction, format_type, topic):
-    """Constructs a simple, direct prompt for initial poem generation."""
+    
     full_instruction = (
         f"Instruction:\n"
         f"{voice_instruction}\n"
@@ -87,12 +55,7 @@ def build_poem_prompt(voice_instruction, constraint_instruction, format_type, to
     )
     return full_instruction
 
-# --- LLM Function: Step 1 (Generate Poem) ---
 def generate_poem(format_type, persona, topic, progress=gr.Progress()):
-    if not llm_generator:
-        return "Error: Generator model not loaded."
-    if not topic:
-        return "Please enter a topic!"
     
     progress(0, desc="Consulting the Muse...")
     time.sleep(0.2)
@@ -114,12 +77,7 @@ def generate_poem(format_type, persona, topic, progress=gr.Progress()):
     progress(1.0, desc="Poem draft complete!")
     return poem_text
 
-# --- LLM Function: Step 2 (Analyze Poem - SIMPLIFIED) ---
 def analyze_poem(poem_text, progress=gr.Progress()):
-    if not llm_analyst:
-        return "Error: Analyst model not loaded."
-    if not poem_text or poem_text.startswith("Error:"):
-        return "Please generate a valid poem first!"
 
     progress(0, desc="Analyzing style for literary match...")
     time.sleep(0.2)
@@ -140,50 +98,10 @@ def analyze_poem(poem_text, progress=gr.Progress()):
     progress(1.0, desc="Analysis complete!")
     return poet_suggestion
 
-# --- LLM Function: Step 3 (Refine Poem - MODIFIED SIGNATURE FOR GRADIO) ---
-# NOTE: This function now accepts an *explicit* instruction string, which Gradio will bind.
-def refine_poem(poem_text, refinement_instruction, progress=gr.Progress()):
-    if not llm_generator:
-        return "Error: Generator model not loaded."
-    if not poem_text or poem_text.startswith("Error:"):
-        return "Please generate a valid poem first before refining it!"
-    
-    progress(0, desc=f"Applying refinement: {refinement_instruction}...")
-    time.sleep(0.2)
-
-    # Combined instruction for refinement
-    refinement_prompt = (
-        f"You are a highly disciplined creative writer. Your task is to revise the following poem based ONLY on the REVISION INSTRUCTION.\n"
-        f"REVISION INSTRUCTION: {refinement_instruction}\n"
-        f"Your output must contain ONLY the revised poem text, nothing else.\n\n"
-        f"ORIGINAL POEM:\n{poem_text}\n\n"
-        f"REVISED POEM: "
-    )
-    
-    output = llm_generator(
-        prompt=refinement_prompt,
-        max_tokens=MAX_NEW_TOKENS,
-        temperature=TEMPERATURE,
-        stop=["ORIGINAL POEM:", "\n\n\n"],
-        echo=False
-    )
-    
-    # Clean up output
-    revised_poem_text = output['choices'][0]['text'].strip()
-    
-    # Simple check to remove the REVISED POEM: marker if the model echoes it
-    if revised_poem_text.startswith("REVISED POEM:"):
-        revised_poem_text = revised_poem_text[len("REVISED POEM:"):].strip()
-        
-    progress(1.0, desc="Refinement complete!")
-    return revised_poem_text
-
-# --- UI Layout ---
 with gr.Blocks(title="The Poetry Workshop", theme=gr.themes.Soft()) as demo:
-    gr.Markdown("# 🖋️ The Poetry Workshop - Collaborative Analyst")
+    gr.Markdown("# The Poetry Workshop - Collaborative Analyst")
     gr.Markdown("Generate a poem based on a topic and persona, then use the separate buttons to analyze or refine the output.")
     
-    ## 📝 Poem Generation Controls
     with gr.Group():
         with gr.Row(equal_height=True):
             gr.Markdown("### I want to write a ")
@@ -212,12 +130,11 @@ with gr.Blocks(title="The Poetry Workshop", theme=gr.themes.Soft()) as demo:
                 show_label=False,
                 scale=5
             )
-            generate_btn = gr.Button("✨ Create Poem Draft", variant="primary", scale=1)
+            generate_btn = gr.Button("Create Poem Draft", variant="primary", scale=1)
     
     gr.Markdown("---")
     
-    ## 🔍 Analysis Section
-    analyze_btn = gr.Button("🔍 Analyze This Poem", variant="secondary")
+    analyze_btn = gr.Button("Analyze This Poem", variant="secondary")
     
     with gr.Row():
         output_display = gr.Textbox(
@@ -228,7 +145,7 @@ with gr.Blocks(title="The Poetry Workshop", theme=gr.themes.Soft()) as demo:
         )
                 
         poet_suggestion_display = gr.Textbox(
-            label="Literary Analysis: Suggested Poet",
+            label="Literary Analysis",
             lines=12,
             interactive=False,
             placeholder="Click 'Analyze This Poem' to run the LLM analysis."
@@ -236,72 +153,17 @@ with gr.Blocks(title="The Poetry Workshop", theme=gr.themes.Soft()) as demo:
 
     gr.Markdown("---")
     
-    ## ⚙️ Poem Refinement Section
-    with gr.Group():
-        gr.Markdown("### Refine Poem")
-        gr.Markdown("Click a button below to automatically revise the current poem in the **'Your Poem'** box.")
-        
-        # NOTE: Buttons are created but we will reference them explicitly below
-        buttons_refinement = {}
-        with gr.Row():
-            for label in REFINEMENT_INSTRUCTIONS.keys():
-                # Store the button object in the dictionary for later reference
-                buttons_refinement[label] = gr.Button(label, scale=1, variant="light")
-    
-    # --- Event Handling ---
-    
-    # 1. Initial Generation
     generate_btn.click(
         fn=generate_poem,
         inputs=[format_dropdown, persona_dropdown, topic_input],
         outputs=[output_display] 
     )
     
-    # 2. Analysis
     analyze_btn.click(
         fn=analyze_poem,
         inputs=[output_display], 
         outputs=poet_suggestion_display
     )
 
-    # 3. Refinement Events (Rewritten to remove lambda)
-    
-    # Create explicit functions for each button click, passing the desired instruction
-    
-    # Make it Shorter
-    buttons_refinement["Make it Shorter"].click(
-        fn=refine_poem,
-        inputs=[output_display, gr.State(REFINEMENT_INSTRUCTIONS["Make it Shorter"])],
-        outputs=[output_display]
-    )
-
-    # Use Flowery Language
-    buttons_refinement["Use Flowery Language"].click(
-        fn=refine_poem,
-        inputs=[output_display, gr.State(REFINEMENT_INSTRUCTIONS["Use Flowery Language"])],
-        outputs=[output_display]
-    )
-    
-    # Make it More Intense
-    buttons_refinement["Make it More Intense"].click(
-        fn=refine_poem,
-        inputs=[output_display, gr.State(REFINEMENT_INSTRUCTIONS["Make it More Intense"])],
-        outputs=[output_display]
-    )
-    
-    # Add a Title
-    buttons_refinement["Add a Title"].click(
-        fn=refine_poem,
-        inputs=[output_display, gr.State(REFINEMENT_INSTRUCTIONS["Add a Title"])],
-        outputs=[output_display]
-    )
-    
-    # Be More Humorous
-    buttons_refinement["Be More Humorous"].click(
-        fn=refine_poem,
-        inputs=[output_display, gr.State(REFINEMENT_INSTRUCTIONS["Be More Humorous"])],
-        outputs=[output_display]
-    )
-
 if __name__ == "__main__":
     demo.launch()