Poet example

app.py

@@ -4,11 +4,12 @@ from huggingface_hub import hf_hub_download
 import time
 
 # --- Configuration ---
-MODEL_REPO = "Kezovic/iris-q4gguf-baseline-10k"#iris-f16gguf-test" #iris-q4gguf-lora-test" #iris-q4gguf-baseline-10k"
-MODEL_FILE = "llama-3.2-1b-instruct.Q4_K_M.gguf"#llama-3.2-1b-instruct.F16.gguf"#Llama-3.2-1B-Instruct.Q4_K_M.gguf"#llama-3.2-1b-instruct.Q4_K_M.gguf"
-CONTEXT_WINDOW = 2048 
-MAX_NEW_TOKENS = 400  
-TEMPERATURE = 1.5     
+MODEL_REPO = "Kezovic/iris-q4gguf-baseline-10k"
+MODEL_FILE = "llama-3.2-1b-instruct.Q4_K_M.gguf"
+CONTEXT_WINDOW = 2048
+MAX_NEW_TOKENS = 400
+TEMPERATURE = 0.7  # Reduced temperature for better instruction following
+# Note: min_p = 0.1 is kept as requested in the configuration from the previous prompt
 
 # --- Model Loading ---
 llm = None
@@ -27,75 +28,103 @@ def load_llm():
         print("Model loaded successfully!")
     except Exception as e:
         print(f"Error loading model: {e}")
-
 load_llm()
 
-# --- Generation Function ---
-def generate_poem(format_type, persona, topic, progress=gr.Progress()):
-    # 1. VISUAL FEEDBACK: Immediately show the bar
-    # This now works because the Textbox below has a fixed height!
-    progress(0, desc="Consulting the Muse...")
-    time.sleep(0.2) # Force a tiny pause so the eye catches the bar
+# --- Persona and Format Maps (Hardened Constraints) ---
+persona_map = {
+    "A Grumpy Pirate": "You are a salty, grumpy pirate captain. Use nautical slang, complain about the sea, and say 'Arrr'.",
+    "A Melancholy Philosopher": "You are a deep, existential philosopher. Use complex vocabulary, metaphor, and a somber tone.",
+    "A Hyperactive 5-Year-Old": "You are a very excited 5-year-old. Use simple words, lots of exclamation marks, and get distracted easily.",
+    "Shakespearean Actor": "You are a dramatic Shakespearean actor. Use Early Modern English (thee, thou), dramatic flair, and iambic rhythm."
+}
 
-    if not llm:
-        return "Error: Model not loaded."
+# CONSTRAINTS ARE HARDENED: Clear rules to help adherence.
+format_map = {
+    "Limerick": "The poem MUST have exactly 5 lines (A-A-B-B-A rhyme scheme) and be HUMOROUS.",
+    "Sonnet": "The poem MUST have exactly 14 lines and express a complete thought or feeling.",
+    "Haiku": "The poem ABSOLUTELY MUST have exactly 3 lines. The syllable structure should be 5-7-5 (approximate). Focus on nature and brevity.",
+    "Free Verse": "The poem should be written in Free Verse. It should have 6-10 lines and focus on imagery and emotion without strict rhyme or rhythm.",
+    "Ballad": "The poem MUST tell a narrative story using four-line stanzas (quatrains) and a simple rhyme scheme like A-B-C-B. It should be 4-6 stanzas long."
+}
+
+# --- Prompt Construction Helper Function (Robust, Delimited Prompt) ---
+def build_poem_prompt(voice_instruction, constraint_instruction, format_type, topic):
+    """Constructs a robust, delimited prompt for initial poem generation."""
     
-    if not topic:
-        return "Please enter a topic!"
+    system_context = (
+        f"SYSTEM: You are a highly disciplined creative writer. You ABSOLUTELY MUST follow all constraints "
+        f"on line count, structure, and persona. Your entire response MUST contain ONLY the poem and NOTHING else. "
+        f"Do NOT include any titles, headers, or extra text.\n"
+        f"PERSONA: {voice_instruction}\n"
+        f"FORMAT RULES: {constraint_instruction}\n"
+    )
 
-    # 2. Progress Update
-    progress(0.2, desc=f"Summoning {persona}...")
-    time.sleep(0.3)
+    user_task = (
+        f"USER: Write a {format_type} about the topic: '{topic}'. The poem MUST strictly adhere to all FORMAT RULES.\n"
+    )
+        
+    return f"### Instruction:\n{system_context}\n{user_task}\n\n"
 
-    persona_map = {
-        "A Grumpy Pirate": "You are a salty, grumpy pirate captain. Use nautical slang, complain about the sea, and say 'Arrr'.",
-        "A Melancholy Philosopher": "You are a deep, existential philosopher. Use complex vocabulary, metaphor, and a somber tone.",
-        "A Hyperactive 5-Year-Old": "You are a very excited 5-year-old. Use simple words, lots of exclamation marks, and get distracted easily.",
-        "Shakespearean Actor": "You are a dramatic Shakespearean actor. Use Early Modern English (thee, thou), dramatic flair, and iambic rhythm."
-    }
-    
-    format_map = {
-        "Limerick": "Write a Limerick. It must have exactly 5 lines. The rhyme scheme must be A-A-B-B-A. It should be humorous.",
-        "Sonnet": "Write a Sonnet. It must have exactly 14 lines and express a complete thought or feeling.",
-        "Haiku": "Write a Haiku. It must have exactly 3 lines. Keep it very brief and nature-focused if possible.",
-        "Free Verse": "Write in Free Verse. Do not worry about rhyme or strict structure, focusing instead on imagery and emotion.",
-        "Ballad": "Write a Ballad. It must tell a narrative story with a clear beginning, middle, and end. Use four-line stanzas (quatrains) and a simple rhyme scheme like A-B-C-B. Keep the language simple and musical."
-    }
+# --- LLM Functions ---
+def generate_poem(format_type, persona, topic, progress=gr.Progress()):
+    # 1. VISUAL FEEDBACK & Error Checks
+    progress(0, desc="Consulting the Muse...")
+    time.sleep(0.2)
+    if not llm:
+        return "Error: Model not loaded.", "Error: Model not loaded."
+    if not topic:
+        return "Please enter a topic!", ""
 
+    # --- 1. POEM GENERATION ---
+    progress(0.2, desc=f"Summoning {persona} and drafting poem...")
     selected_voice = persona_map.get(persona, "You are a helpful assistant.")
     selected_constraint = format_map.get(format_type, "Write a poem.")
     
-    full_prompt = (
-        f"### Instruction:\n"
-        f"{selected_voice}\n"
-        f"{selected_constraint} Your response should only contain the {format_type} that you generate. Nothing else.\n"
-        f"Write the {format_type} about this topic: '{topic}'.\n\n"
-        
-    )
-
-    # 3. Progress Update
-    progress(0.4, desc="Drafting Masterpiece...")
+    full_poem_prompt = build_poem_prompt(selected_voice, selected_constraint, format_type, topic)
 
     output = llm(
-        prompt=full_prompt,
+        prompt=full_poem_prompt,
         max_tokens=MAX_NEW_TOKENS,
         temperature=TEMPERATURE,
-        stop=["### Instruction:", "### Human:"],
+        stop=["### Instruction:", "USER:", "SYSTEM:", "### Human:"],
         echo=False
     )
+    poem_text = output['choices'][0]['text'].strip()
     
-    # 4. Progress Update
-    progress(0.9, desc="Polishing rhymes...")
+    # --- 2. POET SUGGESTION (ANALYSIS) ---
+    progress(0.5, desc="Analyzing style for literary match...")
+
+    # Secondary prompt for the analysis task
+    poet_prompt = (
+        f"### Instruction:\n"
+        f"SYSTEM: You are a literary analyst specializing in poetry. Your task is to find the single most appropriate historical poet "
+        f"whose style and themes match the provided poem. Output only the POET'S NAME followed by a COLON, and then a brief, single-sentence justification.\n"
+        f"Do NOT output any other text or headers. You MUST adhere to the requested persona's style.\n"
+        f"PERSONA: {selected_voice}\n"
+        f"USER: Analyze the poem below and suggest the best matching poet:\n\n"
+        f"POEM:\n{poem_text}\n\n"
+    )
+    
+    output_poet = llm(
+        prompt=poet_prompt,
+        max_tokens=150, # Keep this response short
+        temperature=0.4, # Lower temperature for analysis/retrieval
+        stop=["### Instruction:", "USER:", "SYSTEM:", "### Human:", "\n\n"],
+        echo=False
+    )
+    
+    poet_suggestion = output_poet['choices'][0]['text'].strip()
+
+    progress(0.9, desc="Poem and analysis complete!")
     time.sleep(0.2)
     
-    return output['choices'][0]['text'].strip()
+    return poem_text, poet_suggestion
 
 # --- UI Layout ---
 with gr.Blocks(title="The Poetry Workshop", theme=gr.themes.Soft()) as demo:
-    
-    gr.Markdown("# 🖋️ The Poetry Workshop")
-    gr.Markdown("Your own personal muse to help you get started with poetry.")
-    
+    gr.Markdown("# 🖋️ The Poetry Workshop - Collaborative Analyst")
+    gr.Markdown("Generate a poem based on a topic and persona, then receive a stylistic analysis and literary comparison from the LLM.")
+
     with gr.Group():
         with gr.Row(equal_height=True):
             gr.Markdown("### I want to write a ")
@@ -116,33 +145,39 @@ with gr.Blocks(title="The Poetry Workshop", theme=gr.themes.Soft()) as demo:
                 container=False,
                 scale=3
             )
+        with gr.Row(equal_height=True):
+            gr.Markdown("### about this topic: ")
+            topic_input = gr.Textbox(
+                placeholder="e.g., my broken laptop, the smell of rain, a lost sock",
+                label="Topic",
+                show_label=False,
+                scale=5
+            )
+            generate_btn = gr.Button("✨ Create Masterpiece & Analyze", variant="primary", scale=1)
     
-    with gr.Row(equal_height=True):
-        gr.Markdown("### about this topic: ")
-        topic_input = gr.Textbox(
-            placeholder="e.g., my broken laptop, the smell of rain, a lost sock",
-            label="Topic",
-            show_label=False,
-            scale=5
-        )
-        generate_btn = gr.Button("✨ Create Masterpiece", variant="primary", scale=1)
-
     gr.Markdown("---")
     
-    # --- CRITICAL CHANGE HERE ---
-    # Swapped gr.Markdown for gr.Textbox.
-    # 'lines=10' forces the box to be visible immediately, so the loading bar has a place to live.
-    output_display = gr.Textbox(
-        label="Your Poem", 
-        lines=12,            # Ensures a big empty box exists on load
-        interactive=False,   # Read-only
-        placeholder="Your masterpiece will appear here..."
-    )
+    with gr.Row():
+        output_display = gr.Textbox(
+            label="Your Poem",
+            lines=12,
+            interactive=False,
+            placeholder="Your masterpiece will appear here..."
+        )
+        
+        # New Textbox for the Poet Suggestion
+        poet_suggestion_display = gr.Textbox(
+            label="Literary Analysis: Suggested Poet",
+            lines=12,
+            interactive=False,
+            placeholder="The LLM will analyze the poem's style and suggest a similar historical poet here."
+        )
 
+    # Update the click handler to call the function and map outputs
     generate_btn.click(
         fn=generate_poem,
         inputs=[format_dropdown, persona_dropdown, topic_input],
-        outputs=[output_display]
+        outputs=[output_display, poet_suggestion_display] # Maps to both textboxes
     )
 
 if __name__ == "__main__":