Auto-push: Discussion loop verification (turn 3)

app.py

@@ -9,7 +9,6 @@ from fastapi.staticfiles import StaticFiles
 from fastapi.responses import FileResponse
 from fastapi import WebSocket
 from pydantic import BaseModel
-import json
 import os
 import sys
 from datetime import datetime
@@ -21,6 +20,8 @@ sys.path.insert(0, "/app")
 
 # Import system logger
 from openclaw.core.system_logger import log_startup, log_heartbeat, get_last_lines
+# Import error handlers
+from error_handlers import handle_status_file_read, handle_brain_response, handle_websocket_message
 
 
 @asynccontextmanager
@@ -63,47 +64,18 @@ app.add_middleware(
     allow_headers=["*"],
 )
 
-# Paths
-OPENCLAW_DIR = "/app/.openclaw"
-STATUS_FILE = f"{OPENCLAW_DIR}/agents/cain_status.json"
-
-
 class ChatMessage(BaseModel):
     message: str
 
 
 def get_cain_status() -> dict:
     """Read Cain's current status from cain_status.json."""
-    try:
-        with open(STATUS_FILE, "r") as f:
-            return json.load(f)
-    except FileNotFoundError:
-        return {
-            "current_state": "unknown",
-            "last_updated": datetime.utcnow().isoformat() + "+00:00",
-            "agent": "cain"
-        }
+    return handle_status_file_read()
 
 
 def get_brain_response(message: str) -> str:
     """Route message to brain_minimal.py and return response."""
-    try:
-        # Import brain module from openclaw package
-        from openclaw.agents.brain_minimal import BrainMinimal
-
-        # Create brain instance for Cain
-        brain = BrainMinimal(agent_name="cain", legacy_mode=True)
-
-        # Process the message using conversation_process
-        result = brain._conversation_process(message)
-
-        # Return the response text
-        if result.get("success"):
-            return result.get("response", f"Processed: {message}")
-        else:
-            return f"Error: {result.get('error', 'Unknown error')}"
-    except Exception as e:
-        return f"Brain error: {str(e)}"
+    return handle_brain_response(message)
 
 
 @app.get("/", response_class=FileResponse)

error_handlers.py

@@ -0,0 +1,112 @@
+#!/usr/bin/env python3
+"""
+Error handling utilities for HuggingClaw - Cain.
+Provides specific exception handlers for common operations.
+"""
+import json
+import os
+from datetime import datetime
+from typing import Dict, Any, Optional
+
+
+# Configuration paths
+OPENCLAW_DIR = "/app/.openclaw"
+STATUS_FILE = f"{OPENCLAW_DIR}/agents/cain_status.json"
+
+
+def handle_status_file_read() -> Dict[str, Any]:
+    """
+    Handle reading Cain's status file with specific exception handling.
+
+    Returns:
+        Status dictionary with current_state, last_updated, and agent fields.
+
+    Raises:
+        PermissionError: If file exists but cannot be read due to permissions.
+        json.JSONDecodeError: If file contains invalid JSON.
+    """
+    try:
+        with open(STATUS_FILE, "r") as f:
+            return json.load(f)
+    except FileNotFoundError:
+        return {
+            "current_state": "unknown",
+            "last_updated": datetime.utcnow().isoformat() + "+00:00",
+            "agent": "cain"
+        }
+    except PermissionError as e:
+        return {
+            "current_state": "error",
+            "last_updated": datetime.utcnow().isoformat() + "+00:00",
+            "agent": "cain",
+            "error": f"Permission denied reading status file: {str(e)}"
+        }
+    except json.JSONDecodeError as e:
+        return {
+            "current_state": "error",
+            "last_updated": datetime.utcnow().isoformat() + "+00:00",
+            "agent": "cain",
+            "error": f"Invalid JSON in status file: {str(e)}"
+        }
+
+
+def handle_brain_response(message: str) -> str:
+    """
+    Handle brain processing with specific exception handling.
+
+    Args:
+        message: The user message to process.
+
+    Returns:
+        Response string from the brain or error message.
+
+    Raises:
+        ImportError: If brain module cannot be imported.
+        AttributeError: If required brain methods are missing.
+    """
+    try:
+        from openclaw.agents.brain_minimal import BrainMinimal
+
+        brain = BrainMinimal(agent_name="cain", legacy_mode=True)
+        result = brain._conversation_process(message)
+
+        if result.get("success"):
+            return result.get("response", f"Processed: {message}")
+        else:
+            return f"Error: {result.get('error', 'Unknown error')}"
+
+    except ImportError as e:
+        return f"Brain module import error: {str(e)}"
+    except AttributeError as e:
+        return f"Brain interface error: {str(e)}"
+    except KeyError as e:
+        return f"Brain response format error: missing key {str(e)}"
+    except Exception as e:
+        return f"Brain processing error: {type(e).__name__}: {str(e)}"
+
+
+def handle_websocket_message(websocket, status_func, sleep_func) -> bool:
+    """
+    Handle websocket message loop with specific exception handling.
+
+    Args:
+        websocket: The WebSocket connection object.
+        status_func: Function to get current status.
+        sleep_func: Async sleep function.
+
+    Returns:
+        True if loop should continue, False if it should break.
+    """
+    try:
+        status_data = status_func()
+        websocket.send_json({
+            "type": "heartbeat",
+            "status": status_data
+        })
+        return True
+    except ConnectionError:
+        return False
+    except RuntimeError:
+        return False
+    except Exception:
+        return False