Update Dockerfile

Dockerfile

@@ -1,19 +1,21 @@
-# Dockerfile
+# File: Dockerfile
 FROM nextcloud:apache
 
-ENV APACHE_PORT=7860 \
-    MYSQL_HOST=127.0.0.1
+# Hugging Face will route HTTPS to this container port
+ENV APACHE_PORT=7860
 
 RUN echo "ServerName localhost" >> /etc/apache2/apache2.conf \
  && sed -i "s/Listen 80/Listen ${APACHE_PORT}/" /etc/apache2/ports.conf \
  && sed -i "s/:80/:${APACHE_PORT}/" /etc/apache2/sites-available/000-default.conf
 
+# Install MariaDB server inside the same container
 RUN apt-get update \
  && apt-get install -y --no-install-recommends mariadb-server mariadb-client \
  && rm -rf /var/lib/apt/lists/*
 
-# Keep MariaDB local to the container and set sane defaults for Nextcloud
-RUN printf "%s\n" \
+# Configure MariaDB to listen only locally
+RUN printf "%s
+" \
   "[mysqld]" \
   "bind-address=127.0.0.1" \
   "skip-name-resolve" \
@@ -22,6 +24,7 @@ RUN printf "%s\n" \
   "innodb_file_per_table=1" \
   > /etc/mysql/mariadb.conf.d/99-hf-space.cnf
 
+# Startup script that launches MariaDB and then Nextcloud
 COPY start.sh /start.sh
 RUN chmod +x /start.sh
 
@@ -31,37 +34,33 @@ ENTRYPOINT ["/start.sh"]
 CMD ["apache2-foreground"]
 
 
-# start.sh
+# File: start.sh
 #!/usr/bin/env bash
 set -euo pipefail
 
-# Required variables (set them in Hugging Face Space Secrets or Variables)
-: "${MYSQL_DATABASE:?Set MYSQL_DATABASE in the Space}"
-: "${MYSQL_USER:?Set MYSQL_USER in the Space}"
-: "${MYSQL_PASSWORD:?Set MYSQL_PASSWORD in the Space}"
-
-# Optional, but recommended to automate Nextcloud initial setup
-# NEXTCLOUD_ADMIN_USER
-# NEXTCLOUD_ADMIN_PASSWORD
-# NEXTCLOUD_TRUSTED_DOMAINS
+# Required variables (set these in Hugging Face Space Variables or Secrets)
+: "${MYSQL_DATABASE:?Set MYSQL_DATABASE}"
+: "${MYSQL_USER:?Set MYSQL_USER}"
+: "${MYSQL_PASSWORD:?Set MYSQL_PASSWORD}"
 
+# Ensure runtime directories exist
 mkdir -p /run/mysqld
 chown -R mysql:mysql /run/mysqld
 
-# Initialize MariaDB data directory on first run
+# Initialize MariaDB on first start
 if [ ! -d /var/lib/mysql/mysql ]; then
   mariadb-install-db --user=mysql --datadir=/var/lib/mysql > /dev/null
 fi
 
 # Start MariaDB in the background
-mysqld_safe --datadir=/var/lib/mysql --bind-address=127.0.0.1 --skip-networking=0 &
+mysqld_safe --datadir=/var/lib/mysql --bind-address=127.0.0.1 &
 
-# Wait until MariaDB is ready
+# Wait for MariaDB
 until mariadb-admin ping --silent > /dev/null 2>&1; do
   sleep 1
 done
 
-# Create database and user (idempotent)
+# Create DB and user (idempotent)
 mariadb -uroot <<SQL
 CREATE DATABASE IF NOT EXISTS \`${MYSQL_DATABASE}\` CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
 CREATE USER IF NOT EXISTS '${MYSQL_USER}'@'localhost' IDENTIFIED BY '${MYSQL_PASSWORD}';
@@ -69,8 +68,8 @@ GRANT ALL PRIVILEGES ON \`${MYSQL_DATABASE}\`.* TO '${MYSQL_USER}'@'localhost';
 FLUSH PRIVILEGES;
 SQL
 
-# Ensure Nextcloud connects to the local DB via env (supported by the official image)
-export MYSQL_HOST="${MYSQL_HOST:-127.0.0.1}"
+# Tell the official Nextcloud entrypoint how to reach MariaDB
+export MYSQL_HOST=127.0.0.1
 
 # Hand off to the official Nextcloud entrypoint
 exec /entrypoint.sh "$@"