Upload 10 files

src/views/InstructorView.js

@@ -775,7 +775,7 @@ const checkPermissions = (instructor) => {
                 // User is known to Firebase, check if they are an instructor
                 const instructorData = await checkInstructorPermission(user);
                 if (instructorData) {
-                    authModal.classList.add('hidden');
+                    if (authModal) authModal.classList.add('hidden');
                     checkPermissions(instructorData);
                     localStorage.setItem('vibecoding_instructor_name', instructorData.name);
 
@@ -1163,70 +1163,73 @@ if (navAdminBtn) {
 }
 
 // Handle Instructor Management
-navInstBtn.addEventListener('click', async () => {
-    const modal = document.getElementById('instructor-modal');
-    const listBody = document.getElementById('instructor-list-body');
+if (navInstBtn) {
+    navInstBtn.addEventListener('click', async () => {
+        const modal = document.getElementById('instructor-modal');
+        const listBody = document.getElementById('instructor-list-body');
 
-    // Load list
-    const instructors = await getInstructors();
-    listBody.innerHTML = instructors.map(inst => `
+        // Load list
+        const instructors = await getInstructors();
+        listBody.innerHTML = instructors.map(inst => `
             <tr class="border-b border-gray-700 hover:bg-gray-800">
                 <td class="p-3">${inst.name}</td>
                 <td class="p-3 font-mono text-sm text-cyan-400">${inst.email}</td>
                 <td class="p-3 text-xs">
                     ${inst.permissions?.map(p => {
-        const map = { create_room: '開房', add_question: '題目', manage_instructors: '管理' };
-        return `<span class="bg-gray-700 px-2 py-1 rounded mr-1">${map[p] || p}</span>`;
-    }).join('')}
+            const map = { create_room: '開房', add_question: '題目', manage_instructors: '管理' };
+            return `<span class="bg-gray-700 px-2 py-1 rounded mr-1">${map[p] || p}</span>`;
+        }).join('')}
                 </td>
                 <td class="p-3">
                     ${inst.role === 'admin' ? '<span class="text-gray-500 italic">不可移除</span>' :
-            `<button class="text-red-400 hover:text-red-300" onclick="window.removeInst('${inst.email}')">移除</button>`}
+                `<button class="text-red-400 hover:text-red-300" onclick="window.removeInst('${inst.email}')">移除</button>`}
                 </td>
             </tr>
             `).join('');
 
-    modal.classList.remove('hidden');
-});
+        modal.classList.remove('hidden');
+    });
 
-// Add New Instructor
-const addInstBtn = document.getElementById('btn-add-inst');
-if (addInstBtn) {
-    addInstBtn.addEventListener('click', async () => {
-        const email = document.getElementById('new-inst-email').value.trim();
-        const name = document.getElementById('new-inst-name').value.trim();
+    // Add New Instructor
+    const addInstBtn = document.getElementById('btn-add-inst');
+    if (addInstBtn) {
+        addInstBtn.addEventListener('click', async () => {
+            const email = document.getElementById('new-inst-email').value.trim();
+            const name = document.getElementById('new-inst-name').value.trim();
 
-        if (!email || !name) return alert("請輸入完整資料");
+            if (!email || !name) return alert("請輸入完整資料");
 
-        const perms = [];
-        if (document.getElementById('perm-room').checked) perms.push('create_room');
-        if (document.getElementById('perm-q').checked) perms.push('add_question');
-        if (document.getElementById('perm-inst').checked) perms.push('manage_instructors');
+            const perms = [];
+            if (document.getElementById('perm-room').checked) perms.push('create_room');
+            if (document.getElementById('perm-q').checked) perms.push('add_question');
+            if (document.getElementById('perm-inst').checked) perms.push('manage_instructors');
 
-        try {
-            await addInstructor(email, name, perms);
-            alert("新增成功");
-            navInstBtn.click(); // Reload list
-            document.getElementById('new-inst-email').value = '';
-            document.getElementById('new-inst-name').value = '';
-        } catch (e) {
-            alert("新增失敗: " + e.message);
-        }
-    });
-}
+            try {
+                await addInstructor(email, name, perms);
+                alert("新增成功");
+                navInstBtn.click(); // Reload list
+                document.getElementById('new-inst-email').value = '';
+                document.getElementById('new-inst-name').value = '';
+            } catch (e) {
+                alert("新增失敗: " + e.message);
+            }
+        });
+    }
 
 
-// Global helper for remove (hacky but works for simple onclick)
-window.removeInst = async (email) => {
-    if (confirm(`確定移除 ${email}?`)) {
-        try {
-            await removeInstructor(email);
-            navInstBtn.click(); // Reload
-        } catch (e) {
-            alert(e.message);
+    // Global helper for remove (hacky but works for simple onclick)
+    window.removeInst = async (email) => {
+        if (confirm(`確定移除 ${email}?`)) {
+            try {
+                await removeInstructor(email);
+                navInstBtn.click(); // Reload
+            } catch (e) {
+                alert(e.message);
+            }
         }
     }
 };
+}
 
 // Auto Check Auth (Persistence)
 // We rely on Firebase Auth state observer instead of session storage for security?