File size: 12,366 Bytes
6778ee0 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 | defmodule PlausibleWeb.Site.MembershipControllerTest do
use PlausibleWeb.ConnCase
use Plausible.Repo
use Bamboo.Test
@subject_prefix if ee?(), do: "[Plausible Analytics] ", else: "[Plausible CE] "
setup [:create_user, :log_in]
describe "GET /sites/:domain/memberships/invite" do
test "shows invite form", %{conn: conn, user: user} do
site = new_site(owner: user)
html =
conn
|> get("/sites/#{site.domain}/memberships/invite")
|> html_response(200)
assert html =~ "Invite guest to"
assert element_exists?(html, ~s/button[type=submit]/)
refute element_exists?(html, ~s/button[type=submit][disabled]/)
end
@tag :ee_only
test "display a notice when is over limit", %{conn: conn, user: user} do
site = new_site(owner: user)
for _ <- 1..11 do
add_guest(site, role: :viewer)
end
html =
conn
|> get("/sites/#{site.domain}/memberships/invite")
|> html_response(200)
assert text_of_element(html, ~s/[data-test="limit-exceeded-notice"]/) =~
"This account is limited to 10 members"
end
end
describe "POST /sites/:domain/memberships/invite" do
test "creates invitation", %{conn: conn, user: user} do
site = new_site(owner: user)
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: "john.doe@example.com",
role: "editor"
})
assert_guest_invitation(site.team, site, "john.doe@example.com", :editor)
assert redirected_to(conn) == "/#{URI.encode_www_form(site.domain)}/settings/people"
end
@tag :ee_only
test "fails to create invitation when is over limit", %{conn: conn, user: user} do
site = new_site(owner: user)
for _ <- 1..11 do
add_guest(site, role: :viewer)
end
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: "john.doe@example.com",
role: "editor"
})
assert html_response(conn, 200) =~
"Your account is limited to 10 team members. You can upgrade your plan to increase this limit."
end
test "fails to create invitation with insufficient permissions", %{conn: conn, user: user} do
site = new_site()
add_guest(site, user: user, role: :viewer)
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: "john.doe@example.com",
role: "editor"
})
assert conn.status == 404
end
test "fails to create invitation if site transfer already exists", %{conn: conn, user: user} do
site = new_site(owner: user)
new_owner = new_user()
{:ok, _invitation} =
Plausible.Teams.Invitations.InviteToSite.invite(site, user, new_owner.email, :owner)
assert_site_transfer(site, new_owner.email)
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: new_owner.email,
role: "editor"
})
conn = get(recycle(conn), redirected_to(conn, 302))
html = html_response(conn, 200)
assert html =~ "Error"
assert html =~ "This invitation has been already sent"
end
test "fails to create invitation for a foreign site", %{conn: my_conn, user: me} do
_my_site = new_site(owner: me)
other_user = new_user()
other_site = new_site(owner: other_user)
my_conn =
post(my_conn, "/sites/#{other_site.domain}/memberships/invite", %{
email: "john.doe@example.com",
role: "editor"
})
assert my_conn.status == 404
refute Repo.get_by(Plausible.Teams.Invitation, email: "john.doe@example.com")
end
test "sends invitation email for new user", %{conn: conn, user: user} do
site = new_site(owner: user)
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: "john.doe@example.com",
role: "editor"
})
assert_email_delivered_with(
to: [nil: "john.doe@example.com"],
subject: @subject_prefix <> "You've been invited to #{site.domain}"
)
end
test "sends invitation email for existing user", %{conn: conn, user: user} do
existing_user = new_user()
site = new_site(owner: user)
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: existing_user.email,
role: "editor"
})
assert_email_delivered_with(
to: [nil: existing_user.email],
subject: @subject_prefix <> "You've been invited to #{site.domain}"
)
end
test "renders form with error if the invitee is already a member", %{conn: conn, user: user} do
site = new_site(owner: user)
second_member = new_user()
add_guest(site, user: second_member, role: :viewer)
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: second_member.email,
role: "editor"
})
assert html_response(conn, 200) =~
"#{second_member.email} is already a member of #{site.domain}"
end
test "handles repeat invitation gracefully", %{
conn: conn,
user: user
} do
site = new_site(owner: user)
_req1 =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: "joe@example.com",
role: "editor"
})
assert_email_delivered_with(
to: [nil: "joe@example.com"],
subject: @subject_prefix <> "You've been invited to #{site.domain}"
)
req2 =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: "joe@example.com",
role: "editor"
})
assert_email_delivered_with(
to: [nil: "joe@example.com"],
subject: @subject_prefix <> "You've been invited to #{site.domain}"
)
assert Phoenix.Flash.get(req2.assigns.flash, :success) =~
"has been invited to"
end
end
describe "PUT /sites/memberships/:id/role/:new_role" do
test "updates a site member's role by user id", %{conn: conn, user: user} do
site = new_site(owner: user)
collaborator = add_guest(site, role: :editor)
assert_guest_membership(site.team, site, collaborator, :editor)
put(conn, "/sites/#{site.domain}/memberships/u/#{collaborator.id}/role/viewer")
assert_guest_membership(site.team, site, collaborator, :viewer)
end
test "team admin can update a site member's role by user id (from editor to viewer)", %{
conn: conn,
user: user
} do
site = new_site()
team = Plausible.Teams.complete_setup(site.team)
add_member(team, user: user, role: :admin)
collaborator = add_guest(site, role: :editor)
assert_guest_membership(team, site, collaborator, :editor)
conn = set_current_team(conn, team)
put(conn, "/sites/#{site.domain}/memberships/u/#{collaborator.id}/role/viewer")
assert_guest_membership(team, site, collaborator, :viewer)
end
test "team admin can update a site member's role by user id (from viewer to editor)", %{
conn: conn,
user: user
} do
site = new_site()
team = Plausible.Teams.complete_setup(site.team)
add_member(team, user: user, role: :admin)
collaborator = add_guest(site, role: :viewer)
assert_guest_membership(team, site, collaborator, :viewer)
conn = set_current_team(conn, team)
put(conn, "/sites/#{site.domain}/memberships/u/#{collaborator.id}/role/editor")
assert_guest_membership(team, site, collaborator, :editor)
end
test "team editor can't update site member's role", %{conn: conn, user: user} do
site = new_site()
team = Plausible.Teams.complete_setup(site.team)
add_member(team, user: user, role: :editor)
collaborator = add_guest(site, role: :editor)
assert_guest_membership(team, site, collaborator, :editor)
conn = set_current_team(conn, team)
conn = put(conn, "/sites/#{site.domain}/memberships/u/#{collaborator.id}/role/viewer")
assert html_response(conn, 404)
assert_guest_membership(team, site, collaborator, :editor)
end
test "can't update role when an editor", %{
conn: conn,
user: user
} do
site = new_site()
add_guest(site, user: user, role: :editor)
conn = put(conn, "/sites/#{site.domain}/memberships/u/#{user.id}/role/viewer")
assert_guest_membership(site.team, site, user, :editor)
assert html_response(conn, 404)
end
test "can't update role when a viewer", %{
conn: conn,
user: user
} do
site = new_site()
add_guest(site, user: user, role: :viewer)
another_guest = add_guest(site, role: :editor)
conn = put(conn, "/sites/#{site.domain}/memberships/u/#{another_guest.id}/role/viewer")
assert_guest_membership(site.team, site, another_guest, :editor)
assert html_response(conn, 404)
end
test "owner cannot make anyone else owner", %{
conn: conn,
user: user
} do
site = new_site(owner: user)
editor = new_user()
add_guest(site, user: editor, role: :editor)
conn = put(conn, "/sites/#{site.domain}/memberships/u/#{editor.id}/role/owner")
assert_guest_membership(site.team, site, editor, :editor)
assert Phoenix.Flash.get(conn.assigns.flash, :error) ==
"You are not allowed to grant the owner role"
end
test "owner cannot downgrade themselves", %{
conn: conn,
user: user
} do
site = new_site(owner: user)
conn = put(conn, "/sites/#{site.domain}/memberships/u/#{user.id}/role/admin")
membership = Repo.get_by(Plausible.Teams.Membership, user_id: user.id)
assert membership.role == :owner
assert Phoenix.Flash.get(conn.assigns.flash, :error) ==
"You are not allowed to grant the admin role"
end
end
describe "DELETE /sites/:domain/memberships/:id" do
test "removes a member from a site by user id", %{conn: conn, user: user} do
site = new_site(owner: user)
admin = add_guest(site, role: :editor)
conn = delete(conn, "/sites/#{site.domain}/memberships/u/#{admin.id}")
assert Phoenix.Flash.get(conn.assigns.flash, :success) =~ "has been removed"
refute Repo.exists?(from tm in Plausible.Teams.Membership, where: tm.user_id == ^admin.id)
end
test "when members is removed, associated personal segment is deleted", %{
conn: conn,
user: user
} do
site = new_site(owner: user)
admin = add_guest(site, role: :editor)
segment =
insert(:segment,
type: :personal,
owner: admin,
site: site,
name: "personal segment"
)
delete(conn, "/sites/#{site.domain}/memberships/u/#{admin.id}")
refute Repo.reload(segment)
end
test "when members is removed, associated site segment will be owner-less", %{
conn: conn,
user: user
} do
site = new_site(owner: user)
admin = add_guest(site, role: :editor)
segment =
insert(:segment,
type: :site,
owner: admin,
site: site,
name: "site segment"
)
delete(conn, "/sites/#{site.domain}/memberships/u/#{admin.id}")
assert Repo.reload(segment).owner_id == nil
end
test "fails to remove a member from a foreign site (silently)", %{conn: conn, user: user} do
foreign_member = new_user()
foreign_site = new_site()
add_guest(foreign_site, user: foreign_member, role: :editor)
site = new_site(owner: user)
conn = delete(conn, "/sites/#{site.domain}/memberships/u/#{foreign_member.id}")
assert Phoenix.Flash.get(conn.assigns.flash, :success) =~ "has been removed"
assert_guest_membership(foreign_site.team, foreign_site, foreign_member, :editor)
end
test "notifies the user who has been removed via email", %{conn: conn, user: user} do
site = new_site(owner: user)
editor = add_guest(site, role: :editor)
delete(conn, "/sites/#{site.domain}/memberships/u/#{editor.id}")
assert_email_delivered_with(
to: [nil: editor.email],
subject: @subject_prefix <> "Your access to #{site.domain} has been revoked"
)
end
end
end
|