File size: 13,160 Bytes
391c43e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 | import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import { runServerGeneration, awaitBuildResult } from '../server-orchestrator-runner';
import { TaskManager } from '../task-manager';
import { SSEEventBus } from '../sse-event-bus';
import type { StartGenerationRequest, BuildResult } from '../types';
import type { VirtualFileSystem } from '@/lib/vfs';
const mockExecute = vi.fn().mockResolvedValue({ success: true });
const mockStop = vi.fn();
const mockImportConversation = vi.fn();
vi.mock('@/lib/llm/multi-agent-orchestrator', () => ({
MultiAgentOrchestrator: vi.fn().mockImplementation(() => ({
execute: mockExecute,
stop: mockStop,
importConversation: mockImportConversation,
})),
}));
vi.mock('../vfs-context', () => ({
runWithVFS: (_vfs: unknown, fn: () => Promise<unknown>) => fn(),
}));
vi.mock('@/lib/vfs', () => ({
VirtualFileSystem: vi.fn(),
registerContextVFSProvider: vi.fn(),
}));
function createMockVFS(): VirtualFileSystem {
return {
createFile: vi.fn(),
updateFile: vi.fn(),
deleteFile: vi.fn(),
renameFile: vi.fn(),
moveFile: vi.fn(),
deleteDirectory: vi.fn(),
createDirectory: vi.fn(),
getAllFilesAndDirectories: vi.fn().mockResolvedValue([]),
} as unknown as VirtualFileSystem;
}
function makeRequest(overrides?: Partial<StartGenerationRequest>): StartGenerationRequest {
return {
projectId: 'proj-1',
prompt: 'add a button',
model: 'gpt-4',
apiKey: 'sk-test',
conversationHistory: [],
generationParams: {},
...overrides,
};
}
describe('runServerGeneration', () => {
let tm: TaskManager;
let bus: SSEEventBus;
let mockVFS: VirtualFileSystem;
beforeEach(() => {
tm = new TaskManager({ maxConcurrentPerScope: 5, keyTTLMs: 30 * 60 * 1000 });
bus = new SSEEventBus({ maxBufferSize: 500 });
mockVFS = createMockVFS();
vi.clearAllMocks();
});
afterEach(() => {
tm.dispose();
});
function makeDeps() {
return {
taskManager: tm,
eventBus: bus,
createVFS: vi.fn().mockResolvedValue(mockVFS),
apiBaseUrl: 'http://localhost:3000',
};
}
it('emits task_complete with result=success on happy path', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete).toBeDefined();
expect(complete!.data.result).toBe('success');
expect(tm.getTask(taskId)?.status).toBe('completed');
});
it('emits task_complete with result=failed when the loop reports failure without throwing', async () => {
mockExecute.mockResolvedValueOnce({
success: false,
summary: 'Reached maximum iterations (40)',
exitReason: 'max_iterations',
});
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete!.data.result).toBe('failed');
expect(complete!.data.error).toBe('Reached maximum iterations (40)');
expect(tm.getTask(taskId)?.status).toBe('failed');
});
it('emits task_complete with result=stopped when the loop reports a user stop', async () => {
mockExecute.mockResolvedValueOnce({
success: false,
summary: 'Stopped by user',
exitReason: 'stopped',
});
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete!.data.result).toBe('stopped');
expect(tm.getTask(taskId)?.status).toBe('cancelled');
});
it('emits task_complete with result=failed when orchestrator throws', async () => {
mockExecute.mockRejectedValueOnce(new Error('LLM API failed'));
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const errorEvt = emitted.find((e) => e.event === 'error');
expect(errorEvt).toBeDefined();
expect(errorEvt!.data.message).toBe('LLM API failed');
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete!.data.result).toBe('failed');
expect(tm.getTask(taskId)?.status).toBe('failed');
});
it('emits task_complete with result=stopped when task is cancelled', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
mockExecute.mockImplementationOnce(async () => {
tm.getTask(taskId)!.status = 'cancelled';
throw new Error('Stopped');
});
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete!.data.result).toBe('stopped');
expect(tm.getTask(taskId)?.status).toBe('cancelled');
});
it('emits task_complete with result=stopped when task is paused', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
mockExecute.mockImplementationOnce(async () => {
tm.getTask(taskId)!.status = 'paused';
throw new Error('Paused');
});
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete!.data.result).toBe('stopped');
expect(tm.getTask(taskId)?.status).toBe('cancelled');
});
it('reports stopped (not success) when task paused without throw', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
mockExecute.mockImplementationOnce(async () => {
tm.getTask(taskId)!.status = 'paused';
return { success: true };
});
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const complete = emitted.find((e) => e.event === 'task_complete');
expect(complete!.data.result).toBe('stopped');
});
it('throws when task does not exist', async () => {
await expect(runServerGeneration('nonexistent', makeRequest(), makeDeps()))
.rejects.toThrow('Task nonexistent not found');
});
it('calls importConversation when conversationHistory is provided', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const history = [{ role: 'user', content: 'hello' }];
await runServerGeneration(taskId, makeRequest({ conversationHistory: history }), makeDeps());
expect(mockImportConversation).toHaveBeenCalledWith(history);
});
it('does not call importConversation when history is empty', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
await runServerGeneration(taskId, makeRequest({ conversationHistory: [] }), makeDeps());
expect(mockImportConversation).not.toHaveBeenCalled();
});
it('flushes dirty paths as files_changed on tool_status completed', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const { MultiAgentOrchestrator } = await import('@/lib/llm/multi-agent-orchestrator');
(MultiAgentOrchestrator as any).mockImplementationOnce(
(_projId: string, _role: string, progressCb: (event: string, data?: unknown) => void) => ({
execute: vi.fn().mockImplementation(async () => {
// trackVFSMutations wraps createFile to add paths to dirtyPaths.
// Call the wrapped createFile to populate dirtyPaths, then trigger flush via tool_status.
await mockVFS.createFile('proj-1', '/new-file.html', '<h1>hi</h1>');
progressCb('tool_status', { status: 'completed' });
return { success: true };
}),
stop: vi.fn(),
importConversation: vi.fn(),
}),
);
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
await runServerGeneration(taskId, makeRequest(), makeDeps());
const filesChanged = emitted.find((e) => e.event === 'files_changed');
expect(filesChanged).toBeDefined();
expect((filesChanged!.data.paths as string[])).toContain('/new-file.html');
});
});
describe('awaitBuildResult', () => {
let tm: TaskManager;
let bus: SSEEventBus;
beforeEach(() => {
tm = new TaskManager({ maxConcurrentPerScope: 5, keyTTLMs: 30 * 60 * 1000 });
bus = new SSEEventBus({ maxBufferSize: 500 });
vi.clearAllMocks();
});
afterEach(() => {
tm.dispose();
});
function makeDeps() {
const mockVFS = createMockVFS();
return {
taskManager: tm,
eventBus: bus,
createVFS: vi.fn().mockResolvedValue(mockVFS),
apiBaseUrl: 'http://localhost:3000',
};
}
it('returns task-not-found error for nonexistent task', async () => {
const result = await awaitBuildResult('nonexistent', makeDeps());
expect(result).toEqual({ success: false, errors: ['Task not found'] });
});
it('resolves when pendingBuildResolve is called', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const deps = makeDeps();
const resultPromise = awaitBuildResult(taskId, deps);
// Simulate the client posting build-result
const task = tm.getTask(taskId)!;
await vi.waitFor(() => expect(task.pendingBuildResolve).not.toBeNull());
task.pendingBuildResolve!({ success: true });
const result = await resultPromise;
expect(result).toEqual({ success: true });
});
it('resolves with deferred result after 30s timeout', async () => {
vi.useFakeTimers();
try {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const deps = makeDeps();
const resultPromise = awaitBuildResult(taskId, deps);
// Flush microtasks so the Promise.race and setTimeout are set up
await vi.advanceTimersByTimeAsync(30_000);
const result = await resultPromise;
expect(result.success).toBe(true);
expect(result.errors).toContain('Build deferred — client disconnected');
const task = tm.getTask(taskId)!;
expect(task.buildDeferred).toBe(true);
expect(task.pendingBuildResolve).toBeNull();
} finally {
vi.useRealTimers();
}
});
it('emits build_requested event with file manifest', async () => {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const deps = makeDeps();
const mockVFS = await deps.createVFS('proj-1');
(mockVFS.getAllFilesAndDirectories as any).mockResolvedValue([
{ id: 'f1', path: '/index.html', name: 'index.html', updatedAt: new Date('2026-01-01') },
{ path: '/src', name: 'src', type: 'directory' },
]);
const emitted: Array<{ event: string; data: Record<string, unknown> }> = [];
bus.addListener('sess-1', (e) => emitted.push(e));
const resultPromise = awaitBuildResult(taskId, deps);
// Resolve immediately to not hang the test
const task = tm.getTask(taskId)!;
await vi.waitFor(() => expect(task.pendingBuildResolve).not.toBeNull());
task.pendingBuildResolve!({ success: true });
await resultPromise;
const buildReq = emitted.find((e) => e.event === 'build_requested');
expect(buildReq).toBeDefined();
expect(buildReq!.data.fileManifest).toBeDefined();
const manifest = buildReq!.data.fileManifest as Record<string, number>;
expect(manifest['/index.html']).toBeDefined();
expect(manifest['/src']).toBeUndefined();
});
it('clears timeout when build resolves before 30s', async () => {
vi.useFakeTimers();
try {
const taskId = tm.createTask('proj-1', 'sess-1', 'sk-test');
const deps = makeDeps();
const resultPromise = awaitBuildResult(taskId, deps);
// Let microtasks flush so pendingBuildResolve is set
await vi.advanceTimersByTimeAsync(0);
const task = tm.getTask(taskId)!;
expect(task.pendingBuildResolve).not.toBeNull();
task.pendingBuildResolve!({ success: true });
await resultPromise;
// Advance past timeout — should NOT set buildDeferred since we already resolved
await vi.advanceTimersByTimeAsync(30_000);
expect(task.buildDeferred).toBe(false);
} finally {
vi.useRealTimers();
}
});
});
|