File size: 9,657 Bytes
1dbc34b
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import {
  writeValidation,
  readValidation,
  getAllValidations,
  deleteValidation,
  isValidationStale,
  getValidationWithFreshness,
  markValidationViewed,
  getUnviewedValidationsCount,
  type StoredValidation,
} from '@/lib/validation-storage.js';
import fs from 'fs/promises';
import path from 'path';
import os from 'os';

describe('validation-storage.ts', () => {
  let testProjectPath: string;

  beforeEach(async () => {
    testProjectPath = path.join(os.tmpdir(), `validation-storage-test-${Date.now()}`);
    await fs.mkdir(testProjectPath, { recursive: true });
  });

  afterEach(async () => {
    try {
      await fs.rm(testProjectPath, { recursive: true, force: true });
    } catch {
      // Ignore cleanup errors
    }
  });

  const createMockValidation = (overrides: Partial<StoredValidation> = {}): StoredValidation => ({
    issueNumber: 123,
    issueTitle: 'Test Issue',
    validatedAt: new Date().toISOString(),
    model: 'haiku',
    result: {
      verdict: 'valid',
      confidence: 'high',
      reasoning: 'Test reasoning',
    },
    ...overrides,
  });

  describe('writeValidation', () => {
    it('should write validation to storage', async () => {
      const validation = createMockValidation();

      await writeValidation(testProjectPath, 123, validation);

      // Verify file was created
      const validationPath = path.join(
        testProjectPath,
        '.automaker',
        'validations',
        '123',
        'validation.json'
      );
      const content = await fs.readFile(validationPath, 'utf-8');
      expect(JSON.parse(content)).toEqual(validation);
    });

    it('should create nested directories if they do not exist', async () => {
      const validation = createMockValidation({ issueNumber: 456 });

      await writeValidation(testProjectPath, 456, validation);

      const validationPath = path.join(
        testProjectPath,
        '.automaker',
        'validations',
        '456',
        'validation.json'
      );
      const content = await fs.readFile(validationPath, 'utf-8');
      expect(JSON.parse(content)).toEqual(validation);
    });
  });

  describe('readValidation', () => {
    it('should read validation from storage', async () => {
      const validation = createMockValidation();
      await writeValidation(testProjectPath, 123, validation);

      const result = await readValidation(testProjectPath, 123);

      expect(result).toEqual(validation);
    });

    it('should return null when validation does not exist', async () => {
      const result = await readValidation(testProjectPath, 999);

      expect(result).toBeNull();
    });
  });

  describe('getAllValidations', () => {
    it('should return all validations for a project', async () => {
      const validation1 = createMockValidation({ issueNumber: 1, issueTitle: 'Issue 1' });
      const validation2 = createMockValidation({ issueNumber: 2, issueTitle: 'Issue 2' });
      const validation3 = createMockValidation({ issueNumber: 3, issueTitle: 'Issue 3' });

      await writeValidation(testProjectPath, 1, validation1);
      await writeValidation(testProjectPath, 2, validation2);
      await writeValidation(testProjectPath, 3, validation3);

      const result = await getAllValidations(testProjectPath);

      expect(result).toHaveLength(3);
      expect(result[0]).toEqual(validation1);
      expect(result[1]).toEqual(validation2);
      expect(result[2]).toEqual(validation3);
    });

    it('should return empty array when no validations exist', async () => {
      const result = await getAllValidations(testProjectPath);

      expect(result).toEqual([]);
    });

    it('should skip non-numeric directories', async () => {
      const validation = createMockValidation({ issueNumber: 1 });
      await writeValidation(testProjectPath, 1, validation);

      // Create a non-numeric directory
      const invalidDir = path.join(testProjectPath, '.automaker', 'validations', 'invalid');
      await fs.mkdir(invalidDir, { recursive: true });

      const result = await getAllValidations(testProjectPath);

      expect(result).toHaveLength(1);
      expect(result[0]).toEqual(validation);
    });
  });

  describe('deleteValidation', () => {
    it('should delete validation from storage', async () => {
      const validation = createMockValidation();
      await writeValidation(testProjectPath, 123, validation);

      const result = await deleteValidation(testProjectPath, 123);

      expect(result).toBe(true);

      const readResult = await readValidation(testProjectPath, 123);
      expect(readResult).toBeNull();
    });

    it('should return true even when validation does not exist', async () => {
      const result = await deleteValidation(testProjectPath, 999);

      expect(result).toBe(true);
    });
  });

  describe('isValidationStale', () => {
    it('should return false for recent validation', () => {
      const validation = createMockValidation({
        validatedAt: new Date().toISOString(),
      });

      const result = isValidationStale(validation);

      expect(result).toBe(false);
    });

    it('should return true for validation older than 24 hours', () => {
      const oldDate = new Date();
      oldDate.setHours(oldDate.getHours() - 25); // 25 hours ago

      const validation = createMockValidation({
        validatedAt: oldDate.toISOString(),
      });

      const result = isValidationStale(validation);

      expect(result).toBe(true);
    });

    it('should return false for validation exactly at 24 hours', () => {
      const exactDate = new Date(Date.now() - 24 * 60 * 60 * 1000 + 100);

      const validation = createMockValidation({
        validatedAt: exactDate.toISOString(),
      });

      const result = isValidationStale(validation);

      expect(result).toBe(false);
    });
  });

  describe('getValidationWithFreshness', () => {
    it('should return validation with isStale false for recent validation', async () => {
      const validation = createMockValidation({
        validatedAt: new Date().toISOString(),
      });
      await writeValidation(testProjectPath, 123, validation);

      const result = await getValidationWithFreshness(testProjectPath, 123);

      expect(result).not.toBeNull();
      expect(result!.validation).toEqual(validation);
      expect(result!.isStale).toBe(false);
    });

    it('should return validation with isStale true for old validation', async () => {
      const oldDate = new Date();
      oldDate.setHours(oldDate.getHours() - 25);

      const validation = createMockValidation({
        validatedAt: oldDate.toISOString(),
      });
      await writeValidation(testProjectPath, 123, validation);

      const result = await getValidationWithFreshness(testProjectPath, 123);

      expect(result).not.toBeNull();
      expect(result!.isStale).toBe(true);
    });

    it('should return null when validation does not exist', async () => {
      const result = await getValidationWithFreshness(testProjectPath, 999);

      expect(result).toBeNull();
    });
  });

  describe('markValidationViewed', () => {
    it('should mark validation as viewed', async () => {
      const validation = createMockValidation();
      await writeValidation(testProjectPath, 123, validation);

      const result = await markValidationViewed(testProjectPath, 123);

      expect(result).toBe(true);

      const updated = await readValidation(testProjectPath, 123);
      expect(updated).not.toBeNull();
      expect(updated!.viewedAt).toBeDefined();
    });

    it('should return false when validation does not exist', async () => {
      const result = await markValidationViewed(testProjectPath, 999);

      expect(result).toBe(false);
    });
  });

  describe('getUnviewedValidationsCount', () => {
    it('should return count of unviewed non-stale validations', async () => {
      const validation1 = createMockValidation({ issueNumber: 1 });
      const validation2 = createMockValidation({ issueNumber: 2 });
      const validation3 = createMockValidation({
        issueNumber: 3,
        viewedAt: new Date().toISOString(),
      });

      await writeValidation(testProjectPath, 1, validation1);
      await writeValidation(testProjectPath, 2, validation2);
      await writeValidation(testProjectPath, 3, validation3);

      const result = await getUnviewedValidationsCount(testProjectPath);

      expect(result).toBe(2);
    });

    it('should not count stale validations', async () => {
      const oldDate = new Date();
      oldDate.setHours(oldDate.getHours() - 25);

      const validation1 = createMockValidation({ issueNumber: 1 });
      const validation2 = createMockValidation({
        issueNumber: 2,
        validatedAt: oldDate.toISOString(),
      });

      await writeValidation(testProjectPath, 1, validation1);
      await writeValidation(testProjectPath, 2, validation2);

      const result = await getUnviewedValidationsCount(testProjectPath);

      expect(result).toBe(1);
    });

    it('should return 0 when no validations exist', async () => {
      const result = await getUnviewedValidationsCount(testProjectPath);

      expect(result).toBe(0);
    });

    it('should return 0 when all validations are viewed', async () => {
      const validation = createMockValidation({
        issueNumber: 1,
        viewedAt: new Date().toISOString(),
      });

      await writeValidation(testProjectPath, 1, validation);

      const result = await getUnviewedValidationsCount(testProjectPath);

      expect(result).toBe(0);
    });
  });
});