File size: 13,139 Bytes
1477a90
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
import fetchMock from '@fetch-mock/vitest'
import { beforeEach, describe, expect, it } from 'vitest'
import { OpenMeter, type IngestedEvent, type Meter } from '../src/index.js'
import {
  PaginationLimitExceededError,
  paginateCursor,
  paginatePages,
} from '../src/lib/paginate.js'
import type { Result } from '../src/lib/types.js'

beforeEach(() => {
  fetchMock.mockReset()
})

function client() {
  return new OpenMeter({
    baseUrl: 'https://eu.api.konghq.com/v3',
    apiKey: 'k',
    fetch: fetchMock.fetchHandler,
  })
}

function meterFixture(key: string) {
  return {
    id: `01ARZ3NDEKTSV4RRFFQ69G5${key.toUpperCase().padStart(4, '0')}`,
    name: key,
    key,
    aggregation: 'count',
    event_type: 'api-request',
    created_at: '2024-01-01T00:00:00Z',
    updated_at: '2024-01-01T00:00:00Z',
  }
}

function eventFixture(id: string) {
  return {
    event: { id, source: 'test', specversion: '1.0', type: 'test.event' },
    ingested_at: '2024-01-01T00:00:00Z',
    stored_at: '2024-01-01T00:00:00Z',
  }
}

function jsonRoute(body: unknown) {
  return { body, headers: { 'Content-Type': 'application/json' } }
}

describe('paginatePages (page-number pagination)', () => {
  it('iterates every item across 3 pages via client.meters.listAll', async () => {
    // total 5 across pages of size 2, 2, 1 β€” the last page is short, which is
    // what actually stops the iteration (see the exact-total test below for
    // the other stop condition).
    const pageKeys = [['a', 'b'], ['c', 'd'], ['e']]
    fetchMock.route('*', (callLog) => {
      const number = Number(callLog.queryParams?.get('page[number]') ?? '1')
      const keys = pageKeys[number - 1] ?? []
      return jsonRoute({
        data: keys.map(meterFixture),
        meta: { page: { number, size: 2, total: 5 } },
      })
    })

    const keys: string[] = []
    for await (const meter of client().meters.listAll()) {
      keys.push(meter.key)
    }

    expect(keys).toEqual(['a', 'b', 'c', 'd', 'e'])
    expect(fetchMock.callHistory.calls()).toHaveLength(3)
  })

  it('stops without an extra request when the final page exactly fills total', async () => {
    fetchMock.route('*', (callLog) => {
      const number = Number(callLog.queryParams?.get('page[number]') ?? '1')
      const keys = number === 1 ? ['a', 'b'] : []
      return jsonRoute({
        data: keys.map(meterFixture),
        meta: { page: { number, size: 2, total: 2 } },
      })
    })

    const keys: string[] = []
    for await (const meter of client().meters.listAll()) {
      keys.push(meter.key)
    }

    expect(keys).toEqual(['a', 'b'])
    expect(fetchMock.callHistory.calls()).toHaveLength(1)
  })

  it('yields nothing and fetches once for an empty first page', async () => {
    fetchMock.route(
      '*',
      jsonRoute({
        data: [],
        meta: { page: { number: 1, size: 10, total: 0 } },
      }),
    )

    const keys: string[] = []
    for await (const meter of client().meters.listAll()) {
      keys.push(meter.key)
    }

    expect(keys).toEqual([])
    expect(fetchMock.callHistory.calls()).toHaveLength(1)
  })

  it('fires no further requests once the consumer breaks early', async () => {
    const pageKeys = [
      ['a', 'b'],
      ['c', 'd'],
    ]
    fetchMock.route('*', (callLog) => {
      const number = Number(callLog.queryParams?.get('page[number]') ?? '1')
      return jsonRoute({
        data: (pageKeys[number - 1] ?? []).map(meterFixture),
        meta: { page: { number, size: 2, total: 4 } },
      })
    })

    for await (const meter of client().meters.listAll()) {
      expect(meter.key).toBe('a')
      break
    }

    expect(fetchMock.callHistory.calls()).toHaveLength(1)
  })

  it('sends the caller-supplied filter and sort on every page, advancing only page.number', async () => {
    fetchMock.route('*', (callLog) => {
      const number = Number(callLog.queryParams?.get('page[number]') ?? '1')
      const keys = number < 2 ? ['a', 'b'] : ['c']
      return jsonRoute({
        data: keys.map(meterFixture),
        meta: { page: { number, size: 2, total: 3 } },
      })
    })

    const items: Meter[] = []
    for await (const meter of client().meters.listAll({
      filter: { key: { eq: 'api' } },
      sort: { by: 'createdAt', order: 'desc' },
    })) {
      items.push(meter)
    }

    expect(items).toHaveLength(3)
    const calls = fetchMock.callHistory.calls()
    expect(calls).toHaveLength(2)
    for (const [i, call] of calls.entries()) {
      const q = new URL(call.url).searchParams
      expect(q.get('filter[key][eq]')).toBe('api')
      expect(q.get('sort')).toBe('created_at desc')
      // The first request is whatever the caller supplied β€” no page.number at
      // all, left to the server's own default β€” only later requests carry an
      // explicit page.number, advanced from the previous response.
      expect(q.get('page[number]')).toBe(i === 0 ? null : String(i + 1))
    }
  })

  it('propagates the AbortSignal to every page fetch, and aborting stops iteration', async () => {
    const controller = new AbortController()
    // ky composes the caller's signal into its own dependent AbortSignal
    // before it reaches fetch (its `.aborted` state tracks the original, but
    // it is not the same object), so propagation is verified behaviorally β€”
    // a signal reaches every dispatched request, and aborting mid-iteration
    // stops it β€” rather than by reference identity.
    const signals: (AbortSignal | undefined)[] = []
    fetchMock.route('*', (callLog) => {
      signals.push(callLog.signal)
      const number = Number(callLog.queryParams?.get('page[number]') ?? '1')
      return jsonRoute({
        data: [meterFixture(`m${number}`)],
        meta: { page: { number, size: 1, total: 5 } },
      })
    })

    const keys: string[] = []
    await expect(async () => {
      for await (const meter of client().meters.listAll(undefined, {
        signal: controller.signal,
      })) {
        keys.push(meter.key)
        controller.abort()
      }
    }).rejects.toThrow()

    // The abort races with the second page's already-dispatched request: the
    // mock still resolves a response for it (this route intercepts before
    // ky/fetch's own abort check settles the promise), but the abort still
    // wins β€” no page-2 item is yielded, and the iterable rejects instead of
    // completing normally.
    expect(keys).toEqual(['m1'])
    expect(signals.length).toBeGreaterThanOrEqual(1)
    expect(signals.every((signal) => signal !== undefined)).toBe(true)
  })

  it('throws PaginationLimitExceededError instead of looping forever on a server that never signals the end', async () => {
    let calls = 0
    const fetchPage = async (): Promise<
      Result<{
        data: unknown[]
        meta: { page: { number: number; size: number; total: number } }
      }>
    > => {
      calls++
      return {
        ok: true,
        value: {
          data: [{}],
          meta: {
            page: { number: calls, size: 1, total: Number.MAX_SAFE_INTEGER },
          },
        },
      }
    }

    await expect(async () => {
      for await (const _ of paginatePages(fetchPage, {})) {
        // drain
      }
    }).rejects.toThrow(PaginationLimitExceededError)
    expect(calls).toBe(10_000)
  })
})

describe('paginateCursor (cursor pagination)', () => {
  it('iterates every item across 3 pages via client.events.listAll', async () => {
    const pages: Record<string, { ids: string[]; next?: string }> = {
      '': { ids: ['1', '2'], next: 'cursor-2' },
      'cursor-2': { ids: ['3', '4'], next: 'cursor-3' },
      'cursor-3': { ids: ['5'], next: undefined },
    }
    fetchMock.route('*', (callLog) => {
      const after = callLog.queryParams?.get('page[after]') ?? ''
      const page = pages[after]!
      return jsonRoute({
        data: page.ids.map(eventFixture),
        meta: { page: { next: page.next ?? null } },
      })
    })

    const ids: string[] = []
    for await (const event of client().events.listAll()) {
      ids.push(event.event.id)
    }

    expect(ids).toEqual(['1', '2', '3', '4', '5'])
    expect(fetchMock.callHistory.calls()).toHaveLength(3)
  })

  it('stops after one fetch when the first page has no next cursor', async () => {
    fetchMock.route(
      '*',
      jsonRoute({
        data: [eventFixture('1')],
        meta: { page: { next: null } },
      }),
    )

    const ids: string[] = []
    for await (const event of client().events.listAll()) {
      ids.push(event.event.id)
    }

    expect(ids).toEqual(['1'])
    expect(fetchMock.callHistory.calls()).toHaveLength(1)
  })

  it('fires no further requests once the consumer breaks early', async () => {
    const pages: Record<string, { ids: string[]; next?: string }> = {
      '': { ids: ['1', '2'], next: 'cursor-2' },
      'cursor-2': { ids: ['3'], next: undefined },
    }
    fetchMock.route('*', (callLog) => {
      const after = callLog.queryParams?.get('page[after]') ?? ''
      const page = pages[after]!
      return jsonRoute({
        data: page.ids.map(eventFixture),
        meta: { page: { next: page.next ?? null } },
      })
    })

    for await (const event of client().events.listAll()) {
      expect(event.event.id).toBe('1')
      break
    }

    expect(fetchMock.callHistory.calls()).toHaveLength(1)
  })

  it('feeds meta.page.next back as page.after verbatim (an opaque token, not a URI to fetch)', async () => {
    const pages: Record<string, { ids: string[]; next?: string }> = {
      '': { ids: ['1'], next: 'opaque-token-not-a-url' },
      'opaque-token-not-a-url': { ids: ['2'], next: undefined },
    }
    fetchMock.route('*', (callLog) => {
      const after = callLog.queryParams?.get('page[after]') ?? ''
      const page = pages[after]!
      return jsonRoute({
        data: page.ids.map(eventFixture),
        meta: { page: { next: page.next ?? null } },
      })
    })

    const ids: string[] = []
    for await (const event of client().events.listAll()) {
      ids.push(event.event.id)
    }

    expect(ids).toEqual(['1', '2'])
  })

  it('sends the caller-supplied filter on every page, advancing only page.after', async () => {
    const pages: Record<string, { ids: string[]; next?: string }> = {
      '': { ids: ['1'], next: 'cursor-2' },
      'cursor-2': { ids: ['2'], next: undefined },
    }
    fetchMock.route('*', (callLog) => {
      const after = callLog.queryParams?.get('page[after]') ?? ''
      const page = pages[after]!
      return jsonRoute({
        data: page.ids.map(eventFixture),
        meta: { page: { next: page.next ?? null } },
      })
    })

    for await (const _ of client().events.listAll({
      filter: { subject: { eq: 'customer-1' } },
    })) {
      // drain
    }

    const calls = fetchMock.callHistory.calls()
    expect(calls).toHaveLength(2)
    for (const call of calls) {
      expect(new URL(call.url).searchParams.get('filter[subject][eq]')).toBe(
        'customer-1',
      )
    }
  })

  it('throws PaginationLimitExceededError instead of looping forever on a server that never stops returning a next cursor', async () => {
    let calls = 0
    const fetchPage = async (): Promise<
      Result<{ data: unknown[]; meta: { page: { next: string | null } } }>
    > => {
      calls++
      return {
        ok: true,
        value: { data: [{}], meta: { page: { next: 'again' } } },
      }
    }

    await expect(async () => {
      for await (const _ of paginateCursor(fetchPage, {})) {
        // drain
      }
    }).rejects.toThrow(PaginationLimitExceededError)
    expect(calls).toBe(10_000)
  })
})

describe('AsyncIterable<Item> type inference', () => {
  // Compile-time proof that the facade companions infer the ITEM type, not
  // the page envelope β€” `listAll`'s return type must be exactly
  // `AsyncIterable<Meter>`/`AsyncIterable<IngestedEvent>`, with no cast at the
  // call site required to get there.
  type ListAllItem<T> = T extends AsyncIterable<infer Item> ? Item : never
  type _MetersListAllYieldsMeter = [
    ListAllItem<ReturnType<OpenMeter['meters']['listAll']>>,
  ] extends [Meter]
    ? [Meter] extends [ListAllItem<ReturnType<OpenMeter['meters']['listAll']>>]
      ? true
      : { __error: 'meters.listAll yields something narrower than Meter' }
    : { __error: 'meters.listAll does not yield Meter' }
  const _metersListAllYieldsMeter: _MetersListAllYieldsMeter = true

  type _EventsListAllYieldsIngestedEvent = [
    ListAllItem<ReturnType<OpenMeter['events']['listAll']>>,
  ] extends [IngestedEvent]
    ? [IngestedEvent] extends [
        ListAllItem<ReturnType<OpenMeter['events']['listAll']>>,
      ]
      ? true
      : {
          __error: 'events.listAll yields something narrower than IngestedEvent'
        }
    : { __error: 'events.listAll does not yield IngestedEvent' }
  const _eventsListAllYieldsIngestedEvent: _EventsListAllYieldsIngestedEvent = true

  it('type-checks the item-level inference probes above', () => {
    expect(_metersListAllYieldsMeter).toBe(true)
    expect(_eventsListAllYieldsIngestedEvent).toBe(true)
  })
})