File size: 14,665 Bytes
cee2387 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 | package sync
import (
"context"
"errors"
"log/slog"
"testing"
"github.com/alpacahq/alpacadecimal"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/openmeterio/openmeter/openmeter/llmcost"
)
// mockFetcher implements Fetcher for testing.
type mockFetcher struct {
source llmcost.PriceSource
prices []llmcost.SourcePrice
err error
}
func (m *mockFetcher) Source() llmcost.PriceSource {
return m.source
}
func (m *mockFetcher) Fetch(_ context.Context) ([]llmcost.SourcePrice, error) {
return m.prices, m.err
}
func TestSyncJobRun(t *testing.T) {
adapter := &mockAdapter{}
logger := slog.Default()
t.Run("fetches and reconciles from multiple sources", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Len(t, adapter.upsertedPrices, 1)
})
t.Run("continues on fetcher error", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
err: errors.New("network error"),
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
},
}
fetcher3 := &mockFetcher{
source: "source_c",
prices: []llmcost.SourcePrice{
makePrice("source_c", "openai", "gpt-4", 0.01, 0.03),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2, fetcher3},
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Len(t, adapter.upsertedPrices, 1)
})
t.Run("normalizes model IDs during sync", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "OpenAI", "GPT-4o-20241022", 0.01, 0.03),
},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "openai", "gpt-4o-20241022", 0.01, 0.03),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
})
err := job.Run(context.Background())
require.NoError(t, err)
require.Len(t, adapter.upsertedPrices, 1)
upserted := adapter.upsertedPrices[0]
assert.Equal(t, "openai", string(upserted.Provider))
assert.Equal(t, "gpt-4o", upserted.ModelID)
})
t.Run("no fetchers produces no prices", func(t *testing.T) {
adapter.upsertedPrices = nil
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{},
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Empty(t, adapter.upsertedPrices)
})
t.Run("keeps azure and openai as separate providers", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "azure", "gpt-4", 0.01, 0.03),
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "azure", "gpt-4", 0.01, 0.03),
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
})
err := job.Run(context.Background())
require.NoError(t, err)
require.Len(t, adapter.upsertedPrices, 2)
providers := map[string]bool{}
for _, p := range adapter.upsertedPrices {
providers[string(p.Provider)] = true
}
assert.True(t, providers["azure"])
assert.True(t, providers["openai"])
})
t.Run("filter excludes prices", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_a", "anthropic", "claude-3-5-sonnet", 0.003, 0.015),
},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_b", "anthropic", "claude-3-5-sonnet", 0.003, 0.015),
},
}
// Only include openai models
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
Filter: func(p llmcost.SourcePrice) bool {
return p.Provider == "openai"
},
})
err := job.Run(context.Background())
require.NoError(t, err)
require.Len(t, adapter.upsertedPrices, 1)
assert.Equal(t, "openai", string(adapter.upsertedPrices[0].Provider))
})
t.Run("nil filter includes all prices", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_a", "anthropic", "claude-3-5-sonnet", 0.003, 0.015),
},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_b", "anthropic", "claude-3-5-sonnet", 0.003, 0.015),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Len(t, adapter.upsertedPrices, 2)
})
t.Run("configurable min source agreement", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1},
MinSourceAgreement: 1,
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Len(t, adapter.upsertedPrices, 1)
})
}
func TestDeduplicateSourcePrices(t *testing.T) {
t.Run("no duplicates unchanged", func(t *testing.T) {
prices := []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_a", "anthropic", "claude-3-5-sonnet", 0.003, 0.015),
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
}
result := deduplicateSourcePrices(prices)
assert.Len(t, result, 3)
})
t.Run("removes duplicates within same source", func(t *testing.T) {
prices := []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_a", "openai", "gpt-4", 0.0101, 0.0301), // duplicate after normalization
}
result := deduplicateSourcePrices(prices)
assert.Len(t, result, 1)
assert.Equal(t, "openai", string(result[0].Provider))
})
t.Run("keeps duplicates across different sources", func(t *testing.T) {
prices := []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_b", "openai", "gpt-4", 0.01, 0.03),
}
result := deduplicateSourcePrices(prices)
assert.Len(t, result, 2)
})
t.Run("prefers model name without provider prefix", func(t *testing.T) {
p1 := makePrice("source_a", "openai", "gpt-4", 0.01, 0.03)
p1.ModelName = "azure/gpt-4"
p2 := makePrice("source_a", "openai", "gpt-4", 0.01, 0.03)
p2.ModelName = "GPT-4"
// First entry has prefix, second doesn't — should pick second
result := deduplicateSourcePrices([]llmcost.SourcePrice{p1, p2})
require.Len(t, result, 1)
assert.Equal(t, "GPT-4", result[0].ModelName)
})
t.Run("deterministic tie-breaker when both have clean names", func(t *testing.T) {
p1 := makePrice("source_a", "openai", "gpt-4", 0.01, 0.03)
p1.ModelName = "GPT-4 Turbo"
p2 := makePrice("source_a", "openai", "gpt-4", 0.0101, 0.0301)
p2.ModelName = "GPT-4"
// Second entry has lexicographically smaller name — should win regardless of input order
result := deduplicateSourcePrices([]llmcost.SourcePrice{p1, p2})
require.Len(t, result, 1)
assert.Equal(t, "GPT-4", result[0].ModelName)
// Reverse input order — same winner
result = deduplicateSourcePrices([]llmcost.SourcePrice{p2, p1})
require.Len(t, result, 1)
assert.Equal(t, "GPT-4", result[0].ModelName)
})
t.Run("deterministic tie-breaker when both have prefixed names", func(t *testing.T) {
p1 := makePrice("source_a", "openai", "gpt-4", 0.01, 0.03)
p1.ModelName = "azure_ai/gpt-4"
p2 := makePrice("source_a", "openai", "gpt-4", 0.0101, 0.0301)
p2.ModelName = "azure/gpt-4"
// Second entry has lexicographically smaller name — should win regardless of input order
result := deduplicateSourcePrices([]llmcost.SourcePrice{p1, p2})
require.Len(t, result, 1)
assert.Equal(t, "azure/gpt-4", result[0].ModelName)
// Reverse input order — same winner
result = deduplicateSourcePrices([]llmcost.SourcePrice{p2, p1})
require.Len(t, result, 1)
assert.Equal(t, "azure/gpt-4", result[0].ModelName)
})
t.Run("empty input returns empty", func(t *testing.T) {
result := deduplicateSourcePrices(nil)
assert.Empty(t, result)
})
t.Run("multiple models with mixed duplicates", func(t *testing.T) {
prices := []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
makePrice("source_a", "openai", "gpt-4o", 0.005, 0.015),
makePrice("source_a", "openai", "gpt-4", 0.0101, 0.0301), // dup of gpt-4
makePrice("source_a", "anthropic", "claude-3-5-sonnet", 0.003, 0.015),
makePrice("source_a", "openai", "gpt-4o", 0.005, 0.015), // dup of gpt-4o
}
result := deduplicateSourcePrices(prices)
assert.Len(t, result, 3) // gpt-4, gpt-4o, claude-3-5-sonnet
})
}
func TestSyncJobDeduplication(t *testing.T) {
adapter := &mockAdapter{}
logger := slog.Default()
t.Run("prevents false agreement from provider normalization", func(t *testing.T) {
adapter.upsertedPrices = nil
// source_a returns same model under azure_ai and azure (both normalize to "azure").
// Without dedup, the reconciler would see 2 entries from source_a and consider them
// as agreement. With dedup, source_a contributes only 1 entry per (provider, model_id),
// so 2 sources are still required.
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "azure_ai", "gpt-4", 0.01, 0.03),
makePrice("source_a", "azure", "gpt-4", 0.01, 0.03),
},
}
// source_b does NOT have this model — so no agreement should be reached
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{
makePrice("source_b", "openai", "gpt-3.5-turbo", 0.001, 0.002),
},
}
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
})
err := job.Run(context.Background())
require.NoError(t, err)
// azure/gpt-4 should NOT reconcile: only source_a has it (dedup collapsed azure_ai → azure)
// openai/gpt-3.5-turbo should NOT reconcile: only source_b has it
assert.Empty(t, adapter.upsertedPrices)
})
t.Run("min agreement capped at number of fetchers", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{
makePrice("source_a", "openai", "gpt-4", 0.01, 0.03),
},
}
// MinSourceAgreement defaults to 2, but only 1 fetcher — should cap to 1
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher},
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Len(t, adapter.upsertedPrices, 1)
})
}
func TestSyncJobDefaultFetchers(t *testing.T) {
fetchers := DefaultFetchers(nil)
assert.GreaterOrEqual(t, len(fetchers), 1)
sources := make([]llmcost.PriceSource, len(fetchers))
for i, f := range fetchers {
sources[i] = f.Source()
}
assert.Contains(t, sources, llmcost.PriceSource("models_dev"))
}
func TestSyncJobTolerancePassthrough(t *testing.T) {
adapter := &mockAdapter{}
logger := slog.Default()
t.Run("strict tolerance rejects slight differences", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{{
Source: "source_a",
Provider: "openai",
ModelID: "gpt-4",
Pricing: llmcost.ModelPricing{
InputPerToken: alpacadecimal.NewFromFloat(0.0100),
OutputPerToken: alpacadecimal.NewFromFloat(0.0300),
},
}},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{{
Source: "source_b",
Provider: "openai",
ModelID: "gpt-4",
Pricing: llmcost.ModelPricing{
InputPerToken: alpacadecimal.NewFromFloat(0.0101),
OutputPerToken: alpacadecimal.NewFromFloat(0.0300),
},
}},
}
// Zero tolerance: prices must match exactly
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
PriceTolerance: 0,
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Empty(t, adapter.upsertedPrices)
})
t.Run("loose tolerance accepts slight differences", func(t *testing.T) {
adapter.upsertedPrices = nil
fetcher1 := &mockFetcher{
source: "source_a",
prices: []llmcost.SourcePrice{{
Source: "source_a",
Provider: "openai",
ModelID: "gpt-4",
Pricing: llmcost.ModelPricing{
InputPerToken: alpacadecimal.NewFromFloat(0.0100),
OutputPerToken: alpacadecimal.NewFromFloat(0.0300),
},
}},
}
fetcher2 := &mockFetcher{
source: "source_b",
prices: []llmcost.SourcePrice{{
Source: "source_b",
Provider: "openai",
ModelID: "gpt-4",
Pricing: llmcost.ModelPricing{
InputPerToken: alpacadecimal.NewFromFloat(0.0101),
OutputPerToken: alpacadecimal.NewFromFloat(0.0300),
},
}},
}
// 5% tolerance: should accept
job := NewSyncJob(SyncJobConfig{
Repo: adapter,
Logger: logger,
Fetchers: []Fetcher{fetcher1, fetcher2},
PriceTolerance: 0.05,
})
err := job.Run(context.Background())
require.NoError(t, err)
assert.Len(t, adapter.upsertedPrices, 1)
})
}
|