File size: 8,885 Bytes
16cdcb7 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 | package taxcode_test
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/openmeterio/openmeter/openmeter/taxcode"
taxcodetestutils "github.com/openmeterio/openmeter/openmeter/taxcode/testutils"
"github.com/openmeterio/openmeter/openmeter/testutils"
"github.com/openmeterio/openmeter/pkg/models"
"github.com/openmeterio/openmeter/pkg/pagination"
)
// makeTestSeeds returns two seed entries: "default" (invoicing) and "nontaxable"
// (credit grant). Each test that needs different seeds can build its own, but
// most tests share this helper.
func makeTestSeeds() []taxcode.SeedEntry {
return []taxcode.SeedEntry{
{
Key: taxcode.ProviderDefaultTaxCodeKey,
Name: "Default Tax",
DefaultInvoicing: true,
},
{
Key: "nontaxable",
Name: "Non-Taxable",
DefaultCreditGrant: true,
},
}
}
func TestNamespaceHandler(t *testing.T) {
env := taxcodetestutils.NewTestEnv(t)
t.Cleanup(func() { env.Close(t) })
makeHandler := func(t *testing.T, seeds []taxcode.SeedEntry) *taxcode.NamespaceHandler {
t.Helper()
h, err := taxcode.NewNamespaceHandler(taxcode.NamespaceHandlerConfig{
Logger: env.Logger,
Service: env.Service,
Seeds: seeds,
TransactionManager: env.Adapter,
})
require.NoError(t, err)
return h
}
t.Run("FreshNamespace", func(t *testing.T) {
ns := testutils.NameGenerator.Generate().Key
h := makeHandler(t, makeTestSeeds())
err := h.CreateNamespace(t.Context(), ns)
require.NoError(t, err)
// Both tax codes must exist.
result, err := env.Service.ListTaxCodes(t.Context(), taxcode.ListTaxCodesInput{
Namespace: ns,
Page: pagination.Page{PageSize: 100, PageNumber: 1},
})
require.NoError(t, err)
require.Len(t, result.Items, 2)
keyToTC := make(map[string]taxcode.TaxCode, 2)
for _, tc := range result.Items {
keyToTC[tc.Key] = tc
}
defaultTC, ok := keyToTC["default"]
require.True(t, ok, "default tax code must exist")
assert.True(t, defaultTC.IsManagedBySystem(), "default tax code must be managed by system")
nontaxableTC, ok := keyToTC["nontaxable"]
require.True(t, ok, "nontaxable tax code must exist")
assert.True(t, nontaxableTC.IsManagedBySystem(), "nontaxable tax code must be managed by system")
// Org defaults must reference both.
defaults, err := env.Service.GetOrganizationDefaultTaxCodes(t.Context(), taxcode.GetOrganizationDefaultTaxCodesInput{
Namespace: ns,
})
require.NoError(t, err)
assert.Equal(t, defaultTC.ID, defaults.InvoicingTaxCodeID)
assert.Equal(t, nontaxableTC.ID, defaults.CreditGrantTaxCodeID)
})
t.Run("PreExistingTaxCode", func(t *testing.T) {
ns := testutils.NameGenerator.Generate().Key
// Pre-seed a "default" tax code with a different name and no annotations.
preExisting, err := env.Service.CreateTaxCode(t.Context(), taxcode.CreateTaxCodeInput{
Namespace: ns,
Key: taxcode.ProviderDefaultTaxCodeKey,
Name: "Pre-Existing Default",
})
require.NoError(t, err)
assert.False(t, preExisting.IsManagedBySystem())
h := makeHandler(t, makeTestSeeds())
err = h.CreateNamespace(t.Context(), ns)
require.NoError(t, err)
// The pre-existing "default" must be untouched (same ID, same name).
result, err := env.Service.ListTaxCodes(t.Context(), taxcode.ListTaxCodesInput{
Namespace: ns,
Page: pagination.Page{PageSize: 100, PageNumber: 1},
})
require.NoError(t, err)
require.Len(t, result.Items, 2)
keyToTC := make(map[string]taxcode.TaxCode, 2)
for _, tc := range result.Items {
keyToTC[tc.Key] = tc
}
gotDefault, ok := keyToTC["default"]
require.True(t, ok)
assert.Equal(t, preExisting.ID, gotDefault.ID, "pre-existing ID must not change")
assert.Equal(t, "Pre-Existing Default", gotDefault.Name, "pre-existing name must not change")
// Note: not managed by system because we didn't add annotation when pre-creating.
assert.False(t, gotDefault.IsManagedBySystem())
gotNontaxable, ok := keyToTC["nontaxable"]
require.True(t, ok, "nontaxable must be freshly created")
assert.True(t, gotNontaxable.IsManagedBySystem())
// Org defaults must point at the pre-existing default and the new nontaxable.
defaults, err := env.Service.GetOrganizationDefaultTaxCodes(t.Context(), taxcode.GetOrganizationDefaultTaxCodesInput{
Namespace: ns,
})
require.NoError(t, err)
assert.Equal(t, preExisting.ID, defaults.InvoicingTaxCodeID)
assert.Equal(t, gotNontaxable.ID, defaults.CreditGrantTaxCodeID)
})
t.Run("PreExistingOrgDefaults", func(t *testing.T) {
ns := testutils.NameGenerator.Generate().Key
// Pre-seed both tax codes and a complete org defaults row.
defaultTC, err := env.Service.CreateTaxCode(t.Context(), taxcode.CreateTaxCodeInput{
Namespace: ns,
Key: taxcode.ProviderDefaultTaxCodeKey,
Name: "Default Tax",
Annotations: models.Annotations{
taxcode.AnnotationKeyManagedBy: taxcode.AnnotationValueManagedBySystem,
},
})
require.NoError(t, err)
nontaxableTC, err := env.Service.CreateTaxCode(t.Context(), taxcode.CreateTaxCodeInput{
Namespace: ns,
Key: "nontaxable",
Name: "Non-Taxable",
Annotations: models.Annotations{
taxcode.AnnotationKeyManagedBy: taxcode.AnnotationValueManagedBySystem,
},
})
require.NoError(t, err)
preDefaults, err := env.Service.UpsertOrganizationDefaultTaxCodes(t.Context(), taxcode.UpsertOrganizationDefaultTaxCodesInput{
Namespace: ns,
InvoicingTaxCodeID: defaultTC.ID,
CreditGrantTaxCodeID: nontaxableTC.ID,
})
require.NoError(t, err)
h := makeHandler(t, makeTestSeeds())
err = h.CreateNamespace(t.Context(), ns)
require.NoError(t, err)
// Org defaults must be unchanged.
afterDefaults, err := env.Service.GetOrganizationDefaultTaxCodes(t.Context(), taxcode.GetOrganizationDefaultTaxCodesInput{
Namespace: ns,
})
require.NoError(t, err)
assert.Equal(t, preDefaults.ID, afterDefaults.ID, "org defaults row ID must not change")
assert.Equal(t, preDefaults.InvoicingTaxCodeID, afterDefaults.InvoicingTaxCodeID)
assert.Equal(t, preDefaults.CreditGrantTaxCodeID, afterDefaults.CreditGrantTaxCodeID)
})
t.Run("Idempotency", func(t *testing.T) {
ns := testutils.NameGenerator.Generate().Key
h := makeHandler(t, makeTestSeeds())
// First call.
err := h.CreateNamespace(t.Context(), ns)
require.NoError(t, err)
firstDefaults, err := env.Service.GetOrganizationDefaultTaxCodes(t.Context(), taxcode.GetOrganizationDefaultTaxCodesInput{
Namespace: ns,
})
require.NoError(t, err)
// Second call must be a no-op.
err = h.CreateNamespace(t.Context(), ns)
require.NoError(t, err)
secondDefaults, err := env.Service.GetOrganizationDefaultTaxCodes(t.Context(), taxcode.GetOrganizationDefaultTaxCodesInput{
Namespace: ns,
})
require.NoError(t, err)
assert.Equal(t, firstDefaults.ID, secondDefaults.ID)
assert.Equal(t, firstDefaults.InvoicingTaxCodeID, secondDefaults.InvoicingTaxCodeID)
assert.Equal(t, firstDefaults.CreditGrantTaxCodeID, secondDefaults.CreditGrantTaxCodeID)
assert.Equal(t, firstDefaults.CreatedAt, secondDefaults.CreatedAt, "created_at must not move on second call")
// Only 2 tax codes must exist.
result, err := env.Service.ListTaxCodes(t.Context(), taxcode.ListTaxCodesInput{
Namespace: ns,
Page: pagination.Page{PageSize: 100, PageNumber: 1},
})
require.NoError(t, err)
assert.Len(t, result.Items, 2)
})
}
func TestNewNamespaceHandler_Validation(t *testing.T) {
env := taxcodetestutils.NewTestEnv(t)
t.Cleanup(func() { env.Close(t) })
validSeeds := makeTestSeeds()
t.Run("MissingLogger", func(t *testing.T) {
_, err := taxcode.NewNamespaceHandler(taxcode.NamespaceHandlerConfig{
Service: env.Service,
Seeds: validSeeds,
})
require.Error(t, err)
})
t.Run("MissingService", func(t *testing.T) {
_, err := taxcode.NewNamespaceHandler(taxcode.NamespaceHandlerConfig{
Logger: env.Logger,
Seeds: validSeeds,
})
require.Error(t, err)
})
t.Run("EmptySeeds", func(t *testing.T) {
_, err := taxcode.NewNamespaceHandler(taxcode.NamespaceHandlerConfig{
Logger: env.Logger,
Service: env.Service,
Seeds: nil,
})
require.Error(t, err)
})
t.Run("MissingTransactionManager", func(t *testing.T) {
_, err := taxcode.NewNamespaceHandler(taxcode.NamespaceHandlerConfig{
Logger: env.Logger,
Service: env.Service,
Seeds: validSeeds,
})
require.Error(t, err)
})
t.Run("ValidConfig", func(t *testing.T) {
h, err := taxcode.NewNamespaceHandler(taxcode.NamespaceHandlerConfig{
Logger: env.Logger,
Service: env.Service,
Seeds: validSeeds,
TransactionManager: env.Adapter,
})
require.NoError(t, err)
require.NotNil(t, h)
})
}
|